[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #9 from Katrin Fischer --- Passing QA on this as agreed with RM - both parties heavily using EDIFACT have been involved in the QA process. Tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added Attachment #93674|0 |1 is obsolete|| Attachment #93675|0 |1 is obsolete|| Attachment #93943|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 93944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93944=edit Bug 21580: Add test for message buyer_ean method Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #8 from Katrin Fischer --- Created attachment 93945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93945=edit Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #6 from Katrin Fischer --- Created attachment 93943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93943=edit Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Brendan Gallagher changed: What|Removed |Added Attachment #80663|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Attachment #80662|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #4 from Brendan Gallagher --- Created attachment 93674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93674=edit Bug 21580 Add test for message buyer_ean method Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #5 from Brendan Gallagher --- Created attachment 93675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93675=edit Bug 21580 Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Order creation for edifact |Order creation for EDIFACT |vendor fails|vendor fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for edifact vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #3 from Hayley Mapley --- (In reply to Colin Campbell from comment #2) > Created attachment 80663 [details] [review] > pass the buyer_ean to order routine > > Call of the subroutine now matchs documentation and passes parameter > validation Hi, is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for edifact vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Colin Campbell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell --- Created attachment 80663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80663=edit pass the buyer_ean to order routine Call of the subroutine now matchs documentation and passes parameter validation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for edifact vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #1 from Colin Campbell --- Created attachment 80662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80662=edit Add a test for message buyer_ean method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/