[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Margaret changed: What|Removed |Added Version(s)||18.11.01 released in|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Owen Leonard changed: What|Removed |Added Blocks||23502 Referenced Bugs:

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary.

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 rkui...@roundrocktexas.gov changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #38 from Nick Clemens --- (In reply to Nick Clemens from comment #37) > Created attachment 83541 [details] [review] > Bug 21608: [18.05.X] disable dropdown and add revert button Please test thoroughly - dropdown counts

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #37 from Nick Clemens --- Created attachment 83541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83541=edit Bug 21608: [18.05.X] disable dropdown and add revert button -- You are receiving this mail

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable ---

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #31 from Marcel de Rooy --- Created attachment 82957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82957=edit Bug 21608: Add ID and fix filters Signed-off-by: Marcel de Rooy -- You are receiving

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Attachment #82157|0 |1 is obsolete|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #32 from Marcel de Rooy --- Created attachment 82958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82958=edit Bug 21608: Add value for 'rank-request' when dropdwn disabled When a field is disabled no

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #29 from Nick Clemens --- Created attachment 82652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82652=edit Bug 21608: Add value for 'rank-request' when dropdwn disabled When a field is disabled no

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #28

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #27 from Nick Clemens --- Created attachment 82322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82322=edit Bug 21608: Add ID and fix filters -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #26 from Nick Clemens --- (In reply to Marcel de Rooy from comment #25) > Oops forgot this suggestion: > Rename: Revert found status => Revert waiting status This affects 'In-transit' holds too, I will add an id to the

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #25 from Marcel de Rooy --- Oops forgot this suggestion: Rename: Revert found status => Revert waiting status And two functional questions: Should someone be informed about this revert? Or should we make the button

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Attachment #81835|0 |1 is obsolete|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #24 from Marcel de Rooy --- This is a Passed QA with some reservation (as is appropriate for holds patches indeed :) I do not feel completely comfortable with the patch somehow. Intuitively. But I cant say that it is

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Attachment #81272|0 |1 is obsolete|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #22 from Marcel de Rooy --- Hmm. If I have one waiting and one on pos 1, I can select pos 2 in the priority box and it automatically selects pos 1 again. This is sort of OK but still confusing. Pos 2 should not be there.

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #21 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #20) > (In reply to Jonathan Druart from comment #14) > > Tests missing. > > Definitely! Interventions in Reserves need tests. And reverting change A

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #14) > Tests missing. Definitely! Interventions in Reserves need tests. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #18 from Marcel de Rooy --- FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc FAIL filters missing_filter at line 194 () -- You are receiving this mail

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Keywords|rel_18_05_candidate | --- Comment #19 from

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Bug 21608 depends on bug 21611, which changed state. Bug 21611 Summary: Priority in request.pl shows 1 instead of Waiting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 What|Removed

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #16 from Nick Clemens --- Created attachment 81835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81835=edit Bug 21608: (follow-up) Use RevertWaitingStatus and do not alter _FixPriority -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Christopher Brannon changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Blocks||21729 --- Comment #13 from

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #12 from Katrin Fischer --- Hm, I wasn't aware it has ever worked (changing priority once waiting). So only one fix needed then: When you revert, you need to clear the expiration date, or the reverted hold will expire

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #11 from Nick Clemens --- (In reply to Katrin Fischer from comment #10) > Sorry, might have missed a reload, display is now correct for the items. > > I see some problems with reverting: > > If the patron has chosen an

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #10 from Katrin Fischer --- Sorry, might have missed a reload, display is now correct for the items. I see some problems with reverting: If the patron has chosen an expiration date on placing the hold, it will be

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Martin Renvoize changed: What|Removed |Added Attachment #81134|0 |1 is obsolete|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Attachment #81131|0 |1 is obsolete|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #4 from Nick Clemens --- While this patch depends on 21611 we will need an 18.05 version which does not. Can provide once this one is through QA -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Keywords||rel_18_05_candidate,

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Attachment #80933|0 |1 is obsolete|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #2 from Nick Clemens --- Created attachment 80933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80933=edit Bug 21608: WIP - attempt to fix priority dropdowns (18.05 based) -- You are receiving this

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Kelly McElligott changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added CC||margaret@bywatersolutions.c

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Depends on||19636 --- Comment #1 from

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Version|18.05 |master -- You are

[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added CC||k...@bywatersolutions.com