[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Andrew changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #12 from Andrew --- This is sort of moot, since this is already resolved, but it looks like this bug isn't/wasn't actually allowing checkout. Koha gives you a checkout box, but when you actually try to check something out it blocks it, tells you the patron has a restriction, and doesn't give an override option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #11 from Fridolin SOMERS --- Depends on Bug 19933 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Depends on||19933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Marcel de Rooy changed: What|Removed |Added Attachment #82201|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 82377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82377=edit Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear Signed-off-by: Pierre-Marc Thibault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #7 from Katrin Fischer --- (In reply to Pierre-Marc Thibault from comment #5) > It works, but I saw the form at the final step because AllowFineOverride was > set at "Allow". That's just a remainder for future reviewers. Thx for pointing this out! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Pierre-Marc Thibault changed: What|Removed |Added Attachment #82121|0 |1 is obsolete|| --- Comment #6 from Pierre-Marc Thibault --- Created attachment 82201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82201=edit Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com --- Comment #5 from Pierre-Marc Thibault --- It works, but I saw the form at the final step because AllowFineOverride was set at "Allow". That's just a remainder for future reviewers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|18.05 |master Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #4 from Katrin Fischer --- Created attachment 82121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82121=edit Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796
--- Comment #3 from Katrin Fischer ---
I think the problem is here:
$noissues = ( not C4::Context->preference("AllowFineOverride") and ( $owing >
$noissuescharge ) );
It can reset noissues, even if it has already been set to 1 before.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #2 from Katrin Fischer --- Did git bisect for the fun of it... lead me here: commit bddfed75913a2302c19c00b00a6fe86538af6f9f Author: Jonathan Druart Date: Sun Jan 7 14:57:23 2018 -0300 Bug 19933: Remove patronflags - tricky ones -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21796] Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Confirmed on master, having a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
