[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #31 from Marcel de Rooy --- Thx for following up, Martin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #30 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #29 from Martin Renvoize --- Created attachment 101667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101667=edit Bug 21800: (RM follow-up) Fix unit tests We were not setting the repeatable flag for

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #28 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99520|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99519|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99517|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99518|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #23 from Marcel de Rooy --- (In reply to Ere Maijala from comment #18) > I failed to realize that the code checks for the pipe character first. So > the database call doesn't actually get executed that often. Sorry about

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Attachment #99313|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Attachment #99311|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Attachment #99310|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Attachment #99309|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #18 from Ere Maijala --- (In reply to Marcel de Rooy from comment #17) > (In reply to Ere Maijala from comment #16) > > If it's in a separate issue, how do we make sure bug 24715 and this one are > > committed at same

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #17 from Marcel de Rooy --- (In reply to Ere Maijala from comment #16) > If it's in a separate issue, how do we make sure bug 24715 and this one are > committed at same time? My concern is that this one alone will

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #16 from Ere Maijala --- If it's in a separate issue, how do we make sure bug 24715 and this one are committed at same time? My concern is that this one alone will introduce a serious performance regression, and if 24715

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Blocks||24715 Referenced Bugs:

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #15 from Marcel de Rooy --- (In reply to Ere Maijala from comment #13) > Sorry, I'd say that caching is pretty crucial. TransformKohaToMarc is used > also e.g. in the Elasticsearch index builder, OAI-PMH Provider and

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #14 from Marcel de Rooy --- (In reply to Ere Maijala from comment #13) > Ok, I'm fine with the framework stuff, but it strikes me a bit odd that we > use mapping from default framework and repeatability from another.

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #10 from Ere Maijala --- Why isn't the default framework also authoritative for repeatability? If not, at least the framework information should be fetched e.g. with GetMarcSubfieldStructure so that it's cached to avoid

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What|Removed |Added CC||ere.maij...@helsinki.fi --

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Attachment #99312|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #8 from Marcel de Rooy --- Created attachment 99312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99312=edit Bug 21800: Add tests for _check_split This new subroutine supports checking the repeatable

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Attachment #98816|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #7 from Marcel de Rooy --- Created attachment 99311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99311=edit Bug 21800: Check the correct framework for the repeatable tag This depends on the

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Attachment #98817|0 |1 is obsolete|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Severity|normal |enhancement -- You are

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #4 from Marcel de Rooy --- Created attachment 98817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98817=edit Bug 21800: Make TransformKohaToMarc aware of non-repeatable subfields If a kohafield (in

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #3 from Marcel de Rooy --- Created attachment 98816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98816=edit Bug 21800: Add tests for repeatable subfields Test plan: Do not apply the second patch

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #2 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > At the same time wondering if we not should allow some item subfields to be > repeatable just as some under in MARC21 852 ? We should. We can

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #1 from Marcel de Rooy --- At the same time wondering if we not should allow some item subfields to be repeatable just as some under in MARC21 852 ? -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED