[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #21 from Martin Renvoize --- ack.. ignore that.. we can't go that way around either as it's a one issue may refer to many accountlines... i -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #20 from Martin Renvoize --- Hmm, you're right Kyle. I think the relationship should probably the in the opposite direction in that case.. with the issues and old_issues tables each having an accountline_id field

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #18 from Jonathan Druart --- Comment on attachment 85614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85614 Bug 22008: Add missing constraints to accountlines Review of attachment 85614: -->

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #17 from Martin Renvoize --- Rebased and switch to `foreign_key_exists` method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #85267|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #85268|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Bug 22008 depends on bug 21065, which changed state. Bug 21065 Summary: Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Blocks||7811 Referenced Bugs:

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #14 from Martin Renvoize --- To test this you'll need to run the dbic schema updates script. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83462|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83461|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83460|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #10 from Martin Renvoize --- Oh.. I also made the DB update more reliably idempotent (so this can be easily backported if we want) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #9 from Martin Renvoize --- Tests added, rebased now that 21065 is in master and DBIC Schema Updates patch added for easy testing. Man I wish we could just use the relations the dbic gives us for free once we have

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #7 from Martin Renvoize --- Created attachment 83461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83461=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83280|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #8 from Martin Renvoize --- Created attachment 83462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83462=edit Bug 22008: DBIC Schema Updates -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #4) > Good point.. tests for this hadn't even crossed my mind. I'll have a ponder > as to what they should be. See bug 21065 :) -- You are

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #4 from Martin Renvoize --- Good point.. tests for this hadn't even crossed my mind. I'll have a ponder as to what they should be. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #3 from Jonathan Druart --- Could you provide tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83278|0 |1 is obsolete|

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #1 from Martin Renvoize --- Created attachment 83278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83278=edit Bug 22008: Add missing constraints to accountlines -- You are receiving this mail

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Target Milestone|--- |19.05 -- You are

[Koha-bugs] [Bug 22008] Missing constraints on accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Blocks||14825 Depends