[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #21 from Martin Renvoize --- ack.. ignore that.. we can't go that way around either as it's a one issue may refer to many accountlines... i -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #20 from Martin Renvoize --- Hmm, you're right Kyle. I think the relationship should probably the in the opposite direction in that case.. with the issues and old_issues tables each having an accountline_id field referencing account lines rather than the current case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #19 from Kyle M Hall --- Won't this cause all accountline issue_ids to be nullified on checkin? I think that's a showstopper for that constraint. One solution would be to have issue_id and old_issue_id columns in the accountlines, and move the issue_id between them at checkin time. Also, Bug 19489 relies on issue_id not being nullified at checkin time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008
--- Comment #18 from Jonathan Druart
---
Comment on attachment 85614
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85614
Bug 22008: Add missing constraints to accountlines
Review of attachment 85614:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=22008=85614)
-
Replace NOT IN with LEFT JOIN... NOT NULL?
::: installer/data/mysql/atomicupdate/bug_22008.perl
@@ +14,5 @@
> +$dbh->do("ALTER TABLE accountlines ADD CONSTRAINT
> `accountlines_ibfk_issues` FOREIGN KEY (`issue_id`) REFERENCES `issues`
> (`issue_id`) ON DELETE SET NULL ON UPDATE CASCADE");
> +}
> +
> +# Rename accountlines_ibfk_2 to accountlines_ibfk_items
> +if( foreign_key_exists( 'accountlines', 'accountlines_ibfk_2' ) ) {
You should test for accountlines_ibfk_items as well.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #17 from Martin Renvoize --- Rebased and switch to `foreign_key_exists` method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #85267|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 85614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85614=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #85268|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 85613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85613=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22368 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Bug 22008 depends on bug 21065, which changed state. Bug 21065 Summary: Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Blocks||7811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #14 from Martin Renvoize --- To test this you'll need to run the dbic schema updates script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83462|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83461|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 85268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85268=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83460|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 85267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85267=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #11 from Maryse Simard --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22008: Add missing constraints to accountlines Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 22008: Add missing constraints to accountlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #10 from Martin Renvoize --- Oh.. I also made the DB update more reliably idempotent (so this can be easily backported if we want) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #9 from Martin Renvoize --- Tests added, rebased now that 21065 is in master and DBIC Schema Updates patch added for easy testing. Man I wish we could just use the relations the dbic gives us for free once we have proper constraints :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #7 from Martin Renvoize --- Created attachment 83461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83461=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83280|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 83460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83460=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #8 from Martin Renvoize --- Created attachment 83462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83462=edit Bug 22008: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #4) > Good point.. tests for this hadn't even crossed my mind. I'll have a ponder > as to what they should be. See bug 21065 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #4 from Martin Renvoize --- Good point.. tests for this hadn't even crossed my mind. I'll have a ponder as to what they should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #3 from Jonathan Druart --- Could you provide tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Attachment #83278|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 83280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83280=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #1 from Martin Renvoize --- Created attachment 83278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83278=edit Bug 22008: Add missing constraints to accountlines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Target Milestone|--- |19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Blocks||14825 Depends on||21065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 [Bug 21065] Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
