[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-03-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Jonathan Druart changed: What|Removed |Added Resolution|FIXED |WONTFIX -- You are

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Martin Renvoize changed: What|Removed |Added Status|REOPENED|RESOLVED

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #12 from Nick Clemens --- Reverted from master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Martin Renvoize changed: What|Removed |Added Status|RESOLVED|REOPENED

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #11 from Martin Renvoize --- Ack, as this would require use packaging a more recent version of perlcritic I don't feel it's a big enough win to warrant the cleanup.. I'm inclined to agree with Jonathan that this point

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #10 from Jonathan Druart --- I guess it is: https://github.com/Perl-Critic/Perl-Critic/blob/dev/Changes 1.124 2015-02-27 * The RequireUseStrict and RequireUseWarnings policies now regard Moose, Moo, Mouse,

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Also Jenkins is failing because of that move, see > https://jenkins.koha-community.org/job/Koha_Master_D8/163/ > I do not understand why it is

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #8 from Jonathan Druart --- I am not sure this was a good move, compare what it brings with the changes we need to make. Anyway, now we need to update the coding guidelines and update our t/perlcriticrc (I think).

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84179|0 |1 is obsolete|

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 David Nind changed: What|Removed |Added Attachment #84119|0 |1 is obsolete|

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #2 from Jasmine Amohia --- Created attachment 84119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84119=edit Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes Test plan: 1) Check all

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Jasmine Amohia changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Jasmine Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2019-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz

[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes

2018-12-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Jonathan Druart changed: What|Removed |Added CC|