[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added Attachment #88270|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 88271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88271=edit Bug 22200: Add Tests for change Unit tests to check for the addition of a credit of type 'FOR' when _FixOverduesOnReturn is called with $exemptfine set to true. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added Attachment #88269|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 88273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88273=edit Bug 22200: Add credit when forgiving overdue Prior to this patch the exemptfine option for_FixOverduesOnReturn would directly set the overdue amount to 0 rather than creating an appropriate credit of the type forgiven and offseting it against the debt. Test Plan: 1) Find a checkout that is overdue with fines 2) Check the item in with the forgive fines option checked 3) Note that the users account details now shows the overdue as forgiven and a forgiven credit is added which matches the overdue amount (and is applied against it, i.e. both overdue and forgiven lines have 0 amountoutstanding). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17483 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #13 from Martin Renvoize --- Test Plan: 1) Find a checkout that is overdue with fines 2) Check the item in with the forgive fines option checked 3) Note that the users account details now shows the overdue as forgiven and a forgiven credit is added which matches the overdue amount (and is applied against it, i.e. both overdue and forgiven lines have 0 amountoutstanding). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #11 from Martin Renvoize --- Created attachment 88269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88269=edit Bug 22200: Add credit when forgiving overdue Prior to this patch the exemptfine option for_FixOverduesOnReturn would directly set the overdue amount to 0 rather than creating an appropriate credit of the type forgiven and offseting it against the debt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added Attachment #85219|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #12 from Martin Renvoize --- Created attachment 88270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88270=edit Bug 22200: Add Tests for change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added Blocks||22563 Depends on||22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added Assignee|k...@bywatersolutions.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Funny.. I was just thinking "Why are we not creating an offsetting writeoff/forgiven whatever credit here instead of updating the overdue amounts directly?" I'm going to adopt this bug and push it into the appropriate spot in the accountlines status tree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #9 from Kyle M Hall --- I think we're barking up the wrong tree here. At this time, I think updating the date column is a *bad* idea. It is our 'created on' date, and timestamp is our 'last updated on' date. Really, we shouldn't be changing the fee type to FFOR, we should be generating a FFOR payment and applying it to the fee. I'm going to ask Tomas to chime in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Katrin Fischer changed: What|Removed |Added Attachment #84339|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 85219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85219=edit Bug 22200: Forgiving a fine (FFOR) does not update the accountline date Each time a fine is incremented, the date column is updated. When that fine is forgiven ( often via the "Forgive fines" option on the checkin page ), it does not update the column. It makes sense that if updating a fine sets the date column, forgiving it should do so as well. Test Plan: 1) Find a checkout that is overdue with fines, where the date is not today 2) Note the date in the accountlines table 3) Check it in, note the date is not updated 4) Apply this patch 5) Repeat steps 1-2 6) Note the date is updated! Signed-off-by: Genevieve Beaudry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- I've fixed the commit subject and added Genevieve's sign-off line manually. But I am a little confused here :( I started my tests with verifying the current behavior and noticed that accountlines.date is already updated to the current date when the entry is changed to FFOR in my testing. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Genevieve Beaudry changed: What|Removed |Added CC||genevieve.beaudry@inlibro.c ||om Status|Needs Signoff |Signed Off --- Comment #6 from Genevieve Beaudry --- patch working -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #5 from Kyle M Hall --- (In reply to Pierre-Marc Thibault from comment #3) > Sorry, I didn't follow the steps precisely. I didn't test on the checking in > page, but I did by the Create manual credit way and it wasn't still working. To test, you'll need a checked out overdue item with fines. Nothing else will work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #4 from Kyle M Hall --- (In reply to Pierre-Marc Thibault from comment #2) > I created a fine and changed it so its date is not today. I went to Pay > fines and paid, but the date did not update. Am I doing something wrong? That is not the action I meant. You'll need to check in the item with the "forgive fine" option from the checkins page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #3 from Pierre-Marc Thibault --- Sorry, I didn't follow the steps precisely. I didn't test on the checking in page, but I did by the Create manual credit way and it wasn't still working. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com --- Comment #2 from Pierre-Marc Thibault --- I created a fine and changed it so its date is not today. I went to Pay fines and paid, but the date did not update. Am I doing something wrong? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #1 from Kyle M Hall --- Created attachment 84339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84339=edit Bug 22200 - Forgiving a fine (FFOR) does not update the accountline date Each time a fine is incremented, the date column is updated. When that fine is forgiven ( often via the "Forgive fines" option on the checkin page ), it does not update the column. It makes sense that if updating a fine sets the date column, forgiving it should do so as well. Test Plan: 1) Find a checkout that is overdue with fines, where the date is not today 2) Note the date in the accountlines table 3) Check it in, note the date is not updated 4) Apply this patch 5) Repeat steps 1-2 6) Note the date is updated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
