[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Martin Renvoize changed: What|Removed |Added Status|NEW |RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |WONTFIX --- Comment #2 from Martin Renvoize --- 18.05 is officially end of life at this point and I believe this bug is fixed in more recent versions... certainly, accountno was removed in 19.05, though not backported to 18.11 as far as I'm aware.. at this point, I would suggest we close this bug recommend an upgrade to 19.05 or above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21683 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--- Comment #1 from Nick Clemens ---
The issue appears to be from incorrectly assigned 'accountno' in
Koha::Account->pay
88 # We should remove accountno, it is no longer needed
89 my $last = $self->lines->search(
90 {},
91 { order_by => 'accountno' } )->next();
92 my $accountno = $last ? $last->accountno + 1 : 1;
The default order is ASC, so we end up assigning the lowest here
Then in C4::Circulation->_FixAccountForLostAndReturned
2387 # check for charge made for lost book
2388 my $accountlines = Koha::Account::Lines->search(
2389 {
2390 itemnumber => $itemnumber,
2391 accounttype => { -in => [ 'L', 'Rep', 'W' ] },
2392 },
2393 {
2394 order_by => { -desc => [ 'date', 'accountno' ] }
2395 }
2396 );
We order the lines by accountno to get the most recent, however, the numbers
are wrong so we don't get the most recent payment or write off.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
