[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 David Nind changed: What|Removed |Added Text to go in the||This adds checks so that release notes||borrowers can't cancel ||holds that have a transit ||or waiting status when ||using the ILS-DI web ||service's CancelHold ||method. These checks now ||reflect the same behaviour ||seen on the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to stable|Needs documenting --- Comment #17 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|22.05.00|22.05.00,21.11.06 released in|| --- Comment #16 from Kyle M Hall --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 --- Comment #15 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- Nice one Arthur, great to see these getting some love All working, Unit tests reads well and passes.. QA script happy PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Martin Renvoize changed: What|Removed |Added Attachment #125232|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 133904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133904=edit Bug 22379: Unit tests for CancelHold service Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Martin Renvoize changed: What|Removed |Added Attachment #125230|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 133903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133903=edit Bug 22379: Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. Test plan (before patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "RecordNotFound" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower Test plan (after patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. Signed-off-by: Laurence Rault Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Attachment #125231|0 |1 is obsolete|| --- Comment #11 from Arthur Suzuki --- Created attachment 125232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125232=edit Bug 22379: Unit tests for CancelHold service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 --- Comment #10 from Arthur Suzuki --- Hello, I've rebased and reuploaded the patches. I also have tests failing but they seem to fail also on master : # Failed test 'Record hold, Item cannot be transferred' # at t/db_dependent/ILSDI_Services.t line 558. # got: undef # expected: 'cannotBeTransferred' Hope this will pass QA now! Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 --- Comment #9 from Arthur Suzuki --- Created attachment 125231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125231=edit Bug 22379: Unit tests for CancelHold service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Attachment #97959|0 |1 is obsolete|| Attachment #97960|0 |1 is obsolete|| --- Comment #8 from Arthur Suzuki --- Created attachment 125230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125230=edit Bug 22379: Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. Test plan (before patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "RecordNotFound" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower Test plan (after patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Text to go in the|Checks for the | release notes|"AllowHoldOnPatronPossessio | |n" policy is now even | |across all interfaces | |(Staff, Opac, WebServices). | |Bypassing this policy from | |Staff interface needs to be | |enforced with | |"AllowHoldPolicyOverride" | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Text to go in the||Checks for the release notes||"AllowHoldOnPatronPossessio ||n" policy is now even ||across all interfaces ||(Staff, Opac, WebServices). ||Bypassing this policy from ||Staff interface needs to be ||enforced with ||"AllowHoldPolicyOverride" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||da...@davidnind.com
--- Comment #7 from David Nind ---
I'm happy to test if you could provide some example URLs for ILS-DI requests
and the required parameters.
Notes:
- The patch still applies
- Tests don't pass:
root@722db1e0af2e:koha(bz22379)$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 6/10 Use of uninitialized value $charge in
numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2991.
t/db_dependent/ILSDI_Services.t .. 8/10 # No tests run!
t/db_dependent/ILSDI_Services.t .. 9/10
# Failed test 'No tests run for subtest "CancelHold"'
# at t/db_dependent/ILSDI_Services.t line 698.
Can't use string ("Su0VSFAs") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Reserves.pm line 175.
# Looks like your test exited with 255 just after 9.
t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 2/10 subtests
Test Summary Report
---
t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 9 Failed: 1)
Failed test: 9
Non-zero exit status: 255
Parse errors: Bad plan. You planned 10 tests but ran 9.
Files=1, Tests=9, 14 wallclock secs ( 0.04 usr 0.00 sys + 11.33 cusr 1.57
csys = 12.94 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 --- Comment #6 from Arthur Suzuki --- Created attachment 97960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97960=edit Bug 22379: Unit tests for CancelHold service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Attachment #94387|0 |1 is obsolete|| --- Comment #5 from Arthur Suzuki --- Created attachment 97959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97959=edit Bug 22379: Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. Test plan (before patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "RecordNotFound" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower Test plan (after patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens --- Unit tests please -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Attachment #85414|0 |1 is obsolete|| --- Comment #3 from Arthur Suzuki --- Created attachment 94387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94387=edit Bug 22379 : Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. Test plan (before patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "RecordNotFound" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower Test plan (after patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Severity|enhancement |minor Priority|P4 |P5 - low -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Priority|P5 - low|P4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Attachment #85413|0 |1 is obsolete|| --- Comment #2 from Arthur Suzuki --- Created attachment 85414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85414=edit Bug 22379 : Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. Test plan (before patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "RecordNotFound" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower Test plan (after patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 --- Comment #1 from Arthur Suzuki --- Created attachment 85413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85413=edit Bug 22379 : Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
