[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #22 from Andrew Fuerste-Henry --- I have now. Bug 24858. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||24858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #21 from Jonathan Druart --- Andrew, did you open a bug report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #20 from Andrew Fuerste-Henry --- Just testing this and Jonathan is correct. To verify in master: - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) This is 100% my error, thanks for catching it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #19 from Jonathan Druart --- I think there is something wrong: About the pref ExcludeHolidaysFromMaxPickUpDelay, we switch "yes" (value=1) from "Allow Closed days to be taken into account in reserves max pickup delay" to "Ignore the calendar when calculating the period for reserves max pickup delay." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #18 from Lucas Gass --- Oops, I was too hasty with my backport. This bug has a dependency that is not in 19.05.x, reverting this. No backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable --- Comment #17 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.02 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #16 from Joy Nelson --- Pushed to 19.11.x for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #14 from Jonathan Druart --- We have a quick long option now, may be problematic for translated interface (?) https://snipboard.io/4cwWXl.jpg Passing QA anyway, not blocker (hopefully) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart changed: What|Removed |Added Attachment #96262|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 96316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96316=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. Signed-off-by: Bernardo Gonzalez Kriegel Fixed double 'when' on line 740 No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96002|0 |1 is obsolete|| --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 96262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96262=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. Signed-off-by: Bernardo Gonzalez Kriegel Fixed double 'when' on line 740 No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Attachment #95241|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 96002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96002=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #10 from Andrew Fuerste-Henry --- Good catch! Thanks, Jonathan! So, following the wording used above, that's be: (Use the calendar/Ignore the calendar) when calculating the period for suspension expiration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart --- I think you need to update the recently added SuspensionsCalendar as well 844 - Calculate suspension expiration based on days overdue 845 - pref: SuspensionsCalendar 846 type: choice 847 choices: 848 ignoreCalendar: directly. 849 noSuspensionsWhenClosed: not including days the library is closed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bill Carroll changed: What|Removed |Added CC||bcarr...@dubuque.lib.ia.us Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Attachment #95127|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 95241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95241=edit Bug 22381: Change wording on Calendar-related system preferences TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #7 from Jonathan Druart --- Conflict with bug 13958, please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 ByWater Sandboxes changed: What|Removed |Added Attachment #94925|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 95127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95127=edit Bug 22381: Change wording on Calendar-related system preferences Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Depends on||15260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 [Bug 15260] Option for extended loan with useDaysMode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #5 from Lucas Gass --- Created attachment 94925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94925=edit Bug 22381: Change wording on Calendar-related system preferences Rebased this patch so it will apply with bz15260, test plan remains the same TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Attachment #94791|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #4 from Lucas Gass --- Created attachment 94791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94791=edit Bug 22381: Change wording on Calendar-related system preferences TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #3 from Andrew Fuerste-Henry --- I'd go with: useDaysMode: (Use the calendar to skip days the library is closed / Use the calendar to push the due date to the next open day / Ignore the calendar) when calculating the date due. OverdueNoticeCalendar: (Use the calendar/Ignore the calendar) when calculating the period for overdue notices. finesCalendar: (Use the calendar/Ignore the calendar) when calculating the period for fines. ExcludeHolidaysFromMaxPickUpDelay: (Use the calendar/Ignore the calendar) when calculating the period for reserves max pickup delay. This makes all four follow the general syntax that's currently used for OverdueNoticeCalendar, which is really clear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Andrew, do you want to make a suggestion for rewording? I could write up a patch from that or maybe you would want to do it? I'd read it like that: Allow closed days to be taken into account = we are not counting them, using the calendar, counting days the library is open) Don't allow closed days to be taken into account = we are counting them, ignoring the calendar, only counting 'days') -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #1 from Andrew --- Furthermore "closed days to be taken into account" on ExcludeHolidaysFromMaxPickUpDelay is very much open to two contradictory readings. Does taking closed days "into account" mean we are *counting* those days? Or does it mean we *are* using the calendar and therefore *not counting* those days? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
