https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #84 from Victor Grousset/tuxayo ---
(In reply to Magnus Enger from comment #10)
> This fixes a major security problem, I'm upping the importance and changing
> the component from ILL to "REST API".
Wow, I missed that.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Mason James changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Andrew Isherwood changed:
What|Removed |Added
CC|andrew.isherwood@ptfs-europ |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #83 from Aleisha Amohia ---
(In reply to Mason James from comment #81)
> hi Martin
> this behaviour is actually expected
>
> the 'koha on debian-10' APT fixes have currently only been applied to the
> koha dev and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #82 from Aleisha Amohia ---
(In reply to Mason James from comment #81)
> the following patches are required to be applied to the 19.11.x branch for
> this to happen
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #81 from Mason James ---
(In reply to Martin Renvoize from comment #80)
> Even more confused.. seems we're using those versions elsewhere too.. so I'm
> not understanding how the tests are passing elsewhere but not no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #80 from Martin Renvoize ---
Even more confused.. seems we're using those versions elsewhere too.. so I'm
not understanding how the tests are passing elsewhere but not no D10.
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #79 from Martin Renvoize ---
I'm confused.. in the 19.11 D10 package we seem to be getting the following
Mojolicious::Plugin::OpenAPI version:
kohadev-koha@ecc849b0f6ab:/kohadevbox/koha$ apt-cache policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #78 from Jonathan Druart
---
(In reply to Aleisha Amohia from comment #76)
> Jenkins is happy now :) backported to 19.11.x for 19.11.07
It seems that there is something wrong for D10 however:
19.11_D10 (#14)
18:34:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #77 from Victor Grousset/tuxayo ---
I got a conflict when trying to backport to 19.05. (note the tests pass without
these patches, no API issues on 19.05)
I'm not sure about InstallPlugins, it doesn't exist in 19.05 vs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Aleisha Amohia changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Aleisha Amohia changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #75 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #73)
> Created attachment 105692 [details] [review]
> [19.11.x] Bug 22522: Adjust tests to previous changes
>
> Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #74 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #72)
> 19.11: There is something wrong in the paths, and so plack does not start
> correctly.
> I have cherry-picked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #73 from Tomás Cohen Arazi ---
Created attachment 105692
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105692=edit
[19.11.x] Bug 22522: Adjust tests to previous changes
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #72 from Jonathan Druart
---
19.11: There is something wrong in the paths, and so plack does not start
correctly.
I have cherry-picked a07c5c153aaecc5cc8b0d1de5c53f184da5971b9
Bug 25279: Add general query parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #70 from Martin Renvoize ---
Awesome.. glad to hear it worked well for your Jonathan.. I think my OOM's were
local.. seems my dev server was due of a little maintenance and I can confirm
that test now pass for me too :)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #68 from Jonathan Druart
---
Created attachment 105659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105659=edit
Bug 22522: [19.11.x] Fix several REST API tests
Fixes among others the invalid use of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #69 from Jonathan Druart
---
I have tested Martin's remote branch on master-bionic and 19.11-bionic: all
tests pass!
Aleisha, could you push those 3 patches (the 19.11 ones) and see how behave
Jenkins?
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #67 from Jonathan Druart
---
Created attachment 105658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105658=edit
Bug 22522: [19.11.x] Fix route typo
Signed-off-by: Martin Renvoize
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #66 from Jonathan Druart
---
Created attachment 105657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105657=edit
Bug 22522: [19.11.x] Add support for current Mojolicious and related packages
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Jonathan Druart changed:
What|Removed |Added
Attachment #105639|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #65 from Martin Renvoize ---
https://gitlab.com/mrenvoize/Koha/-/commits/bug_22522 is my 19.11 branch with
backported patches applied if it helps.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #64 from Martin Renvoize ---
Nope..
`KOHA_IMAGE=19.11-bionic docker-compose -f docker-compose.yml -f
docker-compose.mariadb_d9.yml -p koha up --force-recreate`
Then `kshell`, `kshell`, `prove -v
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #63 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #62)
> I've been looking at this and in reality.. I think what we really need is to
> just backport the whole set correctly.. I'm not sure what
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #62 from Martin Renvoize ---
I've been looking at this and in reality.. I think what we really need is to
just backport the whole set correctly.. I'm not sure what stopped it from being
backported in the first place to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #61 from Jonathan Druart
---
still not working but it's better.
Only 3 are failing now:
t/db_dependent/api/v1/libraries.t
t/db_dependent/api/v1/patrons.t
t/db_dependent/api/v1/patrons_password.t
with things like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Jonathan Druart changed:
What|Removed |Added
Attachment #105591|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #60 from Martin Renvoize ---
I believe my alternative to Kyle's should do the trick.. it's literally the
REST/V1/Auth.pm changes from the first patch here, just without all the test
updates included.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #59 from Martin Renvoize ---
Created attachment 105639
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105639=edit
Bug 22522: Add support for current Mojolicious in 19.11
This patch allows tests to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #58 from Martin Renvoize ---
I think we need all the Auth.pm changes in the first patch on this series:
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #57 from Jonathan Druart
---
Kyle, using master-bionic and 19.11.x + your patch I get:
t/db_dependent/api/v1/acquisitions_funds.t . 1/13
# Failed test '401 Unauthorized'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #56 from Kyle M Hall ---
Created attachment 105591
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105591=edit
[19.11.x] Bug 22522: Fail back to ->openapi->spec
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #54 from Jonathan Druart
---
All the API related tests are failing for 18.11 and 19.05 (maybe 19.11 as well,
I have just requested a new run 19.11_D9 #156).
Could that be related to this change?
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Jonathan Druart changed:
What|Removed |Added
Keywords|RM_priority |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #51 from Martin Renvoize ---
Brill, me too.
For now I've added it to the cpan list in our koha-testing-docker Dockerfile
for Buster. We should look at packaging options now I think as it's not great
to require people
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #50 from Ere Maijala ---
Ues, directly with CPAN. I don't really have enough experience with packaging.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #49 from Martin Renvoize ---
(In reply to Mason James from comment #40)
> (In reply to Ere Maijala from comment #35)
> > All the mentioned tests should now pass. I'll run a full test suite with
> > Kohadevbox to verify.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Martin Renvoize changed:
What|Removed |Added
Group|Koha security |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #11 from Magnus Enger ---
*** Bug 23864 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Magnus Enger changed:
What|Removed |Added
Severity|normal |critical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #9 from Blou ---
I changed it to master.
We applied the patch to our own 19.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Blou changed:
What|Removed |Added
Version|18.05 |master
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Katrin Fischer changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Magnus Enger changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #7 from Magnus Enger ---
Created attachment 93592
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93592=edit
Bug 22522 - Update API specs' access in Auth.pm
With newer versions of Mojolicious and its
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Magnus Enger changed:
What|Removed |Added
CC||mag...@libriotech.no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #5 from José-Mario Monteiro-Santos
---
Slightly modifying Auth.pm restores the original functionnality. It may be
useful as a temporary fix for those who have this problem.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
José-Mario Monteiro-Santos changed:
What|Removed |Added
Attachment #86756|Bug 22522 - Update API |Fix for newer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #3 from José-Mario Monteiro-Santos
---
Created attachment 86756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86756=edit
Bug 22522 - Update API specs' access in Auth.pm
With newer versions of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #2 from José-Mario Monteiro-Santos
---
I've noticed today that with newer Mojolicious versions, the authentication is
basically skipped as x-koha-authorization is never defined. It seems that this
makes it so all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Andrew Isherwood changed:
What|Removed |Added
Summary|ILL API breaks with updated |API authentication
59 matches
Mail list logo
