[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #60 from Katrin Fischer --- (In reply to Mirjam Vantieghem from comment #59) > Thanks for your reply, Katrin. Someone has already done this: bug 30438. > I saw this only after I placed my comment ... Great :) -- You

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #59 from Mirjam Vantieghem --- Thanks for your reply, Katrin. Someone has already done this: bug 30438. I saw this only after I placed my comment ... -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #58 from Katrin Fischer --- (In reply to Mirjam Vantieghem from comment #57) > (In reply to Jonathan Druart from comment #44) > > We would have certainly saved time, lines of code, readability and > > maintainability

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Mirjam Vantieghem changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added Patch complexity|Small patch |Medium patch -- You are

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature Text to go

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #55 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #54 from Nick Clemens --- Created attachment 119290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119290=edit Bug 22773: (follow-up) Fix id clash and data element -- You are receiving this mail

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #116010|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115426|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115423|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115422|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115425|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115424|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115421|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115420|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #44 from Jonathan Druart --- We would have certainly saved time, lines of code, readability and maintainability with only one table and correct filters. [un]select all links are missing, not considering blocker

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #43 from Jonathan Druart --- Created attachment 116010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116010=edit Bug 22773: Assign different id to checkboxes Otherwise clicking the label does not

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #41 from Nick Clemens --- Created attachment 115426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115426=edit Bug 22773: (follow-up) Ensure buttons only affect their related table Also cleans up a

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #40 from Nick Clemens --- Created attachment 115425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115425=edit Bug 22773: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer -- You are

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #39 from Nick Clemens --- Created attachment 115424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115424=edit Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label Fixes the

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #38 from Nick Clemens --- Created attachment 115423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115423=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #37 from Nick Clemens --- Created attachment 115422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115422=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #36 from Nick Clemens --- Created attachment 115421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115421=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #106538|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98733|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #32 from Katrin Fischer --- Created attachment 106543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106543=edit Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label Fixes

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98731|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #33 from Katrin Fischer --- Created attachment 106544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106544=edit Bug 22773: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer -- You

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98732|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98730|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98729|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #26 from Katrin Fischer --- I've tested merging invoices from 2 different tabs and it worked nicely. I did 2 follow-ups for some cosmetics (the label on the subscription limit and the buttons). Ready to PQA. -- You are

[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Summary|Bulk Close invoices and |Bulk close invoices and

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #25 from Jonathan Druart --- (In reply to Kelly McElligott from comment #19) > I am signing off on this bug. To comment on Jonathan's comments. > > > > 2. Click "Show only subscriptions" label does not select the

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96910|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96908|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96909|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96907|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96906|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Kelly McElligott changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #95290|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93448|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93375|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #94411|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93660|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #13 from Jonathan Druart --- It's not clear with 2 tabs. Sorry to insist but: 1. Do not select anything, click "close selected invoices" => You get a warning "nothing selected" Now tick an open invoice, and click "open

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #12 from Devinim --- Created attachment 95290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95290=edit Bug 22773: The deprecated plugin is removed We used the deprecated plugin (fnFilterAll) to

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #11 from Martin Renvoize --- I don't mind whether we use tabs or a single table and filter.. there's precedence for both. I really don't like the idea of introducing a new dependency that is already officially

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #10 from Katrin Fischer --- Hi all, as there are some concerns about the datatables plugin used, could it be an option to see how it was solved for the subscription (separate tabs for active and closed subscriptions)

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > 1. Not sure the tabs are the best choice here. We could have had 2 links to > filter by open/close invoices. It would have made the code easier

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #7 from Devinim --- Created attachment 94411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94411=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons -- You are receiving

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #5 from Devinim --- Created attachment 93660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93660=edit Bug 22773: Message appearing if any invoice selected -- You are receiving this mail because: You

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #4 from Katrin Fischer --- Created attachment 93448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93448=edit Bug 22773: (follow-up) Fix capitalization -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Keywords||rel_19_11_candidate

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93357|0 |1 is obsolete|

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #1 from Devinim --- Created attachment 93357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93357=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Test plan: 1)Verify that

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What|Removed |Added Assignee|kyle.m.h...@gmail.com |kohadevi...@devinim.com.tr --

[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What|Removed |Added Summary|Bulk Close invoices |Bulk Close invoices and