[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Blocks||24244 Referenced Bugs:

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Attachment #90170|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Attachment #90169|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Attachment #90168|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Attachment #89872|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #12) > I am having trouble understanding what you do here and why you do it: [...] Oops, sorry for catching that. It was indeed related to another

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Attachment #89873|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #15 from Jonathan Druart --- Created attachment 90170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90170=edit Bug 22907: Add missing use statement Signed-off-by: Liz Rea -- You are receiving

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #14 from Jonathan Druart --- Created attachment 90169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90169=edit Bug 22907: Remove previous code handling the same thing See: commit

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #12

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #9 from Liz Rea --- Created attachment 89874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89874=edit Bug 22907: Remove previous code handling the same thing See: commit

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #8 from Liz Rea --- Created attachment 89873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89873=edit Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #10 from Liz Rea --- Created attachment 89875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89875=edit Bug 22907: Add missing use statement Signed-off-by: Liz Rea -- You are receiving this mail

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Liz Rea changed: What|Removed |Added Attachment #89763|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #6 from Jonathan Druart --- Created attachment 89865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89865=edit Bug 22907: Add missing use statement -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff ---

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #4 from Jonathan Druart --- Created attachment 89768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89768=edit Bug 22907: Remove previous code handling the same thing See: commit

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Attachment #89764|0 |1 is obsolete|

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Depends on||12627 Referenced Bugs:

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Depends on||22908 Referenced Bugs:

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs:

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #2 from Jonathan Druart --- Created attachment 89764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89764=edit Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #1 from Jonathan Druart --- Created attachment 89763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89763=edit Bug 22907: Add tests Do not use copyrightdate as it is weird to have it int -- You are