[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.05
released in||

--- Comment #19 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #18 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #17 from Martin Renvoize  ---
Thanks Nick, 

All looks good here (and it looks like I would have got the rebase right..
woopie)

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93917|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 93919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93919=edit
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
"query" : {
"bool" : {
   "must" : [
  {
 "query_string" : {
  "query" : "Casaubon*",
  "default_field" : "heading-main",
   }
  },
  {
 "query_string" : {
  "query" : "(Isaac*) AND (1559-1614*)",
  "default_field" : "heading"
   }
  }
]
 }
  },
"sort" : [
   {
  "heading__sort.phrase" : "asc"
   }
 ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

Signed-off-by: Kyle M Hall 
Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93918|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 93920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93920=edit
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Nick Clemens  changed:

   What|Removed |Added

  Attachment #93378|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 93918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93918=edit
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Nick Clemens  changed:

   What|Removed |Added

  Attachment #93377|0   |1
is obsolete||

--- Comment #13 from Nick Clemens  ---
Created attachment 93917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93917=edit
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
"query" : {
"bool" : {
   "must" : [
  {
 "query_string" : {
  "query" : "Casaubon*",
  "default_field" : "heading-main",
   }
  },
  {
 "query_string" : {
  "query" : "(Isaac*) AND (1559-1614*)",
  "default_field" : "heading"
   }
  }
]
 }
  },
"sort" : [
   {
  "heading__sort.phrase" : "asc"
   }
 ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

Signed-off-by: Kyle M Hall 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #12 from Martin Renvoize  ---
Sorry Nick, this no longer applies.. I think the fix looks simple but I'm not
expert enough in the area to be confident I'll have got it right.. could you
rebase it please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #11 from Nick Clemens  ---
The issue is searches with a '-' in the middle, like a date range
1906-1995

Square brackets '[]' actually break searching for biblios and authorities in
general in ES and must be escaped, that hould be outside the scope here for the
moment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #10 from Nick Clemens  ---
Created attachment 93378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93378=edit
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Nick Clemens  changed:

   What|Removed |Added

  Attachment #91095|0   |1
is obsolete||
  Attachment #92119|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 93377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93377=edit
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
"query" : {
"bool" : {
   "must" : [
  {
 "query_string" : {
  "query" : "Casaubon*",
  "default_field" : "heading-main",
   }
  },
  {
 "query_string" : {
  "query" : "(Isaac*) AND (1559-1614*)",
  "default_field" : "heading"
   }
  }
]
 }
  },
"sort" : [
   {
  "heading__sort.phrase" : "asc"
   }
 ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

Signed-off-by: Kyle M Hall 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer  ---
I am seeing some issues here - when I used the linking on an existing sample
record I got:

Search main heading ($a only), contains: Waeschke, Hermannus,
search main headin, contains: 1850- [from old catalog]


Resulting in:

[Request] ** [http://localhost:9200]-[400] [query_shard_exception] Failed to
parse query [(1850-) AND ([from*) AND (old*) AND (catalog])], with:
{"index":"koha_kohadev_authorities","index_uuid":"S12XDtQeTMWLoBsmUsRlnw"},
called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/Search.pm line 100.
With vars: {'body' => {'status' => 400,'error' => {'phase' => 'query','grouped'
=> bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ),'root_cause' => [{'type' =>
'query_shard_exception','reason' => 'Failed to parse query [(1850-) AND
([from*) AND (old*) AND (catalog])]','index_uuid' =>
'S12XDtQeTMWLoBsmUsRlnw','index' => 'koha_kohadev_authorities'}],'type' =>
'search_phase_execution_exception','reason' => 'all shards
failed','failed_shards' => [{'index' => 'koha_kohadev_authorities','shard' =>
0,'node' => 'Secs-Ua8SyyeB_6hIXEnSA','reason' => {'type' =>
'query_shard_exception','reason' => 'Failed to parse query [(1850-) AND
([from*) AND (old*) AND (catalog])]','index' =>
'koha_kohadev_authorities','index_uuid' => 'S12XDtQeTMWLoBsmUsRlnw','caused_by'
=> {'caused_by' => {'type' => 'parse_exception','reason' => 'Encountered "
 "AND "" at line 1, column 21.
Was expecting:
"TO" ...
'},'reason' => 'Cannot parse \'(1850-) AND ([from*) AND (old*) AND
(catalog])\': Encountered "  "AND "" at line 1, column 21.
Was expecting:
"TO" ...
','type' => 'parse_exception'}}}]}},'request' => {'serialize' => 'std','qs'
=> {},'path' => '/koha_kohadev_authorities/_search','method' => 'GET','ignore'
=> [],'mime_type' => 'application/json','body' => {'query' => {'bool' =>
{'must' => [{'query_string' => {'query' => '(Waeschke,) AND
(Hermannus,)','default_field' => 'heading-main','analyze_wildcard' => bless(
do{\(my $o = 1)}, 'JSON::PP::Boolean' )}},{'query_string' => {'query' =>
'(1850-) AND ([from*) AND (old*) AND (catalog])','default_field' =>
'heading','analyze_wildcard' =>
$VAR1->{'request'}{'body'}{'query'}{'bool'}{'must'}[0]{'query_string'}{'analyze_wildcard'}}}]}},'from'
=> 0,'size' => 20,'sort' => [{'heading__sort.phrase' => 'asc'}]}},'status_code'
=> 400}
Unable to perform your search. Please try again.

When I remove the second input, it works with and without the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Signed Off

--- Comment #7 from Katrin Fischer  ---
Counting Kyle's sign-off here, switching to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #92118|0   |1
is obsolete||

--- Comment #6 from Fridolin SOMERS  ---
Created attachment 92119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92119=edit
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #5 from Fridolin SOMERS  ---
Created attachment 92118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92118=edit
Bug 22997: Unit text

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Failed QA

--- Comment #4 from Martin Renvoize  ---
Failing QA.. we need tests adding to
Koha/SearchEngine/Elasticsearch/QueryBuilder.t for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #90154|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 91095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91095=edit
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
"query" : {
"bool" : {
   "must" : [
  {
 "query_string" : {
  "query" : "Casaubon*",
  "default_field" : "heading-main",
   }
  },
  {
 "query_string" : {
  "query" : "(Isaac*) AND (1559-1614*)",
  "default_field" : "heading"
   }
  }
]
 }
  },
"sort" : [
   {
  "heading__sort.phrase" : "asc"
   }
 ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Bouzid Fergani  changed:

   What|Removed |Added

 CC||bouzid.ferg...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21534

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23004

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #2 from Fridolin SOMERS  ---
Created attachment 90154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90154=edit
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
"query" : {
"bool" : {
   "must" : [
  {
 "query_string" : {
  "query" : "Casaubon*",
  "default_field" : "heading-main",
   }
  },
  {
 "query_string" : {
  "query" : "(Isaac*) AND (1559-1614*)",
  "default_field" : "heading"
   }
  }
]
 }
  },
"sort" : [
   {
  "heading__sort.phrase" : "asc"
   }
 ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

--- Comment #1 from Fridolin SOMERS  ---
Looks like with a 'query_string' the wildcards are by default not detected.

See
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html

analyze_wildcard

By default, wildcards terms in a query string are not analyzed. By setting this
value to true, a best effort will be made to analyze those as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||21084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084
[Bug 21084] Searching for authorities with 'contains' gives no results if
search terms include punctuation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/