https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Martin Renvoize changed:
What|Removed |Added
Keywords|RM_priority |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Fridolin SOMERS changed:
What|Removed |Added
Version(s)|19.11.00|19.11.00,19.05.02
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #37 from Kyle M Hall ---
(In reply to David Cook from comment #36)
> (In reply to Kyle M Hall from comment #34)
> > (In reply to David Cook from comment #33)
> > > Kyle, how are folks managing the terrors I caused with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #36 from David Cook ---
(In reply to Kyle M Hall from comment #34)
> (In reply to David Cook from comment #33)
> > Kyle, how are folks managing the terrors I caused with 15221?
>
> lol, at ByWater we backported this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #35 from Kyle M Hall ---
Created attachment 91644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91644=edit
[Koha v18.11.x] Bug 23057: If checked_in_ok is set and item is not checked out,
alert flag is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #34 from Kyle M Hall ---
(In reply to David Cook from comment #33)
> Kyle, how are folks managing the terrors I caused with 15221?
lol, at ByWater we backported this patch to out build of Koha 18.11. I'd be
happy to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #33 from David Cook ---
Kyle, how are folks managing the terrors I caused with 15221?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #32 from David Cook ---
Hoping folks managing 19.05.x and 18.11.x see this one, as they must be bitten
by https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #31 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #29 from Kyle M Hall ---
No problem! A second pair of eyes never hurts :)
(In reply to Marcel de Rooy from comment #28)
> (In reply to Kyle M Hall from comment #26)
> > Comment on attachment 91326 [details] [review]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #28 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #26)
> Comment on attachment 91326 [details] [review]
> Bug 23057: (QA follow-up) Stay closer to old code
>
> I agree with Liz of course ;)
>
> The old
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #27 from Marcel de Rooy ---
(In reply to Liz Rea from comment #25)
> I don't understand why the last patch is necessary?
Explained in the commit message. Not much more to say
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Attachment #91326|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Liz Rea changed:
What|Removed |Added
CC||wizzy...@gmail.com
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #24 from Marcel de Rooy ---
Kyle,
Please have a look at the last follow-up. And let me know if you are
comfortable with it. I am at least, since we stay closer to the old code while
resolving the bug. If you are too, I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
Version|unspecified |master
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #21 from Marcel de Rooy ---
Created attachment 91324
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91324=edit
Bug 23057: Update do_checkin
Signed-off-by: Kyle M Hall
Signed-off-by: Matha Fuerst
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #20 from Marcel de Rooy ---
Created attachment 91323
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91323=edit
Bug 23057: Unit tests
Signed-off-by: Kyle M Hall
Signed-off-by: Matha Fuerst
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #23 from Marcel de Rooy ---
Created attachment 91326
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91326=edit
Bug 23057: (QA follow-up) Stay closer to old code
Somehow it feels safer to me to alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #22 from Marcel de Rooy ---
Created attachment 91325
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91325=edit
Bug 23057: (QA follow-up) Remove new AddReturn message ReturnOfLostItemBlocked,
use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
Attachment #90505|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Sally Healey changed:
What|Removed |Added
CC||sally.healey@cheshireshared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Bug 23057 depends on bug 15221, which changed state.
Bug 15221 Summary: SIP server always sets the alert flag when item not returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Martin Renvoize changed:
What|Removed |Added
Keywords||RM_priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #16 from Kyle M Hall ---
Created attachment 90507
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90507=edit
Bug 23057: Update do_checkin
Signed-off-by: Kyle M Hall
Signed-off-by: Matha Fuerst
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #17 from Kyle M Hall ---
Created attachment 90508
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90508=edit
Bug 23057: (QA Follow-up) Remove new AddReturn message ReturnOfLostItemBlocked,
use existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #15 from Kyle M Hall ---
Created attachment 90506
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90506=edit
Bug 23057: Unit tests
Signed-off-by: Kyle M Hall
Signed-off-by: Matha Fuerst
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Attachment #90344|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #13 from Kyle M Hall ---
To follow up on my last comment, I did want to say that if QA feels that my ALT
patch is ok as part of this bug, please by all means use it instead of my more
terse followup!
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #12 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #8)
> Comment on attachment 90388 [details] [review]
> Bug 23057: Update do_checkin
>
> Review of attachment 90388 [details] [review]:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Attachment #90479|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #10 from Kyle M Hall ---
Created attachment 90479
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90479=edit
Bug 23057: (QA Follow-up) [ALT PATCH] Handle new ReturnOfLostItemBlocked
message in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #9 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #8)
> Comment on attachment 90388 [details] [review]
> Bug 23057: Update do_checkin
>
> Review of attachment 90388 [details] [review]:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #8 from Jonathan Druart
---
Comment on attachment 90388
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90388
Bug 23057: Update do_checkin
Review of attachment 90388:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Attachment #90385|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #6 from Kyle M Hall ---
Created attachment 90385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90385=edit
Bug 23057: Update subroutine so tests pass
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Attachment #90377|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #4 from Kyle M Hall ---
Created attachment 90377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90377=edit
Bug 23057: Unit tests
--
You are receiving this mail because:
You are the assignee for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #3 from David Cook ---
I haven't actually tested my patch or run the unit tests, but hopefully this is
the solution.
I have more urgent matters to attend to but I'll look back on this one as soon
as I can.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #2 from David Cook ---
Created attachment 90344
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90344=edit
Bug 23057: If checked_in_ok is set and item is not checked out, alert flag is
supressed for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Martha Fuerst changed:
What|Removed |Added
CC||mfue...@hmcpl.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall changed:
What|Removed |Added
Depends on||15221
Referenced Bugs:
54 matches
Mail list logo