https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #57 from David Cook ---
(In reply to Kyle M Hall from comment #56)
> Thanks not only for figuring this out, but writing it up for the rest of us!
Thanks, Kyle! That really means a lot to me :)
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #56 from Kyle M Hall ---
(In reply to David Cook from comment #55)
> Boy that was crazy-making but feels good to figure out a tough problem
Thanks not only for figuring this out, but writing it up for the rest of us!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #55 from David Cook ---
Boy that was crazy-making but feels good to figure out a tough problem
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
Blocks||33967
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #54 from David Cook ---
The problem is Koha::Middleware::SetEnv. It's a fundamentally flawed
middleware.
The wrapping of middleware works by passing around a hash reference (ie $env),
and Koha::Middleware::SetEnv breaks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #53 from David Cook ---
(In reply to David Cook from comment #52)
> I can get the client IP via $ENV{REMOTE_ADDR} in Koha as set by
> Koha::Middleware::RealIP, but plack.log is still using the proxy address as
> set by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #52 from David Cook ---
(In reply to David Cook from comment #50)
> Trying to remember why we needed this since in theory
> Plack::Middleware::ReverseProxy should've handled this...
Ahh I see now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #51 from David Cook ---
Also wondering how we could update REMOTE_USER so that it appears in
plack.log...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #50 from David Cook ---
Trying to remember why we needed this since in theory
Plack::Middleware::ReverseProxy should've handled this...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
Blocks||25950
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #49 from David Cook ---
Unfortunately, it looks like this feature breaks file upload for CGI Koha. I
haven't checked Plack Koha yet but might still be relevant.
Please see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #48 from David Cook ---
(In reply to Martin Renvoize from comment #44)
> Thanks David, that's great news.
It only took me nearly 3 weeks but I finally got there heh.
Unit test and bug fix available at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #47 from David Cook ---
(In reply to Kyle M Hall from comment #46)
> koha_trusted_proxies is a config setting from the Koha conf xml file, so
> mock_preference won't work on that. You'll want to use mock_config instead.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #46 from Kyle M Hall ---
koha_trusted_proxies is a config setting from the Koha conf xml file, so
mock_preference won't work on that. You'll want to use mock_config instead.
(In reply to David Cook from comment #45)
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #45 from David Cook ---
(In reply to Martin Renvoize from comment #44)
> Thanks David, that's great news.
Finally getting around to this...
Have to leave for the night but the following isn't working for some reason:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #44 from Martin Renvoize ---
Thanks David, that's great news.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #43 from David Cook ---
(In reply to Martin Renvoize from comment #42)
> (In reply to David Cook from comment #39)
> > It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended
> > up writing a very
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #42 from Martin Renvoize ---
(In reply to David Cook from comment #39)
> It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended
> up writing a very basic one here just to test that it worked for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
Blocks||24538
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #41 from David Cook ---
Ok found a little problem and I'll open up a separate bug report for it.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #40 from David Cook ---
One last note for people interested in this feature, Net::Netmask lets you
define IP addresses in a number of ways. If you wanted to trust a whole local
subnet, you could do 192.168.0.0/16, or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #39 from David Cook ---
I've been thinking about this one more, and I just want to say again well done,
Kyle!
I like how it can handle multiple proxies, and the trust model so that end
users can't hack REMOTE_USER
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #38 from David Cook ---
I just want to say that this is working beautifully in 19.11. Thanks a lot,
Kyle!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #37 from Victor Grousset/tuxayo ---
> Do you now re-run apt install koha-perldeps or anything regularly? That
> should have caught the debian control change.. also, I presume if you are
> running such a command then
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #36 from David Cook ---
(In reply to Martin Renvoize from comment #34)
> Correct, it has been escalated to a 'required' dependancy. This is because
> for plack we need to load it before we load C4::Context and as such we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #35 from Martin Renvoize ---
(In reply to David Cook from comment #33)
> (In reply to Victor Grousset/tuxayo from comment #32)
> > KohaDevBoxes (even new ones) and other development environments based on
> > Debian or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #34 from Martin Renvoize ---
(In reply to Victor Grousset/tuxayo from comment #32)
> KohaDevBoxes (even new ones) and other development environments based on
> Debian or Ubuntu need to install the package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #33 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #32)
> KohaDevBoxes (even new ones) and other development environments based on
> Debian or Ubuntu need to install the package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Victor Grousset/tuxayo changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Ed Veal changed:
What|Removed |Added
CC||ev...@mckinneytexas.org
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #30 from David Cook ---
Yay! Nice one, Kyle!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_19_11_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #29 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
CC||mi...@abunchofthings.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Attachment #94839|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #26 from David Cook ---
(In reply to Kyle M Hall from comment #21)
> Actually, it only gets called under plack at startup, since C4::Auth is
> loaded at that time. So, yes, we could do that, but it doesn't actually hurt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #94838|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_19_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #24 from Martin Renvoize ---
Sorry dude.. lots of QA script failures.. and I think this also introduces a
new dependancy that will need to be listed:
FAIL C4/Auth.pm
FAIL valid
Can't locate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Attachment #94807|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #22 from Kyle M Hall ---
(In reply to Martin Renvoize from comment #6)
> QA Questions
> 1) Does this work with the Mojo derived API's too?
Yes it does!
> 2) What if Koha is running under CGI and not plack - yes.. there
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #21 from Kyle M Hall ---
(In reply to David Cook from comment #19)
> Comment on attachment 94807 [details] [review]
> Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
> REMOTE_ADDR features work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #20 from Kyle M Hall ---
(In reply to David Cook from comment #19)
> Comment on attachment 94807 [details] [review]
> Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
> REMOTE_ADDR features work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #19 from David Cook ---
Comment on attachment 94807
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94807
Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #17 from Kyle M Hall ---
Created attachment 94808
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94808=edit
Bug 23068: [DO NOT PUSH] Debugging code for test plan
Signed-off-by: Ed Veal
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #92463|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #15 from Kyle M Hall ---
Created attachment 92464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92464=edit
Bug 23068: [DO NOT PUSH] Debugging code for test plan
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #92461|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #13 from Kyle M Hall ---
Created attachment 92462
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92462=edit
Bug 23068: [DO NOT PUSH] Debugging code for test plan
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #90395|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #91174|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Attachment #90396|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
Attachment #90582|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #7 from Martin Renvoize ---
Created attachment 91173
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91173=edit
Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #5 from Kyle M Hall ---
Created attachment 90582
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90582=edit
Bug 23068: Allow the list of proxy IPs to be set in the koha-conf.xml file
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #3 from Kyle M Hall ---
Created attachment 90396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90396=edit
Bug 23068 - Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #2 from Kyle M Hall ---
Created attachment 90395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90395=edit
Bug 23068: [DO NOT PUSH] Add debugging to C4::Context
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #1 from Kyle M Hall ---
Actually, we can use an environment variable so I'm increasing the scope to
include setting the list of proxies!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
77 matches
Mail list logo