[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Nick Clemens changed: What|Removed |Added Blocks||30630 Referenced Bugs:

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Bug 23070 depends on bug 23185, which changed state. Bug 23185 Summary: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #37 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Katrin Fischer changed: What|Removed |Added Attachment #104264|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Katrin Fischer changed: What|Removed |Added Attachment #104261|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Katrin Fischer changed: What|Removed |Added Attachment #104262|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Katrin Fischer changed: What|Removed |Added Attachment #104263|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate,|rel_20_11_target

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off ---

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103908|0 |1 is

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103907|0 |1 is

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103909|0 |1 is

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #104253|0 |1 is

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Attachment #103910|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #25 from Victor Grousset/tuxayo --- Thanks Didier, I wasn't sure if I could set to "Failed QA" because my setup or way of testing could be wrong. However, you definitely found something fishy. -- You are receiving this

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 didier changed: What|Removed |Added CC||didier.gautheron@biblibre.c

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #22 from Victor Grousset/tuxayo --- I got an error on the tests, is there any thing else to do before running them? Error: kohadev-koha@661a25cf6198:/kohadevbox/koha$ time prove t/db_dependent/Reserves.t

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #21 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #20) > Test pass, is there anything else to test? Yes, place some holds on the same record, mark on as waiting then revert the waiting

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #18 from Jonathan Druart --- Created attachment 103909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103909=edit Bug 23070: Increment all priorities in 1 query -- You are receiving this mail

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #19 from Jonathan Druart --- Created attachment 103910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103910=edit Bug 23070: Pass no_triggers => 1 to Koha::Objects->update To make sure we will update

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #17 from Jonathan Druart --- Created attachment 103908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103908=edit Bug 23070: Add tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Attachment #99168|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #15 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #14) > status: ASSIGNED > > Should it be needs signoff? No, if it is ASSIGNED, it's not ready yet. -- You are receiving this mail

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate,

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Depends on||23185

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Depends on||21944 --- Comment #13

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Attachment #90400|0 |1 is obsolete|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #12 from Jonathan Druart --- Created attachment 99170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99170=edit Bug 23070: Increment all priorities in 1 query -- You are receiving this mail because:

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #11 from Jonathan Druart --- Created attachment 99169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99169=edit Bug 23070: Add tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #3) > (In reply to Jonathan Druart from comment #2) > > I am missing a DBIx::Class trick to make this better. > > If we were not getting rid of

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #8 from Jonathan Druart --- Created attachment 97977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97977=edit Bug 23070: Increment all priorities in 1 query -- You are receiving this mail because:

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #7 from Jonathan Druart --- Created attachment 97976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97976=edit Bug 23070: Add tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #6 from Jonathan Druart --- About 23070, not sure I will manage to rephrase it :) ->store will check the default values (triggering Koha::Object->store), and also do some stuffs (like logging, etc.)

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #5 from Martin Renvoize --- Catch me on IRC.. I'm not sure I understood your last comment.. might just be 'early morning brain' of course. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #4 from Jonathan Druart --- I do not think we should force developers to use store. For instance here it's not needed, we do not want to change the value for priority. The problem appears especially when we add or

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #3 from Martin Renvoize --- (In reply to Jonathan Druart from comment #2) > I am missing a DBIx::Class trick to make this better. If we were not getting rid of being able to call dbic's 'update' routine there might be..

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl,

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #1 from Jonathan Druart --- Created attachment 90400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90400=edit Bug 23070: Use Koha::Hold in C4::Reserves::RevertWaitingStatus We are using raw SQL