[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2024-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #19 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #6)
> I have no clue about it. The change is pretty trivial IMHO, just removing
> many things, and changing the use base line. I'd say this is a bug in the QA
> tools, that shouldn't prevent this patches from making into the QA process!

Thats too easy. This has nothing to do with QA tools. This is a regular perl
warning about a rattling? object hierarchy?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2024-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35959

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #18 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #16)
> Why do not we have Koha::Koha::AuthorisedValues inherit from
> Koha::Objects::Limit::Library (like Koha::ItemTypes and
> Koha::Patron::Attribute::Types?
> 
> % git grep "use.*Koha::Objects::Limit::Library"
> Koha/ItemTypes.pm:use base qw(Koha::Objects Koha::Objects::Limit::Library);
> Koha/Patron/Attribute/Types.pm:use base qw(Koha::Objects
> Koha::Objects::Limit::Library);

I've added a bug for this part, bug 23830. Agreed, it would be great to get
that case sorted aswell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830
[Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #17 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #16)
> Why do not we have Koha::Koha::AuthorisedValues inherit from
> Koha::Objects::Limit::Library (like Koha::ItemTypes and
> Koha::Patron::Attribute::Types?
> 
> % git grep "use.*Koha::Objects::Limit::Library"
> Koha/ItemTypes.pm:use base qw(Koha::Objects Koha::Objects::Limit::Library);
> Koha/Patron/Attribute/Types.pm:use base qw(Koha::Objects
> Koha::Objects::Limit::Library);

That's because it was added later... And I couldn't spend the time on that
lately

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #16 from Jonathan Druart  
---
Why do not we have Koha::Koha::AuthorisedValues inherit from
Koha::Objects::Limit::Library (like Koha::ItemTypes and
Koha::Patron::Attribute::Types?

% git grep "use.*Koha::Objects::Limit::Library"
Koha/ItemTypes.pm:use base qw(Koha::Objects Koha::Objects::Limit::Library);
Koha/Patron/Attribute/Types.pm:use base qw(Koha::Objects
Koha::Objects::Limit::Library);

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #15 from Martin Renvoize  ---
Created attachment 93197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93197&action=edit
Bug 23272: (RM followup) Fix edit action

This bug introduced a regression whereby if an authorized value has no
branch limitations then the authorized value cannot be edited once it
has been created. The edit page would display an error and not load.

This is the second case of a simple ternary correcting the issue, but
the logic of returning 'undef' from 'get_branch_limits' being called
into question.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #14 from Fridolin SOMERS  ---
Depends on Bug 23281 not in 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #13 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #12)
> Just added a followup here to fix the failing tests.. as the commit says
> however I took the quick option of adding a ternary.. perhaps a longer
> discussion is in order to settle on a returns guideline for koha object
> methods.  To me, if an object is expected as the return we should always
> return an object (even if it's an empty/full object) rather than ever
> returning an implicit 'undef'. That would prevent the need for ternaries
> throughout the codebase checking the return value before chaining methods.
> 
> Thoughts.

Good catch. Changing the returns of Koha objects is a nice exercise now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #12 from Martin Renvoize  ---
Just added a followup here to fix the failing tests.. as the commit says
however I took the quick option of adding a ternary.. perhaps a longer
discussion is in order to settle on a returns guideline for koha object
methods.  To me, if an object is expected as the return we should always return
an object (even if it's an empty/full object) rather than ever returning an
implicit 'undef'. That would prevent the need for ternaries throughout the
codebase checking the return value before chaining methods.

Thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #11 from Martin Renvoize  ---
Created attachment 92775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92775&action=edit
Bug 23272: (RM followup) Fix failing tests

This bug introduced a regression whereby if any authorized value has no
branch limitations then the authorized value administration page would
fail to display at all.

A simple ternary corrects the issue, but I'm now wondering about the
logic of returning 'undef' from 'get_branch_limits'.. perhaps an empty
(or full) resultset might be a better option to prevent us from
requireing ternaries before calling chained methods on such objects.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #10 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #91463|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 92769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92769&action=edit
Bug 23272: Adapt controller and tests

This patch adapts the controller script for handling authorised values,
and the tests to reflect the method names changes.

To test:
- Verify you can add/delete/edit authorised values with/without branch
limitations, as usual
=> SUCCESS: All works as usual!
- Run:
  $ kshell
 k$ prove t/db_dependent/AuthorisedValues.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #91462|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 92768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92768&action=edit
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272
Bug 23272 depends on bug 23281, which changed state.

Bug 23281 Summary: Add Koha::Objects::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-08-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #5)
> Hi Tomas,
> 
> can you please check this one?
> 
>  FAIL Koha/AuthorisedValue.pm
>FAIL valid
>   Inconsistent hierarchy during C3 merge of class 
> 'Koha::AuthorisedValue':
>   current merge results [
>   Koha::AuthorisedValue,
>   ]
>   merging failed on 'Koha::Object'

It is a false positive, Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #5)
> Hi Tomas,
> 
> can you please check this one?
> 
>  FAIL Koha/AuthorisedValue.pm
>FAIL valid
>   Inconsistent hierarchy during C3 merge of class 
> 'Koha::AuthorisedValue':
>   current merge results [
>   Koha::AuthorisedValue,
>   ]
>   merging failed on 'Koha::Object'

I have no clue about it. The change is pretty trivial IMHO, just removing many
things, and changing the use base line. I'd say this is a bug in the QA tools,
that shouldn't prevent this patches from making into the QA process!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Hi Tomas,

can you please check this one?

 FAIL   Koha/AuthorisedValue.pm
   FAIL   valid
Inconsistent hierarchy during C3 merge of class
'Koha::AuthorisedValue':
current merge results [
Koha::AuthorisedValue,
]
merging failed on 'Koha::Object'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #91369|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 91463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91463&action=edit
Bug 23272: Adapt controller and tests

This patch adapts the controller script for handling authorised values,
and the tests to reflect the method names changes.

To test:
- Verify you can add/delete/edit authorised values with/without branch
limitations, as usual
=> SUCCESS: All works as usual!
- Run:
  $ kshell
 k$ prove t/db_dependent/AuthorisedValues.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #91368|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 91462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91462&action=edit
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||23281


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281
[Bug 23281] Add Koha::Objects::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io,
   ||k...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 91369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91369&action=edit
Bug 23272: Adapt controller and tests

This patch adapts the controller script for handling authorised values,
and the tests to reflect the method names changes.

To test:
- Verify you can add/delete/edit authorised values with/without branch
limitations, as usual
=> SUCCESS: All works as usual!
- Run:
  $ kshell
 k$ prove t/db_dependent/AuthorisedValues.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 91368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91368&action=edit
Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||17755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755
[Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/