[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Nick Clemens changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #19 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 23823 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #18 from Owen Leonard --- Does Bug 23823 make this a duplicate? I don't have a better patch forthcoming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #17 from Jonathan Druart --- What's next? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #16 from Ivan Masár --- Before I found this bug, I made a patch that solves the same problem (linking to sysprefs) in a different way - via search by syspref name rather than anchor links. As a result, my solution shows one syspref, this one scrolls down to the target syspref. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #15 from Owen Leonard --- (In reply to Katrin Fischer from comment #14) > Koha does rely on it in a lot of places to make things work smoothly. (which means we should probably add it to the installer onboarding?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #14 from Katrin Fischer --- (In reply to Ivan Masár from comment #13) > > Is your staffClientBaseURL system preference set? > > It's not set. This seems to be the default, both in my installed instance > and in kohadevbox, so I think we should not rely on it. Koha does rely on it in a lot of places to make things work smoothly. Generally much recommended. For links in staff relativ links might work - but in other places where we link from OPAC to staff and staff to OPAC it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #13 from Ivan Masár --- > Is your staffClientBaseURL system preference set? It's not set. This seems to be the default, both in my installed instance and in kohadevbox, so I think we should not rely on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #12 from Owen Leonard --- (In reply to Ivan Masár from comment #11) > Thanks, that was it. I only noticed one flaw - the URL copied to clipboard > is relative to the site root Is your staffClientBaseURL system preference set? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #11 from Ivan Masár --- Thanks, that was it. I only noticed one flaw - the URL copied to clipboard is relative to the site root, not including scheme, host port. That and after accessing the syspref it is overlaid by the floating toolbar, but there is a fix to that in the previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #10 from Owen Leonard --- The link should appear all the way at the end of the row, not in the first cell in the row (which, now that I think about it and having seen your patch, is probably the correct place for it). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Ivan Masár changed: What|Removed |Added CC||heli...@centrum.sk --- Comment #9 from Ivan Masár --- Testing the WIP patch in Chrome 77 but I don't see any change. Maybe I'm just holding it wrong... I see changes in the page source (e.g. https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #8 from Owen Leonard --- Created attachment 94368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94368&action=edit Bug 23388: [WIP] Make system preferences links This alternate solution adds a link which when clicked will copy a URL linking directly to the corresponding system preference. To test, apply the patch and view system preferences. Hovering the mouse over any row in the system preferences table should trigger the display of an anchor link at the end of the row. Hovering over the link should display a tooltip, "Copy link to this preference." Clicking the link should copy it to your clipboard. Test that the link is copied correctly and that it works to link you to the preference in question. Known issues: Because of the way the page is drawn, the browser's calculation of where to scroll isn't accurate, meaning the target preference will sometimes be hidden by the floating toolbar. Question: "Hover" isn't a mobile/touch-friendly interaction. Show the link all the time? Show it at narrower browser widths? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23823 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #7 from Katrin Fischer --- How should we continue here? Nick, could you help Owen with his patch or vice versa? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #6 from Owen Leonard --- I've been working on an alternate patch which addresses one aspect of this bug: Linking easily to specific preferences. The proposed patch does two things I don't like: It breaks the previous behavior of the system preference names as . And the links don't make much sense unless you're looking at search results. In other circumstances clicking the link doesn't do anything. My proposal would be to show a link on hover: https://zivotdesign.com/p/view.php?p=15646746956636 Unfortunately my solution suffers from the same problem described by Nick: When the page jumps to the anchored link the pref is right at the top of the browser window, thus it's hidden by the floating toolbar. I worked to come up with a JavaScript solution but failed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Nick, can you explain this bit please? FIXME: Note the floating toolbar actually breaks this because it hides the anchored pref. Add this CSS to IntrnateUSerCSS to fix it padding-top: 50px; margin-top: -50px; } Also: FAILkoha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt FAIL filters missing_filter at line 55 () wrong_html_filter at line 60 ([% NAME.name | html %]) wrong_html_filter at line 60 ([% NAME.name | html %]) missing_filter at line 60 ([% NAME.name | html %]) missing_filter at line 60 ([% NAME.name | html %]) wrong_html_filter at line 62 ([% NAME.name | html %]) wrong_html_filter at line 62 ([% NAME.name | html %]) missing_filter at line 62 ([% NAME.name | html %]) missing_filter at line 62 ([% NAME.name | html %]) wrong_html_filter at line 64 ([% NAME.name | html %]) wrong_html_filter at line 64 ([% NAME.name | html %]) missing_filter at line 64 ([% NAME.name | html %]) missing_filter at line 64 ([% NAME.name | html %]) FAIL forbidden patterns forbidden pattern: tab char (line 58) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Maryse Simard changed: What|Removed |Added Attachment #91841|0 |1 is obsolete|| --- Comment #4 from Maryse Simard --- Created attachment 91847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91847&action=edit Bug 23388: Sort the tab results when searching Before this patch we can get the matching tabs back in any order To test: 1 - Search system preferences for 'field' 2 - Refresh the page a few times 3 - Note results are reordered 4 - Apply patch 5 - Refresh the page several times again 6 - Results are consistent Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Maryse Simard changed: What|Removed |Added Attachment #91840|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 91846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91846&action=edit Bug 23388: Make system preferences links and give them anchors FIXME: Note the floating toolbar actually breaks this because it hides the anchored pref. Add this CSS to IntrnateUSerCSS to fix it padding-top: 50px; margin-top: -50px; } To test: 1 - Search for 'fields' 2 - Scroll to 'PatronQuickAddFields' 3 - You don't have a way to share a link to this pref 4 - You can't view th other patron prefs without scrolling back to tabs 5 - Apply patch 6 - Repeat 7 - Note the pref is a link you can copy 8 - Click it 9 - You are now on the tab for the pref 10 - Click on other prefs and you focus on them Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #2 from Nick Clemens --- Created attachment 91841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91841&action=edit Bug 23388: Sort the tab results when searching Before this patch we can get the matching tabs back in any order To test: 1 - Search system preferences for 'field' 2 - Refresh the page a few times 3 - Note results are reordered 4 - Apply patch 5 - Refresh the page several times again 6 - Results are consistent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #1 from Nick Clemens --- Created attachment 91840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91840&action=edit Bug 23388: Make system preferences links and give them anchors FIXME: Note the floating toolbar actually breaks this because it hides the anchored pref. Add this CSS to IntrnateUSerCSS to fix it padding-top: 50px; margin-top: -50px; } To test: 1 - Search for 'fields' 2 - Scroll to 'PatronQuickAddFields' 3 - You don't have a way to share a link to this pref 4 - You can't view th other patron prefs without scrolling back to tabs 5 - Apply patch 6 - Repeat 7 - Note the pref is a link you can copy 8 - Click it 9 - You are now on the tab for the pref 10 - Click on other prefs and you focus on them -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
