[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11213 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #33 from Lucas Gass --- enhancement won't be backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added Blocks||15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #32 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #31 from Martin Renvoize --- Well done getting this one over the finish line just in time for the freeze guys. I was about to update it to rel_20_05_target when I spotted the diligent final QAing.. Thanks! Looks good, clarifies things and improves performance, Pushing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #30 from Jonathan Druart --- Sorry, scope creep... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #29 from Jonathan Druart --- Created attachment 95089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95089=edit Bug 23414: Replace delimiter of regexs to ease readability Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #27 from Jonathan Druart --- Created attachment 95087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95087=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #26 from Jonathan Druart --- Created attachment 95086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95086=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #28 from Jonathan Druart --- Created attachment 95088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95088=edit Bug 23414: Add tests for previous effective_itemtype change Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #25 from Jonathan Druart --- Created attachment 95085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95085=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #24 from Jonathan Druart --- Created attachment 95084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95084=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added Attachment #95069|0 |1 is obsolete|| Attachment #95070|0 |1 is obsolete|| Attachment #95071|0 |1 is obsolete|| Attachment #95072|0 |1 is obsolete|| Attachment #95073|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 95083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95083=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea changed: What|Removed |Added Attachment #95010|0 |1 is obsolete|| --- Comment #22 from Liz Rea --- Created attachment 95073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95073=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea changed: What|Removed |Added Attachment #95014|0 |1 is obsolete|| --- Comment #20 from Liz Rea --- Created attachment 95071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95071=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea changed: What|Removed |Added Attachment #95015|0 |1 is obsolete|| --- Comment #21 from Liz Rea --- Created attachment 95072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95072=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea changed: What|Removed |Added Attachment #95011|0 |1 is obsolete|| --- Comment #18 from Liz Rea --- Created attachment 95069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95069=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea changed: What|Removed |Added Attachment #95012|0 |1 is obsolete|| --- Comment #19 from Liz Rea --- Created attachment 95070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95070=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #16 from Jonathan Druart --- Created attachment 95014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95014=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #17 from Jonathan Druart --- Created attachment 95015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95015=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #15 from Jonathan Druart --- Not sure about $item->itype, it seems that it should be $item->effective_itemtype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #14 from Nick Clemens --- Created attachment 95012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95012=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #13 from Nick Clemens --- Created attachment 95011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95011=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Attachment #94580|0 |1 is obsolete|| Attachment #94581|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 95010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95010=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > Nick, it was either you restored the elsif's, or you changed the order, not > both :) Forget that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Jonathan Druart --- And so we need a test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #9 from Jonathan Druart --- Nick, it was either you restored the elsif's, or you changed the order, not both :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #8 from Nick Clemens --- Created attachment 94581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94581=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Attachment #91913|0 |1 is obsolete|| Attachment #91914|0 |1 is obsolete|| Attachment #91915|0 |1 is obsolete|| Attachment #94537|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 94580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94580=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- The if...if sequence vs elsif will introduce a behavior's change. For instance an item that is lost and damaged will now be marked as lost whereas it was damaged before this patch. Is it expected? If not, you should reverse the order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #5 from Jonathan Druart --- Created attachment 94537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94537=edit Bug 23414: Use Koha::Holds->waiting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #4 from Tomás Cohen Arazi --- I like this enhancement. But would like to mention that it looks like there's an unnecessary processing of items from the MARC results, in the caller (searchResults) that is also making several DB calls. So it seems we need to make a decision, whether to use the data from Zebra, or use the one on the DB, and reuse the retrieved objects as much as we can (so maybe doing the search at a higher level, searchResults). Just a thought, and can be done later of course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19884 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23407 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #3 from Nick Clemens --- Created attachment 91915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91915=edit Bug 23414: Prefetch reserves and use them for determining waiting This dependss on bug 23413 Same tests as before, you shouldn't see a hit with this change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #2 from Nick Clemens --- Created attachment 91914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91914=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #1 from Nick Clemens --- Created attachment 91913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91913=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
