[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What|Removed |Added Blocks||29321 Referenced Bugs:

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows a |This enhancement allows a

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows a |This enhancement allows a

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows the |This enhancement allows a

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #30 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added Text to go in the|The new system preference |The new system preference

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #29 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #28 from Lucas Gass --- Created attachment 111254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111254=edit Bug 23420: (QA follow-up) Remove more AllowPurchaseSuggestionBranchChoice code Test plan:

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Text to go in the||The new system preference

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Attachment #110671|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Attachment #110419|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #23 from Lucas Gass --- Created attachment 110671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110671=edit Bug 23420: (QA follow-up) Remove AllowPurchaseSuggestionBranchChoice syspref -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #21 from David Nind --- Thanks Lucas! I have retested and signed off. Everything works as expected now with AllowPurchaseSuggestionBranchChoice enabled. David -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added Attachment #110418|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #19 from Lucas Gass --- I submitted a new patch with an updated test plan so I am switching this back to Needs Sign-off -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #110414|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #17 from Lucas Gass --- (In reply to David Nind from comment #16) > The 'Library or branch' field doesn't seem to display at all. > > If no unwanted fields are selected, it doesn't display. > > When just it is

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #108429|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #13 from Lucas Gass --- Created attachment 109299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109299=edit Bug 23420: (follow-up) remove title -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Owen Leonard changed: What|Removed |Added Blocks||26296 Referenced Bugs:

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #11 from Lucas Gass --- Probably this is a separate bug but OPACSuggestionMandatoryFields doesn't seem to have a spot in syspref.sql -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #10 from Lucas Gass --- Also added a note with the sys pref to remind not to makeOPACSuggestionMandatoryFields unwanted -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #9 from Lucas Gass --- Created attachment 108430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108430=edit Bug 23420: (QA follow-up) fix DB update and add syspref.sql -- You are receiving this mail

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #107662|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #108426|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #107662|1 |0 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #7 from Katrin Fischer --- Usually the best way is adding a second patch was (QA follow-up) - then you can also switch back to signed off, because it makes it easy to see the additional changes. If there are too many, QA

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #6 from Lucas Gass --- Thanks Cait, I added a new patch, kept Lisette's sign-off, but reset the status to 'Needs Signoff'. Not sure what's appropriate here. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #107787|0 |1 is obsolete|

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4

[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Summary|Add |Add