[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #43 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #42) > The schema hosting at swagger.io is back > https://github.com/swagger-api/swagger.io/issues/282 This is great! Although I hope this doesn't cause us to forget about the issue... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #42 from Victor Grousset/tuxayo --- The schema hosting at swagger.io is back https://github.com/swagger-api/swagger.io/issues/282 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #41 from Fridolin SOMERS --- For Ubuntu Debian, we at biblibre installed from CPAN JSON::Validator 4.01 and added the cache file. It works without patch on sources. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #40 from David Cook --- Here's a condensed version of the above: Good (don't worry): - Debian Jessie 8 - Debian Stretch 9 - Ubuntu Xenial 16.04 Bad (do worry): - Debian Buster 10 (and above) - Ubuntu Bionic 18.04 (and above) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #39 from David Cook --- Ok that 3.23 is still in the staging repo. If you're running a Debian/Ubuntu package, you'll be vulnerable, but not if you're running a Koha Community package. So you should be fine on Debian Jessie and Debian Stretch and Ubuntu Xenial. If you're on anything newer than those, you'll need to upgrade to the Koha Community 3.06 (or 3.23 when it is available) as per the table below: __Koha Community Apt Repo__ libjson-validator-perl_0.67+dfsg-1~koha1_all.deb libjson-validator-perl_0.97-1~kohadev1_all.deb libjson-validator-perl_3.06+dfsg-1+koha1_all.deb __Debian__ Stretch 9: libjson-validator-perl (0.92+dfsg-1) Buster 10: libjson-validator-perl (3.06+dfsg-1) Bullseye 11: libjson-validator-perl (3.25+dfsg-1) __Ubuntu__ Xenial 16.04: libjson-validator-perl (0.66+dfsg-1) Bionic 18.04: libjson-validator-perl (1.08+dfsg-1) Eoan 19.10: libjson-validator-perl (3.14+dfsg-1) Focal 20.04: libjson-validator-perl (3.23+dfsg-1) Groovy 20.10: libjson-validator-perl (3.25+dfsg-1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #38 from David Cook --- I think Mason found that newer versions of Ubuntu weren't installing 3.06 as they were using newer versions, but it looks like he's now released a 3.23+dfsg-1+koha1 version. I've installed that on Debian Jessie in koha-testing-docker, and it looks like it's working successfully. So folk using the Debian packages shoudl be able to just do the following: apt-get update apt-get install libjson-validator-perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 David Cook changed: What|Removed |Added Assignee|tomasco...@gmail.com|dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #37 from David Cook --- I'd recommend to people starting their day to look at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653#c11 for a quick fix to get through the worst of things right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #36 from David Cook --- I've tested the new package in koha-testing-docker and it looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #35 from David Cook --- Mason announced 30 minutes ago on koha-devel that he's updated the libjson-validator-perl package. As per his email: hi Folks i've updated the 'libjson-validator-perl' package to include the cache dir to update the package... $ sudo apt update $ sudo apt install libjson-validator-perl run the following command, and confirm the result... $ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 3.06+dfsg-1+koha1 Candidate: 3.06+dfsg-1+koha1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #34 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #33) > Should we actually expect a significant number of instances to have more > difficulty applying such a simple patch (just this patch, not updating Koha) > compared to updating the perl deps? > > The question is whether or not packaging libjson-validator-perl during some > time is worth it. Not sure now. > > Also, if http://swagger.io/v2/schema.json would work again tomorrow that > would help letting those instances count on that until their next Koha > update. I'm curious about this as well. While we felt this in production in Australia, I'm guessing the rest of the world might not feel it for another few hours. I don't know where Jonathan is physically located these days, but I'm guessing that we may have just missed him as well, so the Koha world is in for an interesting day... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #33 from Victor Grousset/tuxayo --- It works! :D (In reply to Victor Grousset/tuxayo from comment #30) > Indeed, that way, deployers only have to update the perl-deps, no patch to > apply. Should we actually expect a significant number of instances to have more difficulty applying such a simple patch (just this patch, not updating Koha) compared to updating the perl deps? The question is whether or not packaging libjson-validator-perl during some time is worth it. Not sure now. Also, if http://swagger.io/v2/schema.json would work again tomorrow that would help letting those instances count on that until their next Koha update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #106444|0 |1 is obsolete|| --- Comment #32 from Victor Grousset/tuxayo --- Created attachment 106445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106445=edit Bug 23653: use local copy of swagger v2 schema By default, JSON::Validator::OpenAPI tries to fetch the swagger v2 schema from http://swagger.io/v2/schema.json. If you've installed from CPAN, JSON::Validator::OpenAPI will come with a cached copy, so it won't try to fetch it over HTTP. However, if you've installed from libjson-validator-perl from Debian/Ubuntu, the Debian package excludes the cached copy, so JSON::Validator::OpenAPI tries to fetch it over HTTP. Unfortunately, today and other days in the past, the file at http://swagger.io/v2/schema.json has been unavailable, and this causes Koha to crash in a perpetual loop. This patch includes a copy of the swagger v2 schema, and it loads it locally rather than fetching over HTTP. The changes to Koha/REST/Plugin/PluginRoutes.pm are not required, since the validator isn't currently called there, but I've added a patch to future proof it. To Test: 0a) Remove /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df if it exists 0b) Block external access to http://swagger.io/v2/schema.json or test during an outage when it's unavailable 0c) Do not apply patch 1) koha-plack --restart kohadev 2) Note that it crashes in a loop and is unavailable in web browser 3) Apply patch 4) koha-plack --restart kohadev 5) Note that Koha comes up and there are no errors in the Plack logs Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #31 from David Cook --- Created attachment 106444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106444=edit Bug 23653: use local copy of swagger v2 schema By default, JSON::Validator::OpenAPI tries to fetch the swagger v2 schema from http://swagger.io/v2/schema.json. If you've installed from CPAN, JSON::Validator::OpenAPI will come with a cached copy, so it won't try to fetch it over HTTP. However, if you've installed from libjson-validator-perl from Debian/Ubuntu, the Debian package excludes the cached copy, so JSON::Validator::OpenAPI tries to fetch it over HTTP. Unfortunately, today and other days in the past, the file at http://swagger.io/v2/schema.json has been unavailable, and this causes Koha to crash in a perpetual loop. This patch includes a copy of the swagger v2 schema, and it loads it locally rather than fetching over HTTP. The changes to Koha/REST/Plugin/PluginRoutes.pm are not required, since the validator isn't currently called there, but I've added a patch to future proof it. To Test: 0a) Remove /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df if it exists 0b) Block external access to http://swagger.io/v2/schema.json or test during an outage when it's unavailable 0c) Do not apply patch 1) koha-plack --restart kohadev 2) Note that it crashes in a loop and is unavailable in web browser 3) Apply patch 4) koha-plack --restart kohadev 5) Note that Koha comes up and there are no errors in the Plack logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 David Cook changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #30 from Victor Grousset/tuxayo --- (In reply to Tomás Cohen Arazi from comment #23) > We should just package the library with the correct cache Indeed, that way, deployers only have to update the perl-deps, no patch to apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #29 from David Cook --- Actually, it looks like Koha::REST::Plugin::PluginRoutes doesn't receive the validator. It looks like the OpenAPI plugin must be calling a validator and that's where it's failing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #27 from David Cook ---
From what I can see, we're not actually validating the schema in
./Koha/REST/V1.pm when we use bundle().
We only validate it in ./Koha/REST/V1.pm when we do the catch{} block.
And we always validate ./Koha/REST/Plugin/PluginRoutes.pm.
Ok... yeah re-packaging libjson-validator-perl to include the "cache" probably
makes the most sense.
I'm going to post a code-level patch anyway (partially just because I'm already
this far anyway)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #28 from David Cook --- (In reply to David Cook from comment #27) > I'm going to post a code-level patch anyway (partially just because I'm > already this far anyway) Plus, if I do that, then we wouldn't have to maintain another custom package dependency... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #26 from David Cook --- Oh wait I'm misunderstanding... $validator->bundle is just loading the schema... and it doesn't validate it. Whereas $validator->load_and_validate_schema loads the schema, but then validates it against the Swagger 2.0 API schema. Wow, JSON::Validator really overloads the word "schema" in its code... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #25 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #23)
> (In reply to David Cook from comment #22)
> > I'm about to start on a patch for this. Hopefully will have something very
> > soon.
>
> We should just package the library with the correct cache
Maybe. I think there is more to this than we think.
Consider ./Koha/REST/V1.pm:
$validator->bundle uses a schema of
$self->home->rel_file("api/v1/swagger/swagger.json"), which is a drastically
reduced schema file.
Calls to $validator->load_and_validate_schema (in ./Koha/REST/V1.pm and
./Koha/REST/Plugin/PluginRoutes.pm) don't use that same schema. They try to
fetch http://swagger.io/v2/schema.json.
The question I have is whether they should all be using
$self->home->rel_file("api/v1/swagger/swagger.json"), or if *some* calls should
use our local swagger.json and others should use the full swagger 2.0 schema.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #24 from David Cook --- Note that this should only affect plugin-enabled instances -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #23 from Tomás Cohen Arazi --- (In reply to David Cook from comment #22) > I'm about to start on a patch for this. Hopefully will have something very > soon. We should just package the library with the correct cache -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #22 from David Cook --- I'm about to start on a patch for this. Hopefully will have something very soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #21 from David Cook --- (In reply to Federico Paiz from comment #20) > The same thing happened to me, I solved it by doing > > >cpan > > install Mojolicious::Plugin::OpenAPI Yeah, the CPAN version of that module comes with the "cache" which the Debian package excludes, so you'll be fine with that. But it's a short-term solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Federico Paiz changed: What|Removed |Added CC||federicoantoniopaiz@gmail.c ||om --- Comment #20 from Federico Paiz --- The same thing happened to me, I solved it by doing >cpan > install Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #19 from David Cook --- A solution to this problem is to provide our own argument "schema" argument to the load_and_validate_schema() method. https://metacpan.org/pod/JSON::Validator#load_and_validate_schema I've looked through the code and there's a variety of ways of providing the schema, which we can source from https://raw.githubusercontent.com/mojolicious/json-validator/3.06/lib/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df I'd say we should provide it as a local file, so that we're not relying on any web servers to provide this crucial file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Hayley Mapley changed: What|Removed |Added Severity|major |blocker CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #18 from Victor Grousset/tuxayo --- Issue reported to upstream's upstream: https://github.com/swagger-api/swagger.io/issues/281 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 ian.gor...@strath.ac.uk changed: What|Removed |Added CC||ian.gor...@strath.ac.uk --- Comment #17 from ian.gor...@strath.ac.uk --- Hi, At about 21:00UTC today we also started to have this problem. We're running 19.05.12 on Ubuntu 18.04. The solution in comment 11 seems to work for now. % pmvers JSON::Validator 1.08 % pmvers Mojolicious 7.59 % pmvers Mojolicious::Plugin::OpenAPI 1.15 Error message in plack-error.log is: Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": [JSON::Validator] GET http://swagger.io/v2/schema.json == Connect timeout at /usr/share/perl5/JSON/Validator.pm line 274. Compilation failed in require at (eval 389) line 1. Regards, Ian Gordon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #16 from Victor Grousset/tuxayo --- == Test plan == 1. In /etc/hosts , add «127.0.0.1swagger.io» 2. try to load a page 3. it works 4. koha-plack --restart kohadev 5. try to load a page 6. endless or timeout loading 7. remove the sabotage from /etc/hosts 8. after a few seconds, the page will load Confirmed on master. It works on 19.05 (In reply to Mason James from comment #10) > hmm, this does look like a legitimate bug, caused by 22522 Possibly. Because 19.05.x doesn't have bug 22522 patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What|Removed |Added Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- This bug is marked as only affecting version 19.05.x, but it seem to affect 20.05 (as likely master) also, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Mason James from comment #13) > (In reply to Mason James from comment #11) > > (In reply to Mason James from comment #10) > > > hmm, this does look like a legitimate bug, caused by 22522 > > > > ^ oops, ignore that - i was testing on jessie :) > > > > > > the problem seems to be that the debian libjson-validator-perl package has > > the 'cache' dir omitted, which contains local copies of the various schemas > > > > looks like the schemas were removed due to a license issue... > > Source: https://metacpan.org/release/JSON-Validator > Upstream-Contact: Jan Henning Thorsen > Upstream-Name: JSON-Validator > Files-Excluded: lib/JSON/Validator/cache > Comment: The +dfsg version is created by removing the cache files from the > lib/JSON/Validator directory, where the license is unknown. > > https://salsa.debian.org/perl-team/modules/packages/libjson-validator-perl/-/ > raw/master/debian/copyright > > > > i'll attempt to build a new package with the schemas included That's weird. The schema is clearly licensed on the OpenAPI repository. It maybe I got it is about the process to acknowledge that on Debian side: https://github.com/OAI/OpenAPI-Specification/blob/master/LICENSE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #13 from Mason James --- (In reply to Mason James from comment #11) > (In reply to Mason James from comment #10) > > hmm, this does look like a legitimate bug, caused by 22522 > > ^ oops, ignore that - i was testing on jessie :) > > > the problem seems to be that the debian libjson-validator-perl package has > the 'cache' dir omitted, which contains local copies of the various schemas > looks like the schemas were removed due to a license issue... Source: https://metacpan.org/release/JSON-Validator Upstream-Contact: Jan Henning Thorsen Upstream-Name: JSON-Validator Files-Excluded: lib/JSON/Validator/cache Comment: The +dfsg version is created by removing the cache files from the lib/JSON/Validator directory, where the license is unknown. https://salsa.debian.org/perl-team/modules/packages/libjson-validator-perl/-/raw/master/debian/copyright i'll attempt to build a new package with the schemas included -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #12 from c...@pennmanor.net --- I followed the steps Jason provided to restore the cache folder on debian buster. Plack was able to start even when access to swagger.io was blocked. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What|Removed |Added Status|NEW |In Discussion --- Comment #11 from Mason James --- (In reply to Mason James from comment #10) > hmm, this does look like a legitimate bug, caused by 22522 ^ oops, ignore that - i was testing on jessie :) the problem seems to be that the debian libjson-validator-perl package has the 'cache' dir omitted, which contains local copies of the various schemas Rick, a quick solution to the problem is to restore the cached schemas $ git clone https://github.com/mojolicious/json-validator $ cd json-validator $ git reset --hard 3.06 HEAD is now at 8b19ba0 Released version 3.06 $ sudo cp -a ./lib/JSON/Validator/cache /usr/share/perl5/JSON/Validator/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22522 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #10 from Mason James ---
hmm, this does look like a legitimate bug, caused by 22522
the 'try' block always fails with...
Can't locate object method "bundle" via package
"JSON::Validator::OpenAPI::Mojolicious" at /kohadevbox/koha/Koha/REST/V1.pm
line 76.
...and the 'catch' block calls validator->load_and_validate_schema() which does
a lookup to swagger.io
./Koha/REST/V1.pm
72
73 # Try to load and merge all schemas first and validate the result just
once.
74 my $spec;
75 try {
76 $spec = $validator->bundle(
77 {
78 replace => 1,
79 schema =>
$self->home->rel_file("api/v1/swagger/swagger.json")
80 }
81 );
82
100 }
101 catch {
102 # Validation of the complete spec failed. Resort to validation
one-by-one
103 # to catch bad ones.
104 $validator->load_and_validate_schema(
105 $self->home->rel_file("api/v1/swagger/swagger.json"),
106 {
107 allow_invalid_ref => 1,
108 }
109 );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #9 from c...@pennmanor.net --- Here is the output from my fresh buster server with koha-common 20.05.00-1 $ pmvers JSON::Validator 3.06 $ pmvers Mojolicious 8.12 $ pmvers Mojolicious::Plugin::OpenAPI 2.12 From plack-error.og Compilation failed in require at (eval 410) line 1. Child process 25034 exited with status 255 Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": [JSON::Validator] GET http://swagger.io/v2/schema.json == Not Found at /usr/share/perl5/JSON/Validator.pm line 343. Compilation failed in require at (eval 410) line 1. Child process 25042 exited with status 255 Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": [JSON::Validator] GET http://swagger.io/v2/schema.json == Not Found at /usr/share/perl5/JSON/Validator.pm line 343. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #8 from Tomás Cohen Arazi --- This looks really bad if Koha is trying to contact an external site on start-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #7 from Mason James --- (In reply to Rick Conrad from comment #6) > I don't have it on-hand, but I believe it was Ubuntu 18.04. for 18.04, try running these commands $ sudo echo 'deb http://debian.koha-community.org/koha 20.05 main bionic' > /etc/apt/sources.list.d/koha.list $ sudo apt-get update; apt-get -y upgrade $ sudo apt install pmtools you should have... $ pmvers JSON::Validator 3.06 $ pmvers Mojolicious 8.12 $ pmvers Mojolicious::Plugin::OpenAPI 2.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #6 from Rick Conrad --- I don't have it on-hand, but I believe it was Ubuntu 18.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #5 from Mason James --- (In reply to Rick Conrad from comment #3) > > rick@koha:~$ pmvers JSON::Validator > 1.08 > rick@koha:~$ pmvers Mojolicious > 7.59 > rick@koha:~$ pmvers Mojolicious::Plugin::OpenAPI > 1.15 > hi Rick which debian version is this output from? buster? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 c...@pennmanor.net changed: What|Removed |Added CC||c...@pennmanor.net --- Comment #4 from c...@pennmanor.net --- I was able to reproduce this on a fresh installation of koha 20.05 from packages on debian buster. I have the webserver behind a firewall blocking all outbound traffic and could not get the koha installer to launch. After digging into the logs I saw the same connection timeouts to swagger.io As soon as I opened up our firewall the installer loaded. You can also reproduce this by dropping something bogus in your /etc/hosts file for swagger.io and restarting plack For example - 127.0.0.1 swagger.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #3 from Rick Conrad --- rick@koha:~$ pmvers JSON::Validator 1.08 rick@koha:~$ pmvers Mojolicious 7.59 rick@koha:~$ pmvers Mojolicious::Plugin::OpenAPI 1.15 Also rick@koha:~$ cd / rick@koha:/$ sudo find . -name swagger ./usr/share/koha/api/v1/swagger rick@koha:/$ cd /usr/share/koha/api/v1/swagger/ rick@koha:/usr/share/koha/api/v1/swagger$ ls definitions parameters paths swagger.json definitions.json parameters.json paths.json x-primitives.json ``` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #2 from Tomás Cohen Arazi --- Can you give us more information on your setup? The 'swagger file' is bundled in Koha and there shouldn't be any external system reached out. It would help if you additionally: $ sudo apt install pmtools and then we need the output for: $ pmvers JSON::Validator $ pmvers Mojolicious $ pmvers Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Katrin Fischer changed: What|Removed |Added Component|Architecture, internals,|REST api |and plumbing| CC||katrin.fisc...@bsz-bw.de, ||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #1 from Rick Conrad --- I observed later that I was able to reach swagger.io from the server, so I tried reenabling plack and now it's working. So, this may properly be a plack issue and not a koha issue, but it seems like my library site ought to work whether or not I can connect to swagger.io, whatever that is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
