[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > Created attachment 111624 [details] [review] > Bug 23895: Fix check_sysprefs.t > > Signed-off-by: Jonathan Druart Pushed to master for 20.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 --- Comment #10 from Jonathan Druart --- Created attachment 111624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111624=edit Bug 23895: Fix check_sysprefs.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Katrin Fischer changed: What|Removed |Added Attachment #111079|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 111541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111541=edit Bug 23895: Move installer file into the mandatory directory Prior to this patch we had a confusing situation, mandatory files were in both installer/data/mysql and installer/data/mysql/mandatory To make things clearer this patch move them all into the mandatory subdir. However kohastructure.sql stay in the "root" directory. Test plan: 1. Drop and recreate your DB and use the installer to populate the DB 2. Use the merge request code from misc4dev to test the reset_all alias 3. Still with the merge request from misc4dev checkout master (you can also try 19.11 and/or 19.05) and reset_all again => All the data from the SQL mandatory files must have been correctly inserted into the DB https://gitlab.com/koha-community/koha-misc4dev/-/issues/46 Note that this patch also remove the x flag for subtag_registry.sql Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 --- Comment #7 from Katrin Fischer --- (In reply to Martin Renvoize from comment #6) > Nice one.. all works as expected after a trivial rebase. > > Signing off. > > Minor note: I'm not 100 sure all the mandatory files are in the right > place.. I get the feeling that those with translatable strings should move > to en/mandatory and be converted to yaml.. account_credit_types.sql for > example. That was perhaps my mistake.. do you agree those should move and > be converted? (I can do that in a followup bug) I think we came to the conclusion that the descriptions are dealt with on template level, so a possible follow-up for these could be to remove the descriptions from the files to avoid further confusion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- Nice one.. all works as expected after a trivial rebase. Signing off. Minor note: I'm not 100 sure all the mandatory files are in the right place.. I get the feeling that those with translatable strings should move to en/mandatory and be converted to yaml.. account_credit_types.sql for example. That was perhaps my mistake.. do you agree those should move and be converted? (I can do that in a followup bug) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Martin Renvoize changed: What|Removed |Added Attachment #105904|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 111079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111079=edit Bug 23895: Move installer file into the mandatory directory Prior to this patch we had a confusing situation, mandatory files were in both installer/data/mysql and installer/data/mysql/mandatory To make things clearer this patch move them all into the mandatory subdir. However kohastructure.sql stay in the "root" directory. Test plan: 1. Drop and recreate your DB and use the installer to populate the DB 2. Use the merge request code from misc4dev to test the reset_all alias 3. Still with the merge request from misc4dev checkout master (you can also try 19.11 and/or 19.05) and reset_all again => All the data from the SQL mandatory files must have been correctly inserted into the DB https://gitlab.com/koha-community/koha-misc4dev/-/issues/46 Note that this patch also remove the x flag for subtag_registry.sql Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 --- Comment #3 from Jonathan Druart --- Created attachment 105903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105903=edit Bug 23895: Move installer file into the mandatory directory Prior to this patch we had a confusing situation, mandatory files were in both installer/data/mysql and installer/data/mysql/mandatory To make things clearer this patch move them all into the mandatory subdir. However kohastructure.sql stay in the "root" directory. Test plan: 1. Drop and recreate your DB and use the installer to populate the DB 2. Use the merge request code from misc4dev to test the reset_all alias 3. Still with the merge request from misc4dev checkout master (you can also try 19.11 and/or 19.05) and reset_all again => All the data from the SQL mandatory files must have been correctly inserted into the DB https://gitlab.com/joubu/koha-misc4dev/-/tree/issue_46 Note that this patch also remove the x flag for subtag_registry.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added Attachment #105903|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 105904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105904=edit Bug 23895: Move installer file into the mandatory directory Prior to this patch we had a confusing situation, mandatory files were in both installer/data/mysql and installer/data/mysql/mandatory To make things clearer this patch move them all into the mandatory subdir. However kohastructure.sql stay in the "root" directory. Test plan: 1. Drop and recreate your DB and use the installer to populate the DB 2. Use the merge request code from misc4dev to test the reset_all alias 3. Still with the merge request from misc4dev checkout master (you can also try 19.11 and/or 19.05) and reset_all again => All the data from the SQL mandatory files must have been correctly inserted into the DB https://gitlab.com/koha-community/koha-misc4dev/-/issues/46 Note that this patch also remove the x flag for subtag_registry.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Jonathan Druart --- *** Bug 23948 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13897 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What|Removed |Added Summary|We should tidy up the |We should tidy up the |directories under |directories under |installer/data/myself/ |installer/data/mysql/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
