[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Assignee|bugzi...@warmlight.co.uk|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Fridolin Somers changed: What|Removed |Added Blocks||28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #149 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #148 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #147 from Jonathan Druart --- Created attachment 120048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120048=edit Bug 23971: Fix UsageStats.t Hum, what's the point of these tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #146 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds back release notes||the `AcquisitionsLog` ||preference and when enabled ||it adds logging for the ||following actions: || ||* ||Adding new baskets ||* ||Re-opening closed baskets ||* ||Modifying baskets ||* ||Modifying basket headers ||* ||Modifying basket users ||* ||Closing baskets ||* Approving ||baskets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #145 from Jonathan Druart --- Created attachment 119946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119946=edit Bug 23971: Do not always flag AcquisitionLog as 'not enabled' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #144 from Jonathan Druart --- Please fill in the release notes fields with the list of what this patch set is going to log. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #143 from Jonathan Druart --- Created attachment 119944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119944=edit Bug 23971: Rename pref with AcquisitionLog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #142 from Jonathan Druart --- Release notes are missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #141 from Kyle M Hall --- Created attachment 119412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119412=edit Bug 23971: (follow-up) Remove stale param As highlighted by Jonathan in comment #90, we were passing borrowernumber to ModBasket. This was a hangover from when we explicitly logged the borrower, which was later discovered to be unnecessary duplication, and was removed in commit "Remove data duplication". This commit removes this unnecessary parameter. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #140 from Kyle M Hall --- Created attachment 119411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119411=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #139 from Kyle M Hall --- Created attachment 119410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119410=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #138 from Kyle M Hall --- Created attachment 119409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119409=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #137 from Kyle M Hall --- Created attachment 119408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119408=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #136 from Kyle M Hall --- Created attachment 119407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119407=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #135 from Kyle M Hall --- Created attachment 119406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119406=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #134 from Kyle M Hall --- Created attachment 119405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119405=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #133 from Kyle M Hall --- Created attachment 119404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119404=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #132 from Kyle M Hall --- Created attachment 119403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119403=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Kyle M Hall changed: What|Removed |Added Attachment #119401|0 |1 is obsolete|| --- Comment #131 from Kyle M Hall --- Created attachment 119402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119402=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Kyle M Hall changed: What|Removed |Added Attachment #115976|0 |1 is obsolete|| Attachment #115977|0 |1 is obsolete|| Attachment #115978|0 |1 is obsolete|| Attachment #115979|0 |1 is obsolete|| Attachment #115980|0 |1 is obsolete|| Attachment #115981|0 |1 is obsolete|| Attachment #115982|0 |1 is obsolete|| Attachment #115983|0 |1 is obsolete|| Attachment #115984|0 |1 is obsolete|| Attachment #115985|0 |1 is obsolete|| Attachment #115986|0 |1 is obsolete|| --- Comment #130 from Kyle M Hall --- Created attachment 119401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119401=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114916|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #129 from Andrew Isherwood --- Rebased so I can rebase the dependent bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114915|0 |1 is obsolete|| --- Comment #128 from Andrew Isherwood --- Created attachment 115986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115986=edit Bug 23971: (follow-up) Remove stale param As highlighted by Jonathan in comment #90, we were passing borrowernumber to ModBasket. This was a hangover from when we explicitly logged the borrower, which was later discovered to be unnecessary duplication, and was removed in commit "Remove data duplication". This commit removes this unnecessary parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114914|0 |1 is obsolete|| --- Comment #127 from Andrew Isherwood --- Created attachment 115985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115985=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114913|0 |1 is obsolete|| --- Comment #126 from Andrew Isherwood --- Created attachment 115984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115984=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114912|0 |1 is obsolete|| --- Comment #125 from Andrew Isherwood --- Created attachment 115983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115983=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114911|0 |1 is obsolete|| --- Comment #124 from Andrew Isherwood --- Created attachment 115982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115982=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114910|0 |1 is obsolete|| --- Comment #123 from Andrew Isherwood --- Created attachment 115981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115981=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114909|0 |1 is obsolete|| --- Comment #122 from Andrew Isherwood --- Created attachment 115980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115980=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114908|0 |1 is obsolete|| --- Comment #121 from Andrew Isherwood --- Created attachment 115979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115979=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114907|0 |1 is obsolete|| --- Comment #120 from Andrew Isherwood --- Created attachment 115978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115978=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114906|0 |1 is obsolete|| --- Comment #119 from Andrew Isherwood --- Created attachment 115977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115977=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114905|0 |1 is obsolete|| --- Comment #118 from Andrew Isherwood --- Created attachment 115976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115976=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #117 from Jonathan Druart --- I've asked Tomas another look on the last patch and the question about addorder.pl > Does it make sense to have a MODIFY_BASKET log when we add/update an order > (without any info on the order)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #116 from Andrew Isherwood --- (In reply to Jonathan Druart from comment #103) > Please double check the rebased patches, I get an error on tools/viewlog.pl Good spot, sorry about that. Now fixed. > I think we should squash all the patches. They are pretty simple to read > once squashed but the history makes them very hard to follow. Fair enough. Though I have found myself referring to individual patches during this process. Maybe squashing just prior to merging would be the best approach? > It logs a "Modify an acquisitions basket" with the info of the basket when I > create or update an order. > It does not make sense to me. Can you confirm with the sponsor please? The original spec agreed with the customer requests "Who edited the basket and when", this was in the context of the basket contents. So I believe what we're doing is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #115 from Andrew Isherwood --- Created attachment 114916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114916=edit Bug 23971: (follow-up) Fix template typo As mentioned in comment #103, there was a typo in viewlog.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114867|0 |1 is obsolete|| --- Comment #114 from Andrew Isherwood --- Created attachment 114915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114915=edit Bug 23971: (follow-up) Remove stale param As highlighted by Jonathan in comment #90, we were passing borrowernumber to ModBasket. This was a hangover from when we explicitly logged the borrower, which was later discovered to be unnecessary duplication, and was removed in commit "Remove data duplication". This commit removes this unnecessary parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114866|0 |1 is obsolete|| --- Comment #113 from Andrew Isherwood --- Created attachment 114914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114914=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114865|0 |1 is obsolete|| --- Comment #112 from Andrew Isherwood --- Created attachment 114913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114913=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114864|0 |1 is obsolete|| --- Comment #111 from Andrew Isherwood --- Created attachment 114912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114912=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114863|0 |1 is obsolete|| --- Comment #110 from Andrew Isherwood --- Created attachment 114911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114911=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114862|0 |1 is obsolete|| --- Comment #109 from Andrew Isherwood --- Created attachment 114910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114910=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114861|0 |1 is obsolete|| --- Comment #108 from Andrew Isherwood --- Created attachment 114909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114909=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114860|0 |1 is obsolete|| --- Comment #107 from Andrew Isherwood --- Created attachment 114908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114908=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114859|0 |1 is obsolete|| --- Comment #106 from Andrew Isherwood --- Created attachment 114907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114907=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114858|0 |1 is obsolete|| --- Comment #105 from Andrew Isherwood --- Created attachment 114906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114906=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114857|0 |1 is obsolete|| --- Comment #104 from Andrew Isherwood --- Created attachment 114905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114905=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #103 from Jonathan Druart --- Please double check the rebased patches, I get an error on tools/viewlog.pl I think we should squash all the patches. They are pretty simple to read once squashed but the history makes them very hard to follow. (In reply to Andrew Isherwood from comment #102) > > acqui/addorder.pl is logging a MODIFY_BASKET, is that expected? > > I believe so. addorder processes the submission from the "New order" form > when adding an order to a basket, so logging the basket modification makes > sense here I think. It logs a "Modify an acquisitions basket" with the info of the basket when I create or update an order. It does not make sense to me. Can you confirm with the sponsor please? Should not we have ADD_ORDER/MODIFY_LOG instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #102 from Andrew Isherwood --- Hi Jonathan Thanks for that. I've rebased as I was getting conflicts on a couple of commits. > acqui/addorder.pl is logging a MODIFY_BASKET, is that expected? I believe so. addorder processes the submission from the "New order" form when adding an order to a basket, so logging the basket modification makes sense here I think. > Why are you adding borrowernumber? That was a hangover from when ModBasket was explicitly logging the borrower. This was highlighted as unnecessary duplication, so I removed it from the logging in the patch titled "Bug 23971: (follow-up) Remove data duplication", but missed removing it from the ModBasket call. I've now created a new commit that removes it, thanks for highlighting it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #101 from Andrew Isherwood --- Created attachment 114867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114867=edit Bug 23971: (follow-up) Remove stale param As highlighted by Jonathan in comment #90, we were passing borrowernumber to ModBasket. This was a hangover from when we explicitly logged the borrower, which was later discovered to be unnecessary duplication, and was removed in commit "Remove data duplication". This commit removes this unnecessary parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113393|0 |1 is obsolete|| --- Comment #100 from Andrew Isherwood --- Created attachment 114866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114866=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113392|0 |1 is obsolete|| --- Comment #99 from Andrew Isherwood --- Created attachment 114865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114865=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113391|0 |1 is obsolete|| --- Comment #98 from Andrew Isherwood --- Created attachment 114864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114864=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113390|0 |1 is obsolete|| --- Comment #97 from Andrew Isherwood --- Created attachment 114863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114863=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113389|0 |1 is obsolete|| --- Comment #96 from Andrew Isherwood --- Created attachment 114862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114862=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113388|0 |1 is obsolete|| --- Comment #95 from Andrew Isherwood --- Created attachment 114861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114861=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113387|0 |1 is obsolete|| --- Comment #94 from Andrew Isherwood --- Created attachment 114860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114860=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113386|0 |1 is obsolete|| --- Comment #93 from Andrew Isherwood --- Created attachment 114859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114859=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113385|0 |1 is obsolete|| --- Comment #92 from Andrew Isherwood --- Created attachment 114858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114858=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113384|0 |1 is obsolete|| --- Comment #91 from Andrew Isherwood --- Created attachment 114857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114857=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #90 from Jonathan Druart --- I squashed the patches for review and found: +++ b/acqui/basketgroup.pl @@ -307,7 +307,8 @@ if ( $op eq "add" ) { my $basketno=$input->param('basketno'); my $basketgroupid=$input->param('basketgroupid'); ModBasket( { basketno => $basketno, - basketgroupid => $basketgroupid } ); + basketgroupid => $basketgroupid, + borrowernumber => $loggedinuser } ); Why are you adding borrowernumber? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #89 from Jonathan Druart --- acqui/addorder.pl is logging a MODIFY_BASKET, is that expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #88 from Andrew Isherwood --- Hi Jonathan I've now rebased. I've also added logging of the entire basket object as requested. Revised test plan: - Apply the patch => TEST: Observe there is a new "AcqLog" syspref - Enable the AcqLog syspref - Create a basket => TEST: Observe that an Acquisitions "Create an acquisitions basket" action log has been created containing: => Basket number in "Object" column => Borrowernumber of staff member in "Librarian" column => Full basket object details in "Info" column => TEST: Observe that an Acquisitions "Modify an acquisitions basket header" action log has been created containing: => Basket number in "Object" column => Borrowernumber of staff member in "Librarian" column => Full basket object details in "Info" column - Modify a basket => TEST: Observe that an Acquisitions "Modify an acquisitions basket header" action log has been created containing: => Basket number in "Object" column => Borrowernumber of staff member in "Librarian" column => Full basket object details in "Info" column - Approve a basket via EDI => TEST: Observe that an Acquisitions "Close an acquisitions basket" action log has been created containing: => Basket number in "Object" column => Borrowernumber of staff member in "Librarian" column => Full basket object details in "Info" column => TEST: Observe that an Acquisitions "Approve an acquisitions basket" action log has been created containing: => Basket number in "Object" column => Borrowernumber of staff member in "Librarian" column => Full basket object details in "Info" column - Close a basket => TEST: Observe that an Acquisitions "Close an acquisitions basket" action log has been created containing: => Basket number in "Object" column => Borrowernumber of staff member in "Librarian" column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112307|0 |1 is obsolete|| --- Comment #86 from Andrew Isherwood --- Created attachment 113392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113392=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #87 from Andrew Isherwood --- Created attachment 113393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113393=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112305|0 |1 is obsolete|| --- Comment #85 from Andrew Isherwood --- Created attachment 113391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113391=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112301|0 |1 is obsolete|| --- Comment #81 from Andrew Isherwood --- Created attachment 113387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113387=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112304|0 |1 is obsolete|| --- Comment #84 from Andrew Isherwood --- Created attachment 113390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113390=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112302|0 |1 is obsolete|| --- Comment #82 from Andrew Isherwood --- Created attachment 113388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113388=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112300|0 |1 is obsolete|| --- Comment #80 from Andrew Isherwood --- Created attachment 113386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113386=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112303|0 |1 is obsolete|| --- Comment #83 from Andrew Isherwood --- Created attachment 113389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113389=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112298|0 |1 is obsolete|| --- Comment #78 from Andrew Isherwood --- Created attachment 113384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113384=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #112299|0 |1 is obsolete|| --- Comment #79 from Andrew Isherwood --- Created attachment 113385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113385=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #77 from Jonathan Druart --- This is conflicting with bug 26584 CONFLICT (content): Merge conflict in acqui/basket.pl CONFLICT (content): Merge conflict in Koha/EDI.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm Please rebase. (In reply to Tomás Cohen Arazi from comment #76) > I still feel the logs should include the objects, following what's been done > so far with the rest of the logs. I am with Tomas, we will know who modified the basket, but not the changes that have been made. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #76 from Tomás Cohen Arazi --- I still feel the logs should include the objects, following what's been done so far with the rest of the logs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Tomás Cohen Arazi changed: What|Removed |Added Attachment #112306|0 |1 is obsolete|| --- Comment #75 from Tomás Cohen Arazi --- Created attachment 112307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112307=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 112306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112306=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 112305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112305=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #71 from Tomás Cohen Arazi --- Created attachment 112303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112303=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 112302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112302=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #72 from Tomás Cohen Arazi --- Created attachment 112304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112304=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 112298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112298=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #69 from Tomás Cohen Arazi --- Created attachment 112301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112301=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #68 from Tomás Cohen Arazi --- Created attachment 112300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112300=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #67 from Tomás Cohen Arazi --- Created attachment 112299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112299=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/