https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #72 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #71 from Jonathan Druart
---
Created attachment 104848
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104848=edit
Bug 24161: (follow-up) Fix failing test (when running slow)
The previous assumption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #70 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #69 from Jonathan Druart
---
Created attachment 104826
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104826=edit
Bug 24161: Fix failing test (when running slow)
We "mocked" the claim date to make
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #67 from Tomás Cohen Arazi ---
Created attachment 104265
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104265=edit
Bug 24161: (follow-up) Typo in POD
Signed-off-by: Tomas Cohen Arazi
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #66 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #65 from Jonathan Druart
---
Created attachment 104259
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104259=edit
Bug 24161: (follow-up) DBIC changes
Define koha_object[s]_class methods
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #64 from Jonathan Druart
---
Created attachment 104258
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104258=edit
Bug 24161: (follow-up) Fix typo in POD
# Failed test 'POD test for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #63 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #104191|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103595|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103593|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103594|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103592|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #104190|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103591|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103589|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103588|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Attachment #103590|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Medium patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #51 from Jonathan Druart
---
Created attachment 104191
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104191=edit
Bug 24161: (follow-up) DB changes
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #50 from Jonathan Druart
---
Created attachment 104190
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104190=edit
Bug 24161: Fix license statements
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #49
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #48 from Katrin Fischer ---
1) 2 small issues in the QA script:
FAIL Koha/Acquisition/Order/Claim.pm
OK critic
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #102113|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #103567|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #103569|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #33 from Jonathan Druart
---
Created attachment 103568
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103568=edit
Bug 24161: Remove GetLateOrders
Sponsored-by: Cork Institute of Technology
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #103570|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Attachment #102114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #103571|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #103568|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #31 from Martin Renvoize ---
Feedback from sponsor testing.
(1) The 'claimed date' field lists the claimed dates side by side, could they
be stacked vertically instead with most recent at the top?
(2) The 'estimated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #102112|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #37 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #31)
> Feedback from sponsor testing.
>
> (1) The 'claimed date' field lists the claimed dates side by side, could
> they be stacked vertically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #34 from Jonathan Druart
---
Created attachment 103569
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103569=edit
Bug 24161: Add tests
Sponsored-by: Cork Institute of Technology
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #35 from Jonathan Druart
---
Created attachment 103570
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103570=edit
Bug 24161: DBIC manual changes
No idea what's happening with the current_timestamp,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #102111|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #38 from Martin Renvoize ---
Thanks for the quick followups Jonathan.
Yes, I did wonder about that final one perhaps being in master.. I'll report
that separately now you've varified.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #36 from Jonathan Druart
---
Created attachment 103571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103571=edit
Bug 24161: Display claimed dates vertically
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #39 from Martin Renvoize ---
Bug 25266 added
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Attachment #102220|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #29 from Jonathan Druart
---
Created attachment 102220
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102220=edit
Bug 24161: DBIC manual changes
No idea what's happening with the current_timestamp,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #28 from Martin Renvoize ---
Updated PTFS-E sandboxes to support email.. emails will not be delivered
externally but will go into a log file which can be accessed via the 'Logs'
menu in the sandbox UI
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #27 from Martin Renvoize ---
Rebased
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Attachment #98524|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Attachment #98527|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Attachment #98526|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Attachment #98525|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Attachment #98522|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Attachment #98523|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #20 from Jonathan Druart
---
(In reply to Angela from comment #19)
Hello Angela,
You get this error because there is no MTA (mail system) configured on the
sandbox.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Angela changed:
What|Removed |Added
CC||angela.oconnordesmond@staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Depends on||24388
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #18 from Jonathan Druart
---
Created attachment 98527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98527=edit
Bug 24161: Add tests
Sponsored-by: Cork Institute of Technology
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #17 from Jonathan Druart
---
Created attachment 98526
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98526=edit
Bug 24161: Remove GetLateOrders
Sponsored-by: Cork Institute of Technology
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #15 from Jonathan Druart
---
Created attachment 98524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98524=edit
Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes
Sponsored-by: Cork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Attachment #97114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #16 from Jonathan Druart
---
Created attachment 98525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98525=edit
Bug 24161: Keep tracks of late orders claims
So far we only record the number of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #14 from Jonathan Druart
---
Created attachment 98523
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98523=edit
Bug 24161: DBIC changes
Sponsored-by: Cork Institute of Technology
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Attachment #97472|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Bug 24161 depends on bug 12502, which changed state.
Bug 12502 Summary: Add columns for note, order number and ISBN to late orders
page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #11 from Katrin Fischer ---
I had already started here yesterday, so trying to clean up my notes:
+=head3 authorizer
Wonder if we should make this 'creator', as we have discussed for the API
endpoint.
Missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
QA Contact|katrin.fisc...@bsz-bw.de|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #9 from Jonathan Druart
---
Created attachment 97471
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97471=edit
Bug 24161: Remove GetLateOrders
Sponsored-by: Cork Institute of Technology
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #10 from Jonathan Druart
---
Created attachment 97472
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97472=edit
Bug 24161: Add tests
Sponsored-by: Cork Institute of Technology
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Attachment #97117|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Blocks|24162 |24163
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Depends on||12502
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #6 from Jonathan Druart
---
Created attachment 97119
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97119=edit
Bug 24161: Add tests
Sponsored-by: Cork Institute of Technology
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #4 from Jonathan Druart
---
Created attachment 97117
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97117=edit
Bug 24161: Keep tracks of late orders claims
So far we only record the number of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #3 from Jonathan Druart
---
Created attachment 97116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97116=edit
Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes
Sponsored-by: Cork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #5 from Jonathan Druart
---
Created attachment 97118
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97118=edit
Bug 24161: Remove GetLateOrders
Sponsored-by: Cork Institute of Technology
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #2 from Jonathan Druart
---
Created attachment 97115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97115=edit
Bug 24161: DBIC changes
Sponsored-by: Cork Institute of Technology
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #1 from Jonathan Druart
---
Created attachment 97114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97114=edit
Bug 24161: DB changes
Sponsored-by: Cork Institute of Technology
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Change sponsored?|--- |Sponsored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What|Removed |Added
Blocks||24162
Referenced Bugs:
90 matches
Mail list logo