[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Jonathan Druart changed: What|Removed |Added Blocks||30123 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Bug 24201 depends on bug 13881, which changed state. Bug 13881 Summary: Add ability to defined circulation desks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Blocks|14654 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 [Bug 14654] Add desk filter in Holds awaiting pickup list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Text to go in the||When `UseCirculationDesks` release notes||is enabled and desks are ||defined and attached to a ||library, this feature makes ||it possible to chose your ||current desk on login or ||when changing library from ||the intranet. The desk is ||then attached to the ||session. || ||Future ||developments are planned to ||allow associating hold ||pickup locations with desks ||and other features. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target|release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #102 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #101 from Jonathan Druart --- (In reply to Jonathan Druart from comment #100) > Created attachment 107981 [details] [review] > Bug 24201: fix failing tests Pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #100 from Jonathan Druart --- Created attachment 107981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107981=edit Bug 24201: fix failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #99 from Jonathan Druart --- Created attachment 107980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107980=edit Bug 24201: fix failing test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #98 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #97 from Martin Renvoize --- Created attachment 107968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107968=edit Bug 24201: (QA follow-up) Replace library select Removing the library select entirely results in a JS failure for desk selection when independant branches is enabled and the user does not have permission to select a library. This patch adds a hidden select element so we can still grab the current branch from the selection. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #96 from Martin Renvoize --- Created attachment 107967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107967=edit Bug 24201: (QA follow-up) Make logic consistent The display logic for the desk details in the header bar was inconsistent between the narrow display view and the full width display view. This patch updates the former to match the latter. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #95 from Martin Renvoize --- Created attachment 107952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107952=edit Bug 24201: (QA follow-up) IndependentBranches This patch updates the IndependentBranches template display logic such that the 'Select desk' and 'Select library and desk' options appear correctly when IndependentBranches is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #94 from Martin Renvoize --- Created attachment 107951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107951=edit Bug 24201: (QA follow-up) Add 'and desk' to menus and title Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #93 from Martin Renvoize --- (In reply to Jonathan Druart from comment #92) > Can I have an updated test plan please? > > I followed the one from comment 1: > 1. apply 13881 and create some desks > 2. you should see “NO DESK SET” in the intranet header > 3. go to circulation > Set desk > => I don't see that > 4. you should see your desk name in the header, whatever the page > 5. you can also set desk with the header menu > => I did not see it until I figured out it was in "set library" > > 2 first questions then, > - Why "NO DESK SET" vs "No desk set" vs nothing display if no desk set? > - Why not "set library and desk"? Updated test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header > This will only appear upon first applying the patch, or if you enable > 'UseDesks' during a session (If it was already enabled you will have had to > have selected a desk at login and you cannot select 'no desk' at any point > now I believe) 3. go to circulation > Set library > 'Set desk' was merged into the 'Set library' page. 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu 'NO DESK SET'.. I think Nicholas felt it was very important to highlight that no desk is set so capitalised it.. I think in reality it will appear so infrequently that the capitalisation isn't a bad thing. As for 'Set library and desk'.. I'm of two minds here, as mentioned on irc this morning. With bug 24786 we also add the ability to set 'Cash register' from this page.. we could end up with 'Set library, desk and cash register' which feels a little verbose.. we could change it here for simply be 'Set library [and desk]' when desks are enabled and then perhaps update it on bug 24786 to read 'Session settings' or something like that when both preferences are enabled? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #92 from Jonathan Druart --- Can I have an updated test plan please? I followed the one from comment 1: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk => I don't see that 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu => I did not see it until I figured out it was in "set library" 2 first questions then, - Why "NO DESK SET" vs "No desk set" vs nothing display if no desk set? - Why not "set library and desk"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #91 from Josef Moravec --- (In reply to Martin Renvoize from comment #86) > Three more tiny QA followups.. would appreciate your eyes on them Josef for > the final switch to PQA :) And one more from me again (capitalization fix) I consider it PQA now, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #90 from Josef Moravec --- Created attachment 107818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107818=edit Bug 24201: (QA follow-up) Another capitalization fix Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107751|0 |1 is obsolete|| --- Comment #88 from Josef Moravec --- Created attachment 107816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107816=edit Bug 24201: (QA follow-up) Capitalisation fix 'Set desk' vs 'Set Desk'. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107750|0 |1 is obsolete|| --- Comment #87 from Josef Moravec --- Created attachment 107815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107815=edit Bug 24201: (QA follow-up) Only display desks picker if enabled I missed a case on the authentication page with the prior patch of the same name. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107752|0 |1 is obsolete|| --- Comment #89 from Josef Moravec --- Created attachment 107817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107817=edit Bug 24201: (QA follow-up) Correct call to set_userenv One call to set_userenv had been implimented incorrectly with the parameters out of order. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24786 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Blocks||24786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 [Bug 24786] Allow setting a cash register for a login session -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #85 from Martin Renvoize --- Created attachment 107752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107752=edit Bug 24201: (QA follow-up) Correct call to set_userenv One call to set_userenv had been implimented incorrectly with the parameters out of order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #86 from Martin Renvoize --- Three more tiny QA followups.. would appreciate your eyes on them Josef for the final switch to PQA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #84 from Martin Renvoize --- Created attachment 107751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107751=edit Bug 24201: (QA follow-up) Capitalisation fix 'Set desk' vs 'Set Desk'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107672|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 107750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107750=edit Bug 24201: (QA follow-up) Only display desks picker if enabled I missed a case on the authentication page with the prior patch of the same name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #82 from Martin Renvoize --- I decided to rebase bug 24786 atop this and is highlighted a few more minor things.. setting back to SO whilst I post some further followups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #81 from Martin Renvoize --- Thanks for the additional followups and QA run Josef.. I've verified the followups all make sense so setting to PQA as it's had two QA team eyes on it now :) Great work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107679|0 |1 is obsolete|| --- Comment #79 from Martin Renvoize --- Created attachment 107731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107731=edit Bug 24201: (QA follow-up) Remove setdesk variable and add desk selection script only on pages in need Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107680|0 |1 is obsolete|| --- Comment #80 from Martin Renvoize --- Created attachment 107732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107732=edit Bug 24201: (QA follow-up) Make desk and branch selects on login page consistant Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107677|0 |1 is obsolete|| --- Comment #77 from Martin Renvoize --- Created attachment 107729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107729=edit Bug 24201: (QA follow-up) Remove unneeded use Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107678|0 |1 is obsolete|| --- Comment #78 from Martin Renvoize --- Created attachment 107730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107730=edit Bug 24201: (QA follow-up) Fix desks select box selected attribute Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107676|0 |1 is obsolete|| --- Comment #76 from Martin Renvoize --- Created attachment 107728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107728=edit Bug 24201: (QA follow-up) Do not unbless a list from search in Desks template plugin Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201
--- Comment #75 from Josef Moravec ---
(In reply to Martin Renvoize from comment #59)
> Comment on attachment 107093 [details] [review]
> Bug 24201: (follow-up) add desk choice with library choice
>
> Review of attachment 107093 [details] [review]:
> -
>
> Signing off the set.. this is a really nice and elegant solution, well done !
>
> Minor note which I'm drawing the QAers attention to, but not a direct
> failure.. more of a slight code style wonder from my point.
>
> ::: koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
> @@ +25,5 @@
> > [% Asset.js("lib/jquery/plugins/jquery.validate.min.js") | $raw %]
> >
> > [% Asset.js("js/staff-global.js") | $raw %]
> > +[% IF setdesk %]
> > +[% Asset.js("js/desk_selection.js") | $raw %]
>
> I'm wondering about the logic here.. could we not just include the Asset
> line where it's required rather than setting a TT variable to then look for
> here?
>
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
> @@ +5,4 @@
> > [% USE Categories %]
> > [% SET footerjs = 1 %]
> > +[% IF Desks.all %]
> > +[% SET setdesk = 1 %]
>
> I think it would be clearer to just include the asset in the JS includes at
> the bottom of the template here rather than set a variable to be caught to
> add it in in the js_includes block.
>
I do agree with you Martin.
I rebased the patchset, and added some follow-ups, including removing setdesk
variable...
Could you please look at my patches? I do not want to pass this QA until
somebody else look at my follow-ups. Thanks
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #74 from Josef Moravec --- Created attachment 107680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107680=edit Bug 24201: (QA follow-up) Make desk and branch selects on login page consistant Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #73 from Josef Moravec --- Created attachment 107679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107679=edit Bug 24201: (QA follow-up) Remove setdesk variable and add desk selection script only on pages in need Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #72 from Josef Moravec --- Created attachment 107678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107678=edit Bug 24201: (QA follow-up) Fix desks select box selected attribute Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #71 from Josef Moravec --- Created attachment 107677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107677=edit Bug 24201: (QA follow-up) Remove unneeded use Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107096|0 |1 is obsolete|| --- Comment #68 from Josef Moravec --- Created attachment 107674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107674=edit Bug 24201: (QA follow-up) Hide header if desks disabled Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #70 from Josef Moravec --- Created attachment 107676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107676=edit Bug 24201: (QA follow-up) Do not unbless a list from search in Desks template plugin Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107095|0 |1 is obsolete|| --- Comment #67 from Josef Moravec --- Created attachment 107673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107673=edit Bug 24201: (QA follow-up) Remove deprecated template file The controller associated to this template was deprecated earlier in this patchset, but the template was left behind. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107097|0 |1 is obsolete|| --- Comment #69 from Josef Moravec --- Created attachment 107675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107675=edit Bug 24201: (QA follow-up) Re-indent helpers Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107094|0 |1 is obsolete|| --- Comment #66 from Josef Moravec --- Created attachment 107672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107672=edit Bug 24201: (QA follow-up) Only display desks picker if enabled Minor followup to add the 'UseCirculationDesks' check to the desk picker option Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107092|0 |1 is obsolete|| --- Comment #64 from Josef Moravec --- Created attachment 107670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107670=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107091|0 |1 is obsolete|| --- Comment #63 from Josef Moravec --- Created attachment 107669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107669=edit Bug 24201: (follow-up) Use GetLoggedInDeskName This patch updates the templates to use the new TT plugin instead of adding additional variables to the already crouded get_template_and_user. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107089|0 |1 is obsolete|| --- Comment #61 from Josef Moravec --- Created attachment 107667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107667=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107090|0 |1 is obsolete|| --- Comment #62 from Josef Moravec --- Created attachment 107668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107668=edit Bug 24201: (follow-up) Show desk information at lower screen widths The staff client header menu adjusts responsively to narrower viewport widths, but for the logged-in-user menu this requires showing and hiding part of the template which duplicates information. This patch adds a copy of the current desk information to the part of the template shown at narrower widths. To test, apply the patch and view any page in the staff client. - Narrow your browser so that the viewport is less than 800px wide. - The logged-in-user menu should change from text to a single "user" icon. - Clicking the icon should display a menu which includes labeled information about the current desk. Signed-off-by: Nicolas Legrand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107093|0 |1 is obsolete|| --- Comment #65 from Josef Moravec --- Created attachment 107671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107671=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. have at least three libraries, one without desk, one with one and one with a few. 3. At login, when choosing a library, it should enable all desks it has. Pick one. 4. the desk id and name should be set in your session and appear in the top right, next to the library name. 5. change library and desks from intranet (at the set-library.pl page) 6. you should have the same behaviours 7. if you have a library without a desk, it should prompt you a '---' option and no desks will be attached to the session. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #60 from Owen Leonard --- (In reply to Martin Renvoize from comment #59) > I'm wondering about the logic here.. could we not just include the Asset > line where it's required rather than setting a TT variable to then look for > here? This patch doesn't apply for me so I'm not entirely sure what all is happening in the templates, but judging from the patch I think I agree... I don't really understand the point of setting the "setdesk" variable in some places and in others checking for "Desks.all" right in the template. The "setdesk" variable seems like an extra step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26037 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24786 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201
--- Comment #59 from Martin Renvoize ---
Comment on attachment 107093
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107093
Bug 24201: (follow-up) add desk choice with library choice
Review of attachment 107093:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24201=107093)
-
Signing off the set.. this is a really nice and elegant solution, well done !
Minor note which I'm drawing the QAers attention to, but not a direct failure..
more of a slight code style wonder from my point.
::: koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
@@ +25,5 @@
> [% Asset.js("lib/jquery/plugins/jquery.validate.min.js") | $raw %]
>
> [% Asset.js("js/staff-global.js") | $raw %]
> +[% IF setdesk %]
> +[% Asset.js("js/desk_selection.js") | $raw %]
I'm wondering about the logic here.. could we not just include the Asset line
where it's required rather than setting a TT variable to then look for here?
::: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
@@ +5,4 @@
> [% USE Categories %]
> [% SET footerjs = 1 %]
> +[% IF Desks.all %]
> +[% SET setdesk = 1 %]
I think it would be clearer to just include the asset in the JS includes at the
bottom of the template here rather than set a variable to be caught to add it
in in the js_includes block.
::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt
@@ +3,3 @@
> [% USE Koha %]
> +[% IF Desks.all %]
> +[% SET setdesk = 1 %]
I think it would be clearer to just include the asset in the JS includes at the
bottom of the template here rather than set a variable to be caught to add it
in in the js_includes block.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #58 from Martin Renvoize --- Created attachment 107097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107097=edit Bug 24201: (QA follow-up) Re-indent helpers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #57 from Martin Renvoize --- Created attachment 107096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107096=edit Bug 24201: (QA follow-up) Hide header if desks disabled Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #55 from Martin Renvoize --- Created attachment 107094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107094=edit Bug 24201: (QA follow-up) Only display desks picker if enabled Minor followup to add the 'UseCirculationDesks' check to the desk picker option Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #106576|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize --- Created attachment 107093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107093=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. have at least three libraries, one without desk, one with one and one with a few. 3. At login, when choosing a library, it should enable all desks it has. Pick one. 4. the desk id and name should be set in your session and appear in the top right, next to the library name. 5. change library and desks from intranet (at the set-library.pl page) 6. you should have the same behaviours 7. if you have a library without a desk, it should prompt you a '---' option and no desks will be attached to the session. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #103839|0 |1 is obsolete|| --- Comment #53 from Martin Renvoize --- Created attachment 107092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107092=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #56 from Martin Renvoize --- Created attachment 107095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107095=edit Bug 24201: (QA follow-up) Remove deprecated template file The controller associated to this template was deprecated earlier in this patchset, but the template was left behind. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #101880|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize --- Created attachment 107089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107089=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #101882|0 |1 is obsolete|| --- Comment #52 from Martin Renvoize --- Created attachment 107091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107091=edit Bug 24201: (follow-up) Use GetLoggedInDeskName This patch updates the templates to use the new TT plugin instead of adding additional variables to the already crouded get_template_and_user. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #101881|0 |1 is obsolete|| --- Comment #51 from Martin Renvoize --- Created attachment 107090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107090=edit Bug 24201: (follow-up) Show desk information at lower screen widths The staff client header menu adjusts responsively to narrower viewport widths, but for the logged-in-user menu this requires showing and hiding part of the template which duplicates information. This patch adds a copy of the current desk information to the part of the template shown at narrower widths. To test, apply the patch and view any page in the staff client. - Narrow your browser so that the viewport is less than 800px wide. - The logged-in-user menu should change from text to a single "user" icon. - Clicking the icon should display a menu which includes labeled information about the current desk. Signed-off-by: Nicolas Legrand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #105875|0 |1 is obsolete|| --- Comment #49 from Nicolas Legrand --- Created attachment 106576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106576=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. have at least three libraries, one without desk, one with one and one with a few. 3. At login, when choosing a library, it should enable all desks it has. Pick one. 4. the desk id and name should be set in your session and appear in the top right, next to the library name. 5. change library and desks from intranet (at the set-library.pl page) 6. you should have the same behaviours 7. if you have a library without a desk, it should prompt you a '---' option and no desks will be attached to the session. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #105874|0 |1 is obsolete|| --- Comment #48 from Nicolas Legrand --- Created attachment 105875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105875=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. have at least three libraries, one without desk, one with one and one with a few. 3. At login, when choosing a library, it should enable all desks it has. Pick one. 4. the desk id and name should be set in your session and appear in the top right, next to the library name. 5. change library and desks from intranet (at the set-library.pl page) 6. you should have the same behaviours 7. if you have a library without a desk, it should prompt you a '---' option and no desks will be attached to the session. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #105873|0 |1 is obsolete|| --- Comment #47 from Nicolas Legrand --- Created attachment 105874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105874=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. log in, you should see desks if they are defined. All are disabled. 3. when choosing a library, it should enabled all desks it has and pick one. 4. the desk should be in your session 5. change library from intranet 6. you should have the same behaviours -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #105869|0 |1 is obsolete|| --- Comment #46 from Nicolas Legrand --- Created attachment 105873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105873=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. log in, you should see desks if they are defined. All are disabled. 3. when choosing a library, it should enabled all desks it has and pick one. 4. the desk should be in your session (not working yet, I don't undersand how to do it) 5. change library from intranet 6. you should have the same behaviours PROBLEMS: 1. I don't know how to send desk from login page 2. What about multiple libraries with some not having desk? This patch assume that when you use desks, you use it for every libraries 3. when changing library, the bar displaying the library and the desk (up right) doesn't update the desk when arriving on the updated page of set-library.tt. It is changed only after having clicked on “continue” 4. should we keep a separate desk changing page or is it redundant? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #45 from Nicolas Legrand --- mostly working now, with still a bit missing : handling a library without desk when others have some. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #105795|0 |1 is obsolete|| --- Comment #44 from Nicolas Legrand --- Created attachment 105869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105869=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. log in, you should see desks if they are defined. All are disabled. 3. when choosing a library, it should enabled all desks it has and pick one. 4. the desk should be in your session (not working yet, I don't undersand how to do it) 5. change library from intranet 6. you should have the same behaviours PROBLEMS: 1. I don't know how to send desk from login page 2. What about multiple libraries with some not having desk? This patch assume that when you use desks, you use it for every libraries 3. when changing library, the bar displaying the library and the desk (up right) doesn't update the desk when arriving on the updated page of set-library.tt. It is changed only after having clicked on “continue” 4. should we keep a separate desk changing page or is it redundant? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #43 from Nicolas Legrand --- Still not sorry... I'm fighting with the login page. Hope it'll be ready today... If not, next week. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #42 from Katrin Fischer --- Hi Nicolas, is this ready again for testing? (Needs signoff) or is there still a question that needs to be resolved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #103840|0 |1 is obsolete|| --- Comment #41 from Nicolas Legrand --- Created attachment 105795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105795=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. log in, you should see desks if they are defined. All are disabled. 3. when choosing a library, it should enabled all desks it has and pick one. 4. the desk should be in your session (not working yet, I don't undersand how to do it) 5. change library from intranet 6. you should have the same behaviours PROBLEMS: 1. I don't know how to send desk from login page 2. What about multiple libraries with some not having desk? This patch assume that when you use desks, you use it for every libraries 3. when changing library, the bar displaying the library and the desk (up right) doesn't update the desk when arriving on the updated page of set-library.tt. It is changed only after having clicked on “continue” 4. should we keep a separate desk changing page or is it redundant? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #40 from Nicolas Legrand --- I'm still working on it, it should be ready soon :). In June. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #39 from Frédéric Demians --- What is exactly the status of this? Since bug 13881 is in master and 20.05, what is the plan to include the actual functionality? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #38 from Josef Moravec --- (In reply to Nicolas Legrand from comment #36) > > PROBLEMS: > > 1. I don't know how to send desk from login page > 2. What about multiple libraries with some not having desk? This patch > assume that when you use desks, you use it for every libraries > 3. when changing library, the bar displaying the library and the desk > (up right) doesn't update the desk when arriving on the updated page > of set-library.tt. It is changed only after having clicked on > “continue” > 4. should we keep a separate desk changing page or is it redundant? ad 1. You should use it in C4::Auth, look to the line 1113 and below, where is 'branch' parameter used ad 2. It should take it into account and use desks for the libraries with desks and not to show any desk for libraries with no desks defined... or you can do a workaround a set desk to fake "default" desk where there is no desk. 3. I dind't run the current code yet, so I am not sure about this 4. I think this is redundant now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201
--- Comment #37 from Josef Moravec ---
Comment on attachment 103840
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103840
Bug 24201: (follow-up) add desk choice with library choice
Review of attachment 103840:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24201=103840)
-
::: Koha/Template/Plugin/Desks.pm
@@ +95,5 @@
> +for my $d ( @$desks ) {
> +if ( defined $selected and $d->{desk_id} eq $selected
> + or not defined $selected and C4::Context->userenv and
> $d->{branchcode} eq ( C4::Context->userenv->{desk_id} // q{} )
> +) {
> +$d->{selected} = 1;
You don't need selected here.
You can just return Koha::Desks->search();
::: koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
@@ +138,5 @@
>
> [% END %]
> +
> +[% IF setdesk %]
> +
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #36 from Nicolas Legrand --- Created attachment 103840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103840=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. log in, you should see desks if they are defined. All are disabled. 3. when choosing a library, it should enabled all desks it has and pick one. 4. the desk should be in your session (not working yet, I don't undersand how to do it) 5. change library from intranet 6. you should have the same behaviours PROBLEMS: 1. I don't know how to send desk from login page 2. What about multiple libraries with some not having desk? This patch assume that when you use desks, you use it for every libraries 3. when changing library, the bar displaying the library and the desk (up right) doesn't update the desk when arriving on the updated page of set-library.tt. It is changed only after having clicked on “continue” 4. should we keep a separate desk changing page or is it redundant? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #101883|0 |1 is obsolete|| --- Comment #35 from Nicolas Legrand --- Created attachment 103839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103839=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #34 from Martin Renvoize --- Time is running out for this, this cycle now.. I would love to have seen this and bug 24412 make it through alongside bug 13881 this cycle so we had a full feature. There's still a small window of opportunity if we can get back to it quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201
--- Comment #33 from Josef Moravec ---
Comment on attachment 101883
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101883
Bug 24201: (follow-up) Rework Desks Plugin
Review of attachment 101883:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24201=101883)
-
Hi Nicolas, good job
I just found a minor terminology issue from my point of view (see bellow)
And I have a logical problem with setting desks functionality:
Imaginewe have two libraries defined and each have some desks defined, for
example
Library1: Desk 1A and Desk1B
Library2: Desk 2A and Desk2b
When I set Library1 and Desk 1A and then, I need to work with Library2. There
is still Desk 1A set... I need to go at another page - setdesk.pl and set a
correct desk (2A or 2B)
I maybe have one easy solution for this - instead of adding a setdesk page,
implement the ability of setting desks into set-library page.
It also fixes the issue which Owen mentioned - using setdesk page even if it is
useless
::: Koha/Template/Plugin/Desks.pm
@@ +76,5 @@
> returns all desks existing at the library
>
> =cut
>
> +sub ListForBranch {
Would be a bit better to use 'Library' instead 'Branch' - for consistant
terminology
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #101879|0 |1 is obsolete|| --- Comment #32 from Andrew Fuerste-Henry --- Created attachment 101883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101883=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #101877|0 |1 is obsolete|| --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 101879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101879=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #101878|0 |1 is obsolete|| --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 101882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101882=edit Bug 24201: (follow-up) Use GetLoggedInDeskName This patch updates the templates to use the new TT plugin instead of adding additional variables to the already crouded get_template_and_user. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #101705|0 |1 is obsolete|| --- Comment #30 from Andrew Fuerste-Henry --- Created attachment 101881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101881=edit Bug 24201: (follow-up) Show desk information at lower screen widths The staff client header menu adjusts responsively to narrower viewport widths, but for the logged-in-user menu this requires showing and hiding part of the template which duplicates information. This patch adds a copy of the current desk information to the part of the template shown at narrower widths. To test, apply the patch and view any page in the staff client. - Narrow your browser so that the viewport is less than 800px wide. - The logged-in-user menu should change from text to a single "user" icon. - Clicking the icon should display a menu which includes labeled information about the current desk. Signed-off-by: Nicolas Legrand Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #101704|0 |1 is obsolete|| --- Comment #29 from Andrew Fuerste-Henry --- Created attachment 101880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101880=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #101848|0 |1 is obsolete|| --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 101878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101878=edit Bug 24201: (follow-up) Use GetLoggedInDeskName This patch updates the templates to use the new TT plugin instead of adding additional variables to the already crouded get_template_and_user. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #101866|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 101877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101877=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #101865|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 101866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101866=edit Bug 24201: (follow-up) Rework Desks Plugin This patch removes unused plugin methods (they can be re-introduced in subsequent bugs where they are used) and merges the 'all' and 'defined' methods into a ListForBranch method that returns a list of desks associated with the logged in branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
