[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #14 from Hayley Mapley --- Hi, Backporting this to 18.11.x resulted in conflicts which I don't know how to resolve. Can somebody please rebase for 18.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.02 released in|| --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |r...@rbit.cz |ity.org | QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens changed: What|Removed |Added Attachment #96283|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 96308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96308=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec changed: What|Removed |Added Assignee|josef.mora...@gmail.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What|Removed |Added Attachment #96279|0 |1 is obsolete|| --- Comment #9 from Michal Denar --- Created attachment 96283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96283=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #8 from Michal Denar --- Jonathan, plase follow test plan: - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower On your screenshot is PREDUEDGST ON. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added Attachment #96240|0 |1 is obsolete|| --- Comment #7 from Radek Šiman (R-Bit Technology, s.r.o.) --- Created attachment 96279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96279=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #6 from Jonathan Druart --- Are you sure about this patch? It sounds like a duplicate of bug 24072. I setup: https://snipboard.io/NfnZeG.jpg Then run advance_notices.pl Withtout this patch: MariaDB [koha_kohadev]> select * from message_queue\G *** 1. row *** message_id: 33 borrowernumber: 5 subject: Item Due Reminder content: You have 1 items due metadata: letter_code: DUEDGST message_transport_type: email status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root@localhost content_type: NULL *** 2. row *** message_id: 34 borrowernumber: 5 subject: duegst content: duedgst sms metadata: letter_code: DUEDGST message_transport_type: sms status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root@localhost content_type: NULL 2 rows in set (0.00 sec) With this patch: nothing is generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.) --- Please add missing parameters to all 4 calls of "send_digests". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What|Removed |Added Attachment #96238|0 |1 is obsolete|| --- Comment #4 from Michal Denar --- Created attachment 96240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96240=edit Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #3 from Josef Moravec --- Created attachment 96238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96238=edit Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.) --- To reproduce this bug, please turn OFF sms PREDUEDGST, but have sms DUEDGST turned ON for a given borrower. Sms version of DUEDGST is never generated into the message queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) --- Function send_digests contains hard-coded value "advance_notice" in messge_name (line 552 of advance_notice.pl), but it should be passed-in as a parameter, because it's called for Advance_Notice as well as for Item_Due message attributes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What|Removed |Added Severity|enhancement |normal CC||blac...@gmail.com, ||josef.mora...@gmail.com, ||mag...@libriotech.no, ||martin.renvoize@ptfs-europe ||.com, r...@rbit.cz Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
