[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #7 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Katrin Fischer changed: What|Removed |Added Attachment #101315|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 101379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101379=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 David Nind changed: What|Removed |Added Attachment #100968|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 101315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101315=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Jonathan Druart changed: What|Removed |Added Attachment #97668|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 100968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100968=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Fridolin SOMERS --- I tried to SO. There is one use left in test suite : $ git grep _get_itype t/db_dependent/Reserves.t:my $itype = C4::Reserves::_get_itype($item); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 --- Comment #1 from Jonathan Druart --- Created attachment 97668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97668=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/