https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #33 from Victor Grousset/tuxayo ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Pushed to stable|Pushed to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #31 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #30)
> I do recreate on master!
See bug 27828.
(In reply to Jonathan Druart from comment #17)
> Doing that is not trivial and will certainly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Blocks||27828
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #30 from Jonathan Druart
---
I do recreate on master!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Version(s)|21.05.00,20.11.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Stefan Norinder changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Fridolin Somers changed:
What|Removed |Added
Version(s)|21.05.00|21.05.00,20.11.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #26 from Jonathan Druart
---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Marcel de Rooy changed:
What|Removed |Added
Attachment #116813|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Marcel de Rooy changed:
What|Removed |Added
Attachment #116779|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #22 from Jonathan Druart
---
Amanded the patch with:
@ C4/ImportBatch.pm:81 @ BEGIN {
SetImportRecordOverlayStatus
GetImportRecordStatus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Attachment #116792|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #20 from Marcel de Rooy ---
+SetMatchedBiblionumber( $biblio->{import_record_id}, $biblionumber );
No compiler warning, but not exported in module?
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #19 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #17)
> A simple batch seemed better to backport.
Typo! A simple *patch* :D
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #18 from Jonathan Druart
---
Created attachment 116792
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116792=edit
Bug 24469: Move the new queries to a dedicated ImportBatch subroutine
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #17 from Jonathan Druart
---
Yes Marcel, it's a valid question.
I decided to put those 2 lines in the controller to avoid C4::ImportBatch.
Having a new subroutine there to update matched_biblionumber doesn't really
make
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #116255|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #102805|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #13 from Andrew Fuerste-Henry ---
Fleshed out test plan based on general confusion.
Test plan:
A/ Create a new order from a stage file.
Use the "Save" button at the bottom of the "Add orders from" page
Then note the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #12 from Andrew Fuerste-Henry ---
(In reply to Séverine Queune from comment #11)
> No problem to reproduce bug on master.
> The patch works fine for me, except one point : I first thought status of
> staged files was
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #10 from Victor Grousset/tuxayo ---
Message from Jonathan on IRC
> about 24469 - the important bit is to use the "Add" link, not the "Save"
> button
I'm not even a that part yet. It's A/ on first phase (bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #9 from Victor Grousset/tuxayo ---
> You should stage it, then create an order "From a staged file"
Whoops, I meant staged, terminology error.
"Home › Acquisitions › My Vendor › Basket 1 › Add orders from MARC file"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #8 from Jonathan Druart
---
Don't import it.
You should stage it, then create an order "From a staged file"
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Attachment #99073|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Sally changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #4 from Jonathan Druart
---
(In reply to Andrew Fuerste-Henry from comment #2)
> In my testing, matched_biblionumber remains null in test A using the Save
> button. Test B using the Add order link successfully populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Attachment #98760|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
--- Comment #1 from Jonathan Druart
---
Created attachment 98760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98760=edit
Bug 24469: Record biblionumber in import_biblio when adding to basket via file
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Jonathan Druart changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469
Andrew Fuerste-Henry changed:
What|Removed |Added
See Also|
46 matches
Mail list logo
