[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #6 from Katrin Fischer --- I can see in bug history, that this was switched to signed off by shum...@gmail.com, but there is no sign-off line/comment. As this is a easy to read/test template change, I think PQA is ok with or without the SO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What|Removed |Added Attachment #98483|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 98621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98621=edit Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Hasina changed: What|Removed |Added CC||shum...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What|Removed |Added Attachment #98421|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 98483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98483=edit Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #3 from Katrin Fischer --- I'll usually just do it - but I noticed it happens quite often now, so trying to get to the root of the issue :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Lucas, can you please update your patch to include a bug description and test plan? I think you might have done it in the git bz attach step - but that doesn't change the patch file itself and it's still empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #1 from Lucas Gass --- Created attachment 98421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98421=edit Bug 24585: Add suggested on/managed on columns This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
