[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.05 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #23 from Joy Nelson --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #22 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #19) > *** Bug 24753 has been marked as a duplicate of this bug. *** No, bug 24753 has been pushed. Follow-up removed. The QAed version of the patches on this report is out of date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added Attachment #99752|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #21 from David Cook --- (In reply to Martin Renvoize from comment #9) > That's awesome diligent work there David, thanks so much for checking it out > and adding the enhanced test on top I was seeing of but unsure where to go > with. > > I'll work through testing it today for a quick route to QA. > > Teamwork is awesome, it's great to have you back involved . Teamwork is totally awesome! Aww thanks. When you put it that way, I guess I better keep up my efforts heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added Depends on|24753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753 [Bug 24753] Typo in filepath for test t/Koha/Middlware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Bug 24739 depends on bug 24753, which changed state. Bug 24753 Summary: Typo in filepath for test t/Koha/Middlware/RealIP.t https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753 What|Removed |Added Status|Passed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #19 from Marcel de Rooy --- *** Bug 24753 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added Attachment #99749|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 99751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99751=edit Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version Test plan: 0. Apply patch 1. Set up Koha on stretch (e.g. koha/koha-testing:master) 2. perl t/Koha/Middlware/RealIP.t 3. Observe the following: Subtest: IPv6 support ok 1 - Warn on IPv6 koha_trusted_proxies ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header 1..2 ok 13 - IPv6 support 4. Set up Koha on buster (e.g. koha/koha-testing:master-buster) 5. perl t/Koha/Middlware/RealIP.t 6. Observe the following: Subtest: IPv6 support ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address 1..1 ok 13 - IPv6 support Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added Attachment #99748|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 99750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99750=edit Bug 24739: Skip tests when IPv6 support is found Signed-off-by: David Cook Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #17 from Marcel de Rooy --- Created attachment 99752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99752=edit Bug 24739: (QA follow-up) Get rid of Middlware I like Middleware better ;) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #18 from Marcel de Rooy --- (In reply to David Cook from comment #4) > Ah crumbs... just realized I made a typo in the path for the test... > t/Koha/Middlware/RealIP.t should be t/Koha/Middleware/RealIP.t... Follow-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #14 from Marcel de Rooy --- Tested a Buster container too. Looks good. === D10 ok 1 - use Koha::Middleware::RealIP; ok 2 - There is no X-Forwarded-For header, so just use the remote address ok 3 - Don't trust 1.1.1.1 as a proxy, so use it as the remote address ok 4 - Trust proxy (1.1.1.1), so use the X-Forwarded-For header for the remote address ok 5 - Trust multiple proxies (1.1.1.1 and 3.3.3.3), so use the X-Forwaded-For portion for the remote address ok 6 - Warn on misconfigured koha_trusted_proxies ok 7 - koha_trusted_proxies is misconfigured so ignore the X-Forwarded-For header ok 8 - Warn on partially misconfigured koha_trusted_proxies ok 9 - koha_trusted_proxies contains an invalid value but still includes one correct value, which is relevant, so use X-Forwarded-For header ok 10 - Trust proxy (1.1.1.1) using CIDR notation, so use the X-Forwarded-For header for the remote address ok 11 - Trust proxy (1.1.1.1) using abbreviated notation, so use the X-Forwarded-For header for the remote address ok 12 - Trust proxy (1.1.1.1) using an IP address and netmask separated by a colon, so use the X-Forwarded-For header for the remote address # Subtest: IPv6 support ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address 1..1 ok 13 - IPv6 support === D9 ok 1 - use Koha::Middleware::RealIP; ok 2 - There is no X-Forwarded-For header, so just use the remote address ok 3 - Don't trust 1.1.1.1 as a proxy, so use it as the remote address ok 4 - Trust proxy (1.1.1.1), so use the X-Forwarded-For header for the remote address ok 5 - Trust multiple proxies (1.1.1.1 and 3.3.3.3), so use the X-Forwaded-For portion for the remote address ok 6 - Warn on misconfigured koha_trusted_proxies ok 7 - koha_trusted_proxies is misconfigured so ignore the X-Forwarded-For header ok 8 - Warn on partially misconfigured koha_trusted_proxies ok 9 - koha_trusted_proxies contains an invalid value but still includes one correct value, which is relevant, so use X-Forwarded-For header ok 10 - Trust proxy (1.1.1.1) using CIDR notation, so use the X-Forwarded-For header for the remote address ok 11 - Trust proxy (1.1.1.1) using abbreviated notation, so use the X-Forwarded-For header for the remote address ok 12 - Trust proxy (1.1.1.1) using an IP address and netmask separated by a colon, so use the X-Forwarded-For header for the remote address # Subtest: IPv6 support ok 1 - Warn on IPv6 koha_trusted_proxies ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header 1..2 ok 13 - IPv6 support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #13 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize --- Excellent work, thanks David.. all checks out to me.. Signing off on your followup :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Attachment #99730|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 99749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99749=edit Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version Test plan: 0. Apply patch 1. Set up Koha on stretch (e.g. koha/koha-testing:master) 2. perl t/Koha/Middlware/RealIP.t 3. Observe the following: Subtest: IPv6 support ok 1 - Warn on IPv6 koha_trusted_proxies ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header 1..2 ok 13 - IPv6 support 4. Set up Koha on buster (e.g. koha/koha-testing:master-buster) 5. perl t/Koha/Middlware/RealIP.t 6. Observe the following: Subtest: IPv6 support ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address 1..1 ok 13 - IPv6 support Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Attachment #99729|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 99748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99748=edit Bug 24739: Skip tests when IPv6 support is found Signed-off-by: David Cook Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #9 from Martin Renvoize --- That's awesome diligent work there David, thanks so much for checking it out and adding the enhanced test on top I was seeing of but unsure where to go with. I'll work through testing it today for a quick route to QA. Teamwork is awesome, it's great to have you back involved . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #8 from David Cook --- Ok I signed off your patch (forgot to update the patch title). I also enhanced your patch with a patch of my own, so that it tests IPv6 support if Net::Netmask is a version that supports IPv6 and states that it can't handle IPv6 if it's on a lower version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #7 from David Cook --- Created attachment 99730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99730=edit Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version Test plan: 0. Apply patch 1. Set up Koha on stretch (e.g. koha/koha-testing:master) 2. perl t/Koha/Middlware/RealIP.t 3. Observe the following: Subtest: IPv6 support ok 1 - Warn on IPv6 koha_trusted_proxies ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header 1..2 ok 13 - IPv6 support 4. Set up Koha on buster (e.g. koha/koha-testing:master-buster) 5. perl t/Koha/Middlware/RealIP.t 6. Observe the following: Subtest: IPv6 support ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address 1..1 ok 13 - IPv6 support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 David Cook changed: What|Removed |Added Attachment #99690|0 |1 is obsolete|| --- Comment #6 from David Cook --- Created attachment 99729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99729=edit Bug 24739: Skip tests when IPv6 support is found Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #5 from David Cook --- (In reply to Martin Renvoize from comment #2) > I think my patch is wrong.. What I'm not sure about is whether the Koha side > would handle IPv6 addresses correctly yet and as such whether the failure is > flagging more work Koha side rather than a need to skip the test. It seems to me that Koha could handle an IPv6 address in REMOTE_ADDR, so it would be more optimal to test for IPv6 success with Net::Netmask I think. But your patch works overall. Works on koha/koha-testing:master-buster: 1..14 ok 1 - use Koha::Middleware::RealIP; ok 2 - There is no X-Forwarded-For header, so just use the remote address ok 3 - Don't trust 1.1.1.1 as a proxy, so use it as the remote address ok 4 - Trust proxy (1.1.1.1), so use the X-Forwarded-For header for the remote address ok 5 - Trust multiple proxies (1.1.1.1 and 3.3.3.3), so use the X-Forwaded-For portion for the remote address ok 6 - Warn on misconfigured koha_trusted_proxies ok 7 - koha_trusted_proxies is misconfigured so ignore the X-Forwarded-For header ok 8 - Warn on partially misconfigured koha_trusted_proxies ok 9 - koha_trusted_proxies contains an invalid value but still includes one correct value, which is relevant, so use X-Forwarded-For header ok 10 - Trust proxy (1.1.1.1) using CIDR notation, so use the X-Forwarded-For header for the remote address ok 11 - Trust proxy (1.1.1.1) using abbreviated notation, so use the X-Forwarded-For header for the remote address ok 12 - Trust proxy (1.1.1.1) using an IP address and netmask separated by a colon, so use the X-Forwarded-For header for the remote address ok 13 # skip Net::Netmask at 1.9104+ supports IPv6 ok 14 # skip Net::Netmask at 1.9104+ supports IPv6 Works on koha/koha-testing:master 1..14 ok 1 - use Koha::Middleware::RealIP; ok 2 - There is no X-Forwarded-For header, so just use the remote address ok 3 - Don't trust 1.1.1.1 as a proxy, so use it as the remote address ok 4 - Trust proxy (1.1.1.1), so use the X-Forwarded-For header for the remote address ok 5 - Trust multiple proxies (1.1.1.1 and 3.3.3.3), so use the X-Forwaded-For portion for the remote address ok 6 - Warn on misconfigured koha_trusted_proxies ok 7 - koha_trusted_proxies is misconfigured so ignore the X-Forwarded-For header ok 8 - Warn on partially misconfigured koha_trusted_proxies ok 9 - koha_trusted_proxies contains an invalid value but still includes one correct value, which is relevant, so use X-Forwarded-For header ok 10 - Trust proxy (1.1.1.1) using CIDR notation, so use the X-Forwarded-For header for the remote address ok 11 - Trust proxy (1.1.1.1) using abbreviated notation, so use the X-Forwarded-For header for the remote address ok 12 - Trust proxy (1.1.1.1) using an IP address and netmask separated by a colon, so use the X-Forwarded-For header for the remote address ok 13 - Warn on IPv6 koha_trusted_proxies ok 14 - IPv6 support was added in 1.9104 version of Net::Netmask -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 David Cook changed: What|Removed |Added Depends on||24753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753 [Bug 24753] Typo in filepath for test t/Koha/Middlware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #4 from David Cook --- Ah crumbs... just realized I made a typo in the path for the test... t/Koha/Middlware/RealIP.t should be t/Koha/Middleware/RealIP.t... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #3 from David Cook --- My bad. I should have looked more closely at that. I suppose the IPv6 handling would be useful if the reverse proxy is trusted, because then it doesn't pass that IP address on to the rest of Koha, but yeah if the REMOTE_ADDR was an IPv6 address I'm not sure. Let's see... Looks like REMOTE_ADDR gets directly requested by: - C4/Context.pm #Used by Koha::Middleware::RealIP, so no drama - C4/InstallAuth.pm #Actually this is commented out, so should be removed anyway - C4/Auth.pm #Used by SessionRestrictionByIP which is just string equality matching, so should be OK #Saved/retrieved from session, so should be OK - Koha/Middleware/RealIP.pm #Parsed with Net::Netmask, so no drama - opac/ilsdi.pl #Currently string equality matching, so should be OK #In the future with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537, hopefully will use Net::Netmask too, so should be OK - opac/opac-detail.pl #Uses regex for OpacSuppressionByIPRange, which is essentially string matching, so nothing should bust. - opac/opac-search.pl #Uses regex for OpacSuppressionByIPRange, which is essentially string matching, so nothing should bust. - opac/opac-restrictedpage.pl #Uses regex for RestrictedPageLocalIPs, which is essentially string matching, so nothing should bust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #2 from Martin Renvoize --- I think my patch is wrong.. What I'm not sure about is whether the Koha side would handle IPv6 addresses correctly yet and as such whether the failure is flagging more work Koha side rather than a need to skip the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #1 from Martin Renvoize --- Created attachment 99690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99690=edit Bug 24739: Skip tests when IPv6 support is found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
