[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 --- Comment #9 from Kyle M Hall --- Created attachment 102811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102811=edit Bug 24802 [19.05]: Updating holds can cause suspensions to apply to wrong hold On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to! Test Plan: 1) Place two holds on a record 2) Check in an item and trap it for the first hold 3) Now that one hold is waiting and the other is not, attempt to set a suspension date using the "Update hold(s)" button 4) Note your hold does not get suspended! 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Your hold should now be suspended! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802
--- Comment #8 from Lucas Gass ---
My rebase:
else {
for (my $i=0;$i<$count;$i++){
undef $itemnumber[$i] if !$itemnumber[$i];
-ModReserve({
+my $suspend_until = $query->param( "suspend_until_" . $reserve_id[$i]
);
+my $params = {
rank => $rank[$i],
reserve_id => $reserve_id[$i],
branchcode => $branch[$i],
itemnumber => $itemnumber[$i],
-suspend_until => $suspend_until[$i]
-});
+defined $suspend_until ? ( suspend_until => $suspend_until ) : (),
+};
+if (C4::Context->preference('AllowHoldDateInFuture')) {
+$params->{reservedate} = $reservedates[$i] ?
dt_from_string($reservedates[$i]) : undef;
+}
+
+ModReserve($params);
}
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- attempted to rebase and all seems good, test plan works but I fail the qa tool: FAIL reserve/modrequest.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Global symbol "@reservedates" requires explicit package name (did you forget to declare "my @reservedates"?) Global symbol "@reservedates" requires explicit package name (did you forget to declare "my @reservedates"?) reserve/modrequest.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.05 released in|| --- Comment #6 from Joy Nelson --- Pushed to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Marcel de Rooy changed: What|Removed |Added Attachment #100155|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 100216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100216=edit Bug 24802: Updating holds can cause suspensions to apply to wrong hold On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to! Test Plan: 1) Place two holds on a record 2) Check in an item and trap it for the first hold 3) Now that one hold is waiting and the other is not, attempt to set a suspension date using the "Update hold(s)" button 4) Note your hold does not get suspended! 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Your hold should now be suspended! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #100141|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 100155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100155=edit Bug 24802: Updating holds can cause suspensions to apply to wrong hold On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to! Test Plan: 1) Place two holds on a record 2) Check in an item and trap it for the first hold 3) Now that one hold is waiting and the other is not, attempt to set a suspension date using the "Update hold(s)" button 4) Note your hold does not get suspended! 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Your hold should now be suspended! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Kyle M Hall changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 --- Comment #1 from Kyle M Hall --- Created attachment 100141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100141=edit Bug 24802: Updating holds can cause suspensions to apply to wrong hold On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to! Test Plan: 1) Place two holds on a record 2) Check in an item and trap it for the first hold 3) Now that one hold is waiting and the other is not, attempt to set a suspension date using the "Update hold(s)" button 4) Note your hold does not get suspended! 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Your hold should now be suspended! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
