[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #56 from Nick Clemens --- Created attachment 110884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110884=edit Bug 24807: [20.05.x] Add "year" type to improve sorting behaviour Add a "year" search

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #55 from Jonathan Druart --- Follow-up pushed to master, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #54 from Nick Clemens --- Created attachment 110355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110355=edit Bug 24807: (QA follow-up) Remove uneccessary tests These tests fail now, the code expects

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #52 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108388|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108387|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108389|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108384|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108386|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108382|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108383|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Attachment #108385|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #43

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #42

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104530|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104529|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #106768|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104531|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104527|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104528|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104525|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #104526|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #32 from Nick Clemens --- Created attachment 106768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106768=edit Bug 24807: (follow-up) Add support for spaces as unknown characters -- You are receiving

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #31 from Julian Maurice --- (In reply to Nick Clemens from comment #30) > From what little I understand there, UNIMARC uses '#' as the unkown > character? or '#' translates to blank? I think that '#' translates to blank.

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 anne-cecile.bor...@iepg.fr changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #30 from Nick Clemens --- (In reply to Julian Maurice from comment #29) > > return map { s/[u]/0/gr } ( $value =~ /[0-9u]{4}/g ); > > This line has some problems IMO: > - It only considers years of 4 digits. I believe

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal -- You are

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #28 from Nick Clemens --- Created attachment 104531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104531=edit Bug 24807: (follow-up) Fix spelling Signed-off-by: Nick Clemens -- You are receiving

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #25 from Nick Clemens --- Created attachment 104528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104528=edit Bug 24807: Add suppport for uncertain fields and ranges To test: 1 - Have some records

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #26 from Nick Clemens --- Created attachment 104529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104529=edit Bug 24807: Refactor using tokenize_callbacks Signed-off-by: Nick Clemens -- You are

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #27 from Nick Clemens --- Created attachment 104530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104530=edit Bug 24807: Simplify with new and imporved value_callbacks Signed-off-by: Nick Clemens

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #24 from Nick Clemens --- Created attachment 104527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104527=edit Bug 24807: Update tests Signed-off-by: Nick Clemens -- You are receiving this mail

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added Attachment #103084|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #23 from Nick Clemens --- Created attachment 104526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104526=edit Bug 24807: Add database update script Signed-off-by: Nick Clemens -- You are receiving

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #21 from Nick Clemens --- *** Bug 24559 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #20 from David Gustafsson --- Realized that all of what tokenize_callbacks and filter_callbacks do could be expressed as value_callback if changing the processing of that callback to the one used by tokenize_callbacks

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #19 from David Gustafsson --- Created attachment 103277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103277=edit Bug 24807: Simplify with new and imporved value_callbacks -- You are receiving this

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #18 from David Gustafsson --- Created attachment 103163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103163=edit Bug 24807: Refactor using tokenize_callbacks -- You are receiving this mail because:

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #16 from David Gustafsson --- On another note all sort fields are currently concatenated in the end, so "1963-2003" will end up as "1963 2003" in Elastic anyway. I'm not sure that I agree with this since sorting on

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #17 from David Gustafsson --- We do this in the Perl code to be more specific, so could easily be "fixed". -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #15 from David Gustafsson --- At first did not realize that one case is split up one subfield value into multiple ones. The way filter_callbacks works (it might be a bit overkill to allow multiple callbacks, but that is

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #14 from David Gustafsson --- Ok! Thanks for the references, will have a look at it. Rebased against latest master so that applies again. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 David Gustafsson changed: What|Removed |Added Attachment #100176|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 David Gustafsson changed: What|Removed |Added Attachment #102548|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 David Gustafsson changed: What|Removed |Added Attachment #102547|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 David Gustafsson changed: What|Removed |Added Attachment #100171|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #9 from Nick Clemens --- (In reply to David Gustafsson from comment #7) > Hi! Sorry about the late reply. Thank you very much for considering my > patch. I am a little bit unfamiliar with conventions with regards to marc

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #8 from David Gustafsson --- I get: error: sha1 information is lacking or useless (t/Koha/SearchEngine/Elasticsearch.t). error: could not build fake ancestor Patch failed at 0001 Bug 24807: Update tests When applying

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #7 from David Gustafsson --- Hi! Sorry about the late reply. Thank you very much for considering my patch. I am a little bit unfamiliar with conventions with regards to marc record dates and did not anything like c1964

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #6 from Nick Clemens --- Hi David, I like your patch better than mine (bug 24559) but I do think we should support uncertain dates and ranges in these fields as they do meet MARC standards. 195u isn't exactly 1950, but

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #5 from Nick Clemens --- Created attachment 102548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102548=edit Bug 24807: Add suppport for uncertain fields and ranges To test: 1 - Have some records

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #4 from Nick Clemens --- Created attachment 102547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102547=edit Bug 24807: Update tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #3 from David Gustafsson --- Created attachment 100176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100176=edit Bug 24807: Add database update script -- You are receiving this mail because: You are

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 David Gustafsson changed: What|Removed |Added Attachment #100170|0 |1 is obsolete|

[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #1 from David Gustafsson --- Created attachment 100170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100170=edit Bug 24807: Add "year" type to improve sorting behaviour Add a "year" search field