[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Bug 25131 depends on bug 20415, which changed state. Bug 20415 Summary: Remove UseKohaPlugins system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #28 from Jonathan Druart --- This is still "valid". If you have enable_plugins and an empty DB you get this error at the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #27 from Joy Nelson --- missing dependencies - not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #26 from Martin Renvoize --- (In reply to Tomás Cohen Arazi from comment #23) > @RM: there you have a fix. I still think we should revamp the plugins > system. The difficulty to properly write clean tests for this is evidence > some changes are required in our architecture. Anyway, I love our plugins :-D Agreed, it's high on my priority list to really polish and improve our plugins architecture next cycle.. I had hoped to get a little further this cycle but I think we've all been tied up with other things. Let's make a concerted effort to get the install process, signatures and metadata verification workflows clear, working and well documented next cycle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #24 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #25 from Martin Renvoize --- Thanks Tomas :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #23 from Tomás Cohen Arazi --- @RM: there you have a fix. I still think we should revamp the plugins system. The difficulty to properly write clean tests for this is evidence some changes are required in our architecture. Anyway, I love our plugins :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 104003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104003=edit Bug 25131: Make sure plugin data is fresh Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #21 from Jonathan Druart --- Run t/db_dependent/Koha/Plugins/Plugins.t first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #20 from Martin Renvoize --- It's failing pretty consistently on Jekins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #18) > Test is failing: > > t/db_dependent/Koha/REST/Plugin/PluginRoutes.t .. 2/3 > # Failed test 'Plugin enabled, route defined as > C4::Context->needs_install is false' > # at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 164. > # Looks like you failed 1 test of 2. > t/db_dependent/Koha/REST/Plugin/PluginRoutes.t .. 3/3 > # Failed test 'needs_install use case tests' > # at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 169. It passes for me, can you give me more details on your env? I'm using plain koha-testing-docker (i.e. stretch and MySQL 5.5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #18 from Jonathan Druart --- Test is failing: t/db_dependent/Koha/REST/Plugin/PluginRoutes.t .. 2/3 # Failed test 'Plugin enabled, route defined as C4::Context->needs_install is false' # at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 164. # Looks like you failed 1 test of 2. t/db_dependent/Koha/REST/Plugin/PluginRoutes.t .. 3/3 # Failed test 'needs_install use case tests' # at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 169. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #17 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #16 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #15) > Created attachment 103015 [details] [review] > Bug 25131: (QA follow-up) Move test for needs_install outside the plugin > > This follow-up patch moves the check outside the register routine. The > Mojo plugin won't be loaded unless there's no need to install. > > As the original tests rely on V1.pm to be able to load the plugin, they > are still valid, and they should still pass as there's no behaviour > change. > > Signed-off-by: Tomas Cohen Arazi The startup method seems to be a better place, thanks Tomás! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 103015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103015=edit Bug 25131: (QA follow-up) Move test for needs_install outside the plugin This follow-up patch moves the check outside the register routine. The Mojo plugin won't be loaded unless there's no need to install. As the original tests rely on V1.pm to be able to load the plugin, they are still valid, and they should still pass as there's no behaviour change. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #14 from Kyle M Hall --- (In reply to Tomás Cohen Arazi from comment #10) > (In reply to Jonathan Druart from comment #6) > > Tomas, from where is this method called? > > > > When I looked yesterday I had the feeling that it should be fixed at higher > > level (ie. ->register should not be called at all if Koha is not installed > > yet). > > That's a valid point. I had the same doubt but decided to do it there > because of the repeated code. I can fix it to skip loading the plugin in > V1.pm if you guys prefer. Leaving this call to the RM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #12 from Kyle M Hall --- Created attachment 102996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102996=edit Bug 25131: Regression tests Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #13 from Kyle M Hall --- Created attachment 102997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102997=edit Bug 25131: Skip loading API plugins if Koha is not installed This patch adds a check on Koha being actually installed to the PluginRoutes Mojolicious plugin. If Koha is not installed, plugin routes won't be tried to get installed. This has the effect of making the webinstaller functional again (when enable_plugins is set to 1). To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Reset your working branch 6. Delete your database (e.g. in koha-testing-docker): $ mysql -hdb -ppassword > DROP DATABASE koha_kohadev; > CREATE DATABASE koha_kohadev; \q 7. Set enable_plugins to 1 in koha-conf.xml 8. Restart all: $ service memcached restart $ koha-plack --restart kohadev 9. Open the staff interface => FAIL: Hangs, the logs show nasty errors (koha-plack-err) 10. Apply this patches 11. Restart all 12. Repeat 10 => SUCCESS: The web installer shows up :-D 13. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Kyle M Hall changed: What|Removed |Added Attachment #102989|0 |1 is obsolete|| Attachment #102990|0 |1 is obsolete|| Attachment #102991|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall --- Created attachment 102995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102995=edit Bug 25131: Add C4::Context->needs_install This trivial patch adds a new convenient way to ask if Koha is installed. It uses the same approach as C4::Auth:730 To test: 1. Apply this patch 2. Run: $ kshell k$ t/Context.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > Tomas, from where is this method called? > > When I looked yesterday I had the feeling that it should be fixed at higher > level (ie. ->register should not be called at all if Koha is not installed > yet). That's a valid point. I had the same doubt but decided to do it there because of the repeated code. I can fix it to skip loading the plugin in V1.pm if you guys prefer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 David Nind changed: What|Removed |Added Attachment #102942|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 102990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102990=edit Bug 25131: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 David Nind changed: What|Removed |Added Attachment #102941|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 102989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102989=edit Bug 25131: Add C4::Context->needs_install This trivial patch adds a new convenient way to ask if Koha is installed. It uses the same approach as C4::Auth:730 To test: 1. Apply this patch 2. Run: $ kshell k$ t/Context.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 David Nind changed: What|Removed |Added Attachment #102943|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 102991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102991=edit Bug 25131: Skip loading API plugins if Koha is not installed This patch adds a check on Koha being actually installed to the PluginRoutes Mojolicious plugin. If Koha is not installed, plugin routes won't be tried to get installed. This has the effect of making the webinstaller functional again (when enable_plugins is set to 1). To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Reset your working branch 6. Delete your database (e.g. in koha-testing-docker): $ mysql -hdb -ppassword > DROP DATABASE koha_kohadev; > CREATE DATABASE koha_kohadev; \q 7. Set enable_plugins to 1 in koha-conf.xml 8. Restart all: $ service memcached restart $ koha-plack --restart kohadev 9. Open the staff interface => FAIL: Hangs, the logs show nasty errors (koha-plack-err) 10. Apply this patches 11. Restart all 12. Repeat 10 => SUCCESS: The web installer shows up :-D 13. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #6 from Jonathan Druart --- Tomas, from where is this method called? When I looked yesterday I had the feeling that it should be fixed at higher level (ie. ->register should not be called at all if Koha is not installed yet). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Summary|No webinstaller if |Web installer broken if |enable_plugin is set|enable_plugin is set Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
