[Koha-bugs] [Bug 25166] Add aria-hidden = "true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #12 from Joy Nelson --- enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add aria-hidden = "true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add aria-hidden = "true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add aria-hidden = "true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Katrin Fischer changed: What|Removed |Added Summary|Add "aria-hidden = true" to |Add aria-hidden = "true" to |Font Awesome icons in the |Font Awesome icons in the |OPAC|OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > https://gitlab.com/koha-community/qa-test-tools/-/issues/31 This will only handle template files (.tt and .inc) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #9 from Jonathan Druart --- https://gitlab.com/koha-community/qa-test-tools/-/issues/31 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #6 from Katrin Fischer --- I think they are - probably added after Owen wrote this? (or missed...) Is a check in QA tools doable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #8 from Owen Leonard --- Created attachment 103587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103587=edit Bug 25166: (follow-up) Update icons generated in JS This patch adds aria attributes to Font Awesome icons generated by JavaScript. The icons won't appear under normal circumstances because the code for displaying the modal dialog should replace the icons with a text label. The icons are a fallback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #7 from Jonathan Druart --- There is that regex I should improve to have a single one (no grep -v), so yes it can be added. But I wanted to know if it caught false positives (the 2 output lines) or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #5 from Jonathan Druart --- % git grep '\ koha-tmpl/opac-tmpl/bootstrap/js/global.js:\ Are not they valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Katrin Fischer changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Katrin Fischer --- I tihnk it would be good to have a check in the QA tools and some information in the coding guidelines/styple page for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Katrin Fischer changed: What|Removed |Added Attachment #103316|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 103524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103524=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103055|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 103316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103316=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #1 from Owen Leonard --- Created attachment 103055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103055=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
