[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Henry Bolshaw changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26655 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.03, |20.11.00, 20.05.03, released in|19.11.09|19.11.09, 19.05.15 CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 Status|Pushed to stable|Pushed to oldstable CC||alei...@catalyst.net.nz --- Comment #18 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #17 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- Patches squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Jonathan Druart changed: What|Removed |Added Attachment #106511|0 |1 is obsolete|| Attachment #106512|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 107109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107109=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice Bug 25244: (follow-up) QA corrections Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #13 from Katrin Fischer --- (In reply to Katrin Fischer from comment #12) > Can we switch item for something else please? In German item (for holdings) > and item (like a list item) are not the same word and there is not enough > context to make sense for translation here. I realized now, that the follow-up took care of this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #12 from Katrin Fischer --- Can we switch item for something else please? In German item (for holdings) and item (like a list item) are not the same word and there is not enough context to make sense for translation here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Attachment #106500|0 |1 is obsolete|| --- Comment #11 from Julian Maurice --- Created attachment 106512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106512=edit Bug 25244: (follow-up) QA corrections Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Attachment #106499|0 |1 is obsolete|| --- Comment #10 from Julian Maurice --- Created attachment 106511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106511=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #9 from Martin Renvoize --- Added bug 25922 to track the translation tools enhancement to allow the pickup of aria-labels for translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Depends on||25922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 [Bug 25922] aria-labels are currently not translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #8 from Martin Renvoize --- Created attachment 106500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106500=edit Bug 25244: (follow-up) QA corrections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Attachment #106406|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 106499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106499=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #6 from Martin Renvoize --- (In reply to Julian Maurice from comment #5) > Shouldn't it be "Select bibliographic record" ? Hmm, perhaps "Select search result: ".. your right it's a bib record and not an item, but to an OPAC user I'm not sure they'd want to draw the difference.. it's used for selecting a result to place on hold etc. > > I think the values of aria-label attributes are not automatically picked up > by the translator, so it is not translatable. Good question.. I didn't think about that.. is that not a wider issue though.. we need aria-labels for accessibility.. we really ought to pick them for translations. > > Also, QA script complains about missing TT filters Oops.. I'll fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Status|Signed Off |Failed QA CC||julian.maur...@biblibre.com --- Comment #5 from Julian Maurice --- Shouldn't it be "Select bibliographic record" ? I think the values of aria-label attributes are not automatically picked up by the translator, so it is not translatable. Also, QA script complains about missing TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added CC||bolsh...@parliament.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Owen Leonard changed: What|Removed |Added Attachment #106404|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 106406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106406=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #3 from Martin Renvoize --- Created attachment 106404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106404=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #2 from Martin Renvoize --- Interesting.. it looks like standard Koha is missing the aria labels entirely. Patch inbound -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Summary|Accessibility: Checkboxes |Accessibility: Checkboxes |on the search results page |on the search results page |do not contain aria labels |do not contain specific ||aria labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #1 from Hayley Mapley --- Hi Martin, I think I'm missing something, but I can't see aria-label for the checkboxes in the Staff client or the OPAC, not in the code on the webpage nor in the source code. Could you please let me know how I can see what you're seeing for "Current code"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Depends on|25243 | Blocks|23003 |25243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/