[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #19 from Tomás Cohen Arazi  ---
In order to test this, because of the DB structure changes, you need to either:
- Have a master DB, checkout this branch and upgrade
- Perform the webinstaller steps

This is because the sample data in misc4dev is not adapted to this changes, so
the handy reset_all command won't work (most probably).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

URL||https://gitlab.com/thekesol
   ||utions/Koha/-/tree/bug_2526
   ||0_holds_table

--- Comment #18 from Tomás Cohen Arazi  ---
I've added a remote branch on the URL field on this bug. That's where I'll keep
a rebased patchset up-to-date. Please test and let me know if I should add your
signature to the patchset.

https://gitlab.com/thekesolutions/Koha/-/tree/bug_25260_holds_table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-07-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20271

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #17 from Tomás Cohen Arazi  ---
*** Bug 23133 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20936

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 104056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104056=edit
Bug 25260: Schema updates [DO NOT PUSH]

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 104057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104057=edit
Bug 25260: Adapt all the things

This patch adapts many pm and test files to work with unified holds
table.

To test:

1. Remove all previous holds in reserves and old_reserves tables.
2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and
   another in transit.
CHECK => "select reserve_id, found from reserves" query in mysql should return
3 rows, where in found
column should find 'W', 'T' and another with null values.
  => "select reserve_id, found from old_reserves" query in mysql should
return 3 rows, where in found column you should find 2 with 'C', and one with
'F' values.
3. in mysql change reserve_id to the value of a hold in reserve table.
4. apply patches
5. updatedatabase
SUCCESS => you should get the following warning "There were 1 old reserves that
could not be moved, please check '_old_reserves'"
=> "select id, status, completed from holds" query in mysql should
return 5 rows.
  => The hold that had null value in found column, now should have
'placed' status and 0 in completed.
  => The one that had 'W' in found column, now should have 'waiting'
status and 0 in completed.
  => The one that had 'T' in found column, now should have 'in_transit'
status and 0 in completed.
  => The one that had 'F' in found column, now should have 'fulfilled'
status and 1 in completed.
  => The unmodified cancelled hold, now should have 'cancelled' status
and 1 in completed.
=> "select * from _old_reserves" should give you one row with the
modified hold.
6. in staff interface create, cancel, modify priorities, etc and everything
should work exactly as before.

 # Run every test that has reserve and hold word wihtin
 # check that you are in main koha directory
 # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL
environment variables
 # check plack is up and running.. tests will use selenium
 # prepare yourself a mug of coffe/te or take a nap.. this will take a while
7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$")

 # finally
8. Sign off

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 104053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104053=edit
Bug 25260: Add a 'holds' table

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #103991|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 104055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104055=edit
Bug 25260: Atomic update

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 104054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104054=edit
Bug 25260: Adapt Koha::Hold(s)

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #103989|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #103990|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #103992|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #103993|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Agustín Moyano  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #11 from Agustín Moyano  ---
Created attachment 103993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103993=edit
Bug 25260: Adapt all the things

This patch adapts many pm and test files to work with unified holds
table.

To test:

1. Remove all previous holds in reserves and old_reserves tables.
2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and
   another in transit.
CHECK => "select reserve_id, found from reserves" query in mysql should return
3 rows, where in found
column should find 'W', 'T' and another with null values.
  => "select reserve_id, found from old_reserves" query in mysql should
return 3 rows, where in found column you should find 2 with 'C', and one with
'F' values.
3. in mysql change reserve_id to the value of a hold in reserve table.
4. apply patches
5. updatedatabase
SUCCESS => you should get the following warning "There were 1 old reserves that
could not be moved, please check '_old_reserves'"
=> "select id, status, completed from holds" query in mysql should
return 5 rows.
  => The hold that had null value in found column, now should have
'placed' status and 0 in completed.
  => The one that had 'W' in found column, now should have 'waiting'
status and 0 in completed.
  => The one that had 'T' in found column, now should have 'in_transit'
status and 0 in completed.
  => The one that had 'F' in found column, now should have 'fulfilled'
status and 1 in completed.
  => The unmodified cancelled hold, now should have 'cancelled' status
and 1 in completed.
=> "select * from _old_reserves" should give you one row with the
modified hold.
6. in staff interface create, cancel, modify priorities, etc and everything
should work exactly as before.

 # Run every test that has reserve and hold word wihtin
 # check that you are in main koha directory
 # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL
environment variables
 # check plack is up and running.. tests will use selenium
 # prepare yourself a mug of coffe/te or take a nap.. this will take a while
7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$")

 # finally
8. Sign off

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #10 from Agustín Moyano  ---
Created attachment 103992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103992=edit
Bug 25260: Schema updates [DO NOT PUSH]

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #9 from Agustín Moyano  ---
Created attachment 103991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103991=edit
Bug 25260: Atomic update

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #103984|0   |1
is obsolete||
 Attachment #103985|0   |1
is obsolete||
 Attachment #103986|0   |1
is obsolete||
 Attachment #103987|0   |1
is obsolete||
 Attachment #103988|0   |1
is obsolete||

--- Comment #7 from Agustín Moyano  ---
Created attachment 103989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103989=edit
Bug 25260: Add a 'holds' table

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #8 from Agustín Moyano  ---
Created attachment 103990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103990=edit
Bug 25260: Adapt Koha::Hold(s)

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Agustín Moyano  changed:

   What|Removed |Added

   Patch complexity|--- |Large patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #3 from Agustín Moyano  ---
Created attachment 103985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103985=edit
Bug 25260: Adapt Koha::Hold(s)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #6 from Agustín Moyano  ---
Created attachment 103988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103988=edit
Bug 25260: Adapt all the things

This patch adapts many pm and test files to work with unified holds
table.

To test:

1. Remove all previous holds in reserves and old_reserves tables.
2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and
   another in transit.
CHECK => "select reserve_id, found from reserves" query in mysql should return
3 rows, where in found
column should find 'W', 'T' and another with null values.
  => "select reserve_id, found from old_reserves" query in mysql should
return 3 rows, where in found column you should find 2 with 'C', and one with
'F' values.
3. in mysql change reserve_id to the value of a hold in reserve table.
4. apply patches
5. updatedatabase
SUCCESS => you should get the following warning "There were 1 old reserves that
could not be moved, please check '_old_reserves'"
=> "select id, status, completed from holds" query in mysql should
return 5 rows.
  => The hold that had null value in found column, now should have
'placed' status and 0 in completed.
  => The one that had 'W' in found column, now should have 'waiting'
status and 0 in completed.
  => The one that had 'T' in found column, now should have 'in_transit'
status and 0 in completed.
  => The one that had 'F' in found column, now should have 'fulfilled'
status and 1 in completed.
  => The unmodified cancelled hold, now should have 'cancelled' status
and 1 in completed.
=> "select * from _old_reserves" should give you one row with the
modified hold.
6. in staff interface create, cancel, modify priorities, etc and everything
should work exactly as before.

 # Run every test that has reserve and hold word wihtin
 # check that you are in main koha directory
 # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL
environment variables
 # check plack is up and running.. tests will use selenium
 # prepare yourself a mug of coffe/te or take a nap.. this will take a while
7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #5 from Agustín Moyano  ---
Created attachment 103987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103987=edit
Bug 25260: Schema updates [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #4 from Agustín Moyano  ---
Created attachment 103986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103986=edit
Bug 25260: Atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #2 from Agustín Moyano  ---
Created attachment 103984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103984=edit
Bug 25260: Add a 'holds' table

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #1 from Tomás Cohen Arazi  ---
Our WIP branch can be found here:

https://gitlab.com/thekesolutions/Koha/-/blob/holds_table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Add a new 'holds' table

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/