[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Katrin Fischer changed: What|Removed |Added CC||frede...@tamil.fr Component|Templates |I18N/L10N Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Owen Leonard changed: What|Removed |Added Blocks||26719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 [Bug 26719] Replace MSG_NO_RECORD_SELECTED with translatable string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- This enhancement improves translatability so I am choosing to backport this to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Katrin Fischer changed: What|Removed |Added Attachment #107170|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 107537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107537=edit Bug 25351: Move cart-related strings out of opac-bottom.inc and into basket.js This patch adds the necessary JavaScript includes to the OPAC to enable translation of strings in JavaScript. It also updates the translation of cart-related strings by removing the strings from opac-bottom.inc and putting them in basket.js where they are used. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/basket.js for translation, e.g.: #: koha-tmpl/opac-tmpl/bootstrap/js/basket.js:89 msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated string appears. In the above example, by clicking the "Cart" icon in the header when there are no items in the cart. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106012|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 107170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107170=edit Bug 25351: Move cart-related strings out of opac-bottom.inc and into basket.js This patch adds the necessary JavaScript includes to the OPAC to enable translation of strings in JavaScript. It also updates the translation of cart-related strings by removing the strings from opac-bottom.inc and putting them in basket.js where they are used. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/basket.js for translation, e.g.: #: koha-tmpl/opac-tmpl/bootstrap/js/basket.js:89 msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated string appears. In the above example, by clicking the "Cart" icon in the header when there are no items in the cart. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from Tomás Cohen Arazi --- Tested with es-ES and works like a charm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 --- Comment #1 from Owen Leonard --- Created attachment 106012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106012=edit Bug 25351: Move cart-related strings out of opac-bottom.inc and into basket.js This patch adds the necessary JavaScript includes to the OPAC to enable translation of strings in JavaScript. It also updates the translation of cart-related strings by removing the strings from opac-bottom.inc and putting them in basket.js where they are used. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/basket.js for translation, e.g.: #: koha-tmpl/opac-tmpl/bootstrap/js/basket.js:89 msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated string appears. In the above example, by clicking the "Cart" icon in the header when there are no items in the cart. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
