[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #10 from David Cook  ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Marcel de Rooy from comment #8)
> > (In reply to Jonathan Druart from comment #6)
> > > (In reply to David Cook from comment #4)
> > > > I was wondering what KOHA_HOME was about yesterday...
> > > > 
> > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is
> > > > unset.
> > > > 
> > > > Then in kohadevbox and koha-testing-docker, an environmental variable 
> > > > can be
> > > > set to a dev install location?
> > > 
> > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't 
> > > think
> > > adding more variables will help.
> > 
> > This is not a new variable.
> 
> KOHA_HOME is not (hence this bug report). David's suggestion was to add a
> new one. At least it's what I understood.

I think you misunderstood me, Jonathan. I meant keeping the existing KOHA_HOME
variable, but setting it differently (to make it easier to re-configure for dev
environments and when using systemd services).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #9 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Jonathan Druart from comment #6)
> > (In reply to David Cook from comment #4)
> > > I was wondering what KOHA_HOME was about yesterday...
> > > 
> > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is
> > > unset.
> > > 
> > > Then in kohadevbox and koha-testing-docker, an environmental variable can 
> > > be
> > > set to a dev install location?
> > 
> > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think
> > adding more variables will help.
> 
> This is not a new variable.

KOHA_HOME is not (hence this bug report). David's suggestion was to add a new
one. At least it's what I understood.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #6)
> (In reply to David Cook from comment #4)
> > I was wondering what KOHA_HOME was about yesterday...
> > 
> > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is
> > unset.
> > 
> > Then in kohadevbox and koha-testing-docker, an environmental variable can be
> > set to a dev install location?
> 
> We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think
> adding more variables will help.

This is not a new variable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #7 from Joonas Kylmälä  ---
KOHA_HOME is the place where intranetdir code is placed, I got this with grep:

> koha-functions.sh: KOHA_HOME=$(run_safe_xmlstarlet $instancename intranetdir)

So using KOHA_HOME is favourable in my opinion to be able to support
installations with different installation paths. The user should be able to
change only the paths in koha-conf.xml and stuff should work, now without this
variable things don't work so the original patch should be extended to include
also koha-plack and maybe other scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #6 from Jonathan Druart  
---
(In reply to David Cook from comment #4)
> I was wondering what KOHA_HOME was about yesterday...
> 
> Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is
> unset.
> 
> Then in kohadevbox and koha-testing-docker, an environmental variable can be
> set to a dev install location?

We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think
adding more variables will help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #105552|0   |1
is obsolete||

--- Comment #5 from Joonas Kylmälä  ---
Created attachment 105573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105573=edit
Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
I was wondering what KOHA_HOME was about yesterday...

Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset.

Then in kohadevbox and koha-testing-docker, an environmental variable can be
set to a dev install location?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #3 from Jonathan Druart  
---
Created attachment 105552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105552=edit
Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #2 from Jonathan Druart  
---
KOHA_HOME can be:
 * /usr/share/koha  # pkg install
 * /kohadevbox/koha # dev install (or another path ofc, the one in the
intranetdir config)


Weird thing:
 * debian/scripts/koha-plack

392 adjust_paths_dev_install $name
393 export DEV_INSTALL
394 export KOHA_HOME
395
PERL5LIB=$PERL5LIB:$KOHA_HOME/installer:$KOHA_HOME/lib/installer

On a pkg install we don't have /usr/share/koha/installer or
/usr/share/koha/lib/installer
On a dev instal we don't have /kohadevbox/koha/lib

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

Jonathan Druart  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com
Summary|Something wrong with|Something wrong with
   |KOHA_HOME   |KOHA_HOME (?)

--- Comment #1 from Jonathan Druart  
---
debian/templates/koha-conf-site.xml.in:
/usr/share/koha/intranet/cgi-bin

debian/koha-common.default:KOHA_HOME="/usr/share/koha"

debian/scripts/koha-functions.sh:KOHA_HOME=$(run_safe_xmlstarlet
$instancename intranetdir)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/