[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03,

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #21 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #17 from Martin Renvoize --- Created attachment 107850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107850=edit Bug 25683: Patron with no accountlines should have 0 outstanding (not NULL) Test plan:

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added Attachment #107792|0 |1 is obsolete|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added Attachment #105705|0 |1 is obsolete|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #16 from Nick Clemens --- Created attachment 107792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107792=edit Bug 25683: (follow-up) Use COALESCE instead of IFNULL -- You are receiving this mail

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What|Removed |Added Attachment #105662|0 |1 is obsolete|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What|Removed |Added Attachment #105690|0 |1 is obsolete|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #12 from Nick Clemens --- Created attachment 105690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105690=edit Bug 25683: Fix grouping of results DBIX doesn't seem to work as I expected - if trying to

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What|Removed |Added CC||da...@davidnind.com ---

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What|Removed |Added Attachment #105620|0 |1 is obsolete|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |n...@bywatersolutions.com

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #9 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > There is a difference between no accountlines and sum(accountlines)=0. > > If I am dealing with the situation you described in comment 0: A patron

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #8 from Jonathan Druart --- There is a difference between no accountlines and sum(accountlines)=0. If I am dealing with the situation you described in comment 0: A patron had fines, but paied all of them: their balance

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #7 from Andrew Fuerste-Henry --- I don't seem to have explained the issue well up front. Nick's patch addresses what I was looking at. Jonathan, I don't entirely follow what your patch is doing or why. -- You are

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #6 from Jonathan Druart --- Nick, both changes are valid I think. My patch is fixing what is describe in comment 0. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Nick Clemens changed: What|Removed |Added Attachment #105660|0 |1 is obsolete|

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #2) > Isn't it actually a hidden feature to search for negative balance (credit)? > > If not you can test this patch! I think the issue is that

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #3 from Nick Clemens --- Created attachment 105660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105660=edit Bug 25683: [alternate] Patron with no accountlines should have 0 outstanding (not NULL) --

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #1 from Jonathan Druart --- Created attachment 105620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105620=edit Bug 25683: (bug 17168 follow-up) Don't consider negative balance Test plan: - Have a

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||17168 Referenced

[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Andrew Fuerste-Henry changed: What|Removed |Added CC|