https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #56 from Jonathan Druart ---
*** Bug 28435 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Michael Adamyk changed:
What|Removed |Added
CC|mada...@ckls.org|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Didier Gautheron changed:
What|Removed |Added
Blocks||26440
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Janet McGowan changed:
What|Removed |Added
CC||janet.mcgowan@ptfs-europe.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Ray Delahunty changed:
What|Removed |Added
CC||r.delahu...@arts.ac.uk
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Aleisha Amohia changed:
What|Removed |Added
Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Lucas Gass changed:
What|Removed |Added
Version(s)|20.11.00|20.11.00, 20.05.06
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Rickard Lindfors changed:
What|Removed |Added
CC||rickard.lindf...@sh.se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Nick Clemens changed:
What|Removed |Added
Text to go in the||Bug 19014 prioritized the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Magnus Enger changed:
What|Removed |Added
CC||mag...@libriotech.no
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #51 from Jonathan Druart
---
So are we dropping the previous work/idea to display the different messages?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #50 from Nick Clemens ---
(In reply to Katrin Fischer from comment #44)
> I know that we need this for stable releases, but instead of returning all
> errors, returning different errors depending on cron/GUI... why not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #49 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
Version(s)||20.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #48 from Jonathan Druart
---
Nick, is the plan to stay with this code or are we going to improve it on a
separate bug report?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Andrew Fuerste-Henry changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Attachment #109680|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Attachment #110009|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Attachment #110008|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Attachment #110008|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Attachment #109668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #44 from Katrin Fischer ---
I know that we need this for stable releases, but instead of returning all
errors, returning different errors depending on cron/GUI... why not make a new
combined error code for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #43 from Martin Renvoize ---
Thanks Nick, solution uploaded (after a chat on slack) :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Martin Renvoize changed:
What|Removed |Added
Attachment #109672|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #41 from Martin Renvoize ---
Something up with that backport.. uploaded in the hopes you can correct where
I've gone wrong Nick :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #40 from Martin Renvoize ---
Created attachment 109672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109672=edit
[19.11] Bug 25758: Return on_reserve over too_soon when not calling from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Martin Renvoize changed:
What|Removed |Added
Attachment #109658|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Nick Clemens changed:
What|Removed |Added
Assignee|jonathan.dru...@bugs.koha-c |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Nick Clemens changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Nick Clemens changed:
What|Removed |Added
Attachment #107894|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #36 from Jonathan Druart
---
Nick, I need you to review those 2 patches and give your opinion.
The problem is that, prior to bug 19014, we used to return on_reserve. Now we
get auto_too_soon, which causes problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #35 from Jonathan Druart
---
This patch is not enough.
Basically there are way more to fix, all the occurrences of
$error = $error->[0] if @$error;
must be adjusted.
I am putting this in discussion to get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #34 from Jonathan Druart
---
Created attachment 109139
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109139=edit
Bug 25758: Fix renewal at the OPAC
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #32 from Barbara Johnson ---
Using Katrin's test plan I got the same results. The item shows that is
scheduled for auto renewal and that it is 'on hold' in staff but none of that
information displays to the patron in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #31
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
ByWater Sandboxes changed:
What|Removed |Added
Attachment #107879|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Owen Leonard changed:
What|Removed |Added
Attachment #107504|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #28 from Jonathan Druart
---
Hi Barbara, thanks for testing!
Are you able to provide a signed-off patch (you can do that with the
sandboxes)?
Otherwise I can do it for you.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #27 from Barbara Johnson ---
Jonathan - I retested with a new sandbox and the test plan worked.
https://snipboard.io/vzET9N.jpg
--
You are receiving this mail because:
You are the assignee for the bug.
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #26 from Jonathan Druart
---
Thanks Kelly. What you reported should now be fixed by this last patch. Can you
retest please?
You will note that the "no renewal before" will display the time part 00:00. It
should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
Attachment #106229|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #24 from Kelly McElligott ---
Created attachment 107496
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107496=edit
opac renew
Also, the OPAC is not showing that there is a hold - and looks like from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #23 from Kelly McElligott ---
Created attachment 107495
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107495=edit
renew hold
This is what I am seeing while testing. I believe we may want to remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #22 from Jonathan Druart
---
Hi Barbara, I don't recreate.
How did you test? On a sandbox or locally? If locally, did you restart all the
services (plack & memcached)?
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #21 from Barbara Johnson ---
Still running into a problem with this. I set the sys pref and created the loan
rule. I checked out an item to a patron but it is not displaying in the issues
table. The item does show that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #19 from Jonathan Druart
---
Created attachment 107409
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107409=edit
Bug 25758: Fix handle of checkouts without holds
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Katrin Fischer changed:
What|Removed |Added
Status|In Discussion |Failed QA
--- Comment #18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #17 from Barbara Johnson ---
When I checked out an item that did not have a hold on it and was not scheduled
for auto renew the checkout screen did not load and display the item in the
issues table. It only showed the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #16 from Andrew Fuerste-Henry ---
With your patch applied, checkouts don't show in the checkouts table at all if
they don't have a hold on them and are not scheduled for auto-renew.
I don't believe we haven't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #15 from Barbara Johnson ---
The test plan worked. However, our issues table displays the number of
renewals used and how many are remaining. We wouldn't want to lose that
information. Here's a link to what we would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
koha-US bug tracker changed:
What|Removed |Added
CC||bugzi...@koha-us.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #14 from Jonathan Druart
---
This is what I see now: https://snipboard.io/dS1rsL.jpg
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #13 from Jonathan Druart
---
I have been trying to correct the unexpected behaviour, and I ended up with
this patch.
It modifies the way CanBookBeReserved work to make it return the different
reason of the non
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #12 from Jonathan Druart
---
Created attachment 106229
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106229=edit
Bug 25758: Display the different causes of non renewability
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
mada...@ckls.org changed:
What|Removed |Added
CC||mada...@ckls.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #11 from Daniel Gaghan ---
I concur with Katrin, we have users who determine what material they read or
view next based on if there is a hold on the material. Not having that notice
will throw them off, especially when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #10 from Katrin Fischer ---
(In reply to Joy Nelson from comment #1)
> Holds are a 'flux state' that change frequently. Is it realistic to state
> that hold have been placed on a title when those holds may or may not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Daniel Gaghan changed:
What|Removed |Added
CC||daniel.gaghan@pueblolibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #9 from Barbara Johnson ---
Peggy, We ran into the same problem. If you have the
AllowRenewalOnHoldOverride sys pref set to ‘Allow’ try changing it to ‘Don’t
Allow’. I agree with needing a fix soon. Seeing the ‘On
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Peggy Thrasher changed:
What|Removed |Added
CC||p.thras...@dover.nh.gov
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #7 from Barbara Johnson ---
I agree with Donna's assessment. I think it is more valuable to the patron to
see the 'On Hold' info. We discovered additional confusion on the staff side.
We decided to turn on the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #6 from Donna ---
The current behavior for non-auto renewable items that have a hold on them
where the only available copy/copies is checked out is that the renew status
changes to On Hold as soon as that hold is placed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #5 from Andrew Fuerste-Henry ---
(In reply to Jonathan Druart from comment #4)
> Should not we actually want to see both messages?
Both messages would be good, though that hasn't been the behavior before. How
would we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
--- Comment #3 from Barbara Johnson ---
I remember following bug 19014 and liked that patrons would no longer receive
notices of non-renewal almost as soon as they checked out a popular title with
lots of holds on it. I don't think
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Barbara Johnson changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Ed Veal changed:
What|Removed |Added
CC||ev...@mckinneytexas.org
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Joy Nelson changed:
What|Removed |Added
Status|NEW |In Discussion
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||bwsdo...@gmail.com,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758
Andrew Fuerste-Henry changed:
What|Removed |Added
Depends on||19014
Referenced
81 matches
Mail list logo