https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Lucas Gass changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Blocks||34592
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #49 from Matt Blenkinsop ---
Nice work everyone!
Pushed to oldstable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.11.00|23.11.00,22.11.08
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Martin Renvoize changed:
What|Removed |Added
Status|Needs documenting |Pushed to stable
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Martin Renvoize changed:
What|Removed |Added
Blocks||34094
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to master|Needs documenting
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Lucas Gass changed:
What|Removed |Added
Blocks||34233
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Lucas Gass changed:
What|Removed |Added
Blocks|34233 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Lucas Gass changed:
What|Removed |Added
Blocks||34233
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Blocks||34209
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #46 from Michael Hafen ---
I'm guessing you are seeing that on the patron search popup from a page other
then the patron card creator. I'll open another bug with a follow up patch to
move the whole div into the checkbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #44 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #43)
> This patch is actually adding Sort1 and Sort2 to all patrons searches.
This is not coming from this patch.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #43 from Jonathan Druart ---
This patch is actually adding Sort1 and Sort2 to all patrons searches.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #42 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Marcel de Rooy changed:
What|Removed |Added
Attachment #148489|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|Medium patch|Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #40 from Marcel de Rooy ---
(In reply to Michael Hafen from comment #39)
Thanks.
> 8. use the Add selected patrons button to add the selected patrons to the
> card batch's Add by borrowernumber(s) text input field in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #39 from Michael Hafen ---
Let me try to amend the test plan with more detail. I was just able to apply
this patch to a current master and get through the test plan successfully, but
there are details missing from the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #38 from Marcel de Rooy ---
If I am adding borrowers to the patron card batch, I am still seeing the box
"There are no patrons in this batch" and I have no possibility to go further?
Could be that I am missing config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #37 from Marcel de Rooy ---
Looking here
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Marcel de Rooy changed:
What|Removed |Added
Attachment #147477|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #36 from solene.nga...@inlibro.com ---
Created attachment 148489
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148489=edit
Bug 28726: Add sort1 and sort2 to patron card creator - patron search.
Also
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
solene.nga...@inlibro.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Attachment #143646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #33 from Katrin Fischer ---
We'll need something that works universally. The auto-complete seemed like a
good idea, but I'd like Kyle and others to comment on performance concerns.
Koha's tables are case insensitive in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #32 from Michael Hafen ---
The patron entry form and the batch patron mod form are both for setting the
value, which is a different circumstance from using a value as a filter in a
patron search.
For those entry forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #31 from Katrin Fischer ---
(In reply to Michael Hafen from comment #30)
> Making it a free text field doesn't work for me. In my opinion having a
> free text input doesn't work well for a filter field on a search page;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #30 from Michael Hafen ---
Making it a free text field doesn't work for me. In my opinion having a free
text input doesn't work well for a filter field on a search page; especially in
my case where the librarians don't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #29 from Katrin Fischer ---
I think maybe it will be easier to keep it simple and have a text field or a
pull down from AV depending on config first. As Kyle said sort fields can have
unique values, so you will have an
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #28 from Michael Hafen ---
The patch right now is trying the Authorized Values first, and if those are
empty, then it hits the database.
Kyle, are you suggesting an auto-complete style text input? I could do that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #27 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #26)
> I don't think we should be pre-populating a select pulldown from sort1/2.
> These fields could contain unique information, and a library could have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #26
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Laura changed:
What|Removed |Added
CC||Laura.escamilla@bywatersolu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #25 from ByWater Sandboxes ---
Created attachment 143646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143646=edit
Bug 28726: Add sort1 and sort2 to patron card creator - patron search.
Also adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Attachment #138653|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #23 from Katrin Fischer ---
I cannot tell about performance, but UX wise, maybe switching to a Select2
style pull down could be a compromise (like the ones used in the edit item
form).
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Status|Failed QA |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #21 from Katrin Fischer ---
To explain a little more: even with just the sample data the pull down is a
little hard to handle. If we get over 100 entries there, it will be much
harder.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Katrin Fischer changed:
What|Removed |Added
Attachment #138552|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #19 from Jonathan Druart ---
Thanks Katrin, that's exactly what I wanted to say but some parts got lost when
I rephrased the comment apparently.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #18 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #17)
> +@sort1 = sort {$a cmp $b} uniq(
> Koha::Patrons->search($sort_filter)->get_column('sort1') );
>
> This is terrible if you have lot of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Victor Grousset/tuxayo changed:
What|Removed |Added
Patch complexity|--- |Medium patch
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Emmanuel Bétemps changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #16 from sandbo...@biblibre.com ---
Created attachment 138653
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138653=edit
Bug 28726: Add sort1 and sort2 to patron card creator - patron search.
Also
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Attachment #137854|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #12 from Katrin Fischer ---
Ok, I have the same error. Chris said it could be related to git-bz not working
with ipv6.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Emmanuel Bétemps changed:
What|Removed |Added
CC||e.bete...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #13 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #12)
> Ok, I have the same error. Chris said it could be related to git-bz not
> working with ipv6.
Ok, we did some more testing and git-bz works on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #11 from Katrin Fischer ---
Hi Emmanuel, what kind of environment are you using for testing?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #10 from Michael Hafen ---
(In reply to Emmanuel Bétemps from comment #9)
> I got this message after applying the patch (which is not displayed in the
> KohaGitLog)
> (I test using a sandbox)
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #14
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Katrin Fischer changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Attachment #134003|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Katrin Fischer changed:
What|Removed |Added
Summary|Add sort1 and sort2 to |Add sort1 and sort2 to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Attachment #122991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #4 from The Minh Luong ---
Created attachment 129203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129203=edit
Bug 28726 - Add sort1 and sort2 to patron card creator - patron search.
Also adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #3 from Michael Hafen ---
Test plan:
1. start a new batch in the patron card creator (Tools -> Patron card creator
-> New -> card batch)
2. click the Add patron(s) button. Observe that Category and Library are the
only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Owen Leonard changed:
What|Removed |Added
Version|unspecified |master
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Owen Leonard changed:
What|Removed |Added
Assignee|cnighswon...@foundations.ed |michael.ha...@washk12.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Michael Hafen changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #1 from Michael Hafen ---
Created attachment 122991
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122991=edit
Proposed fix
--
You are receiving this mail because:
You are watching all bug changes.
77 matches
Mail list logo
