[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2024-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35717

--- Comment #53 from Nick Clemens  ---
I reworked this with the relationship built the other way on bug 35717

I can attempt the update there, however, I think a better path is to allow a
GUI way for the suggestions to be correctly linked, or to attempt to update and
provide a way to correct if needed.


I will be working on 19358 and 31632 this cycle which will be part of the GUI.

Please let me know if we can agree to continue this work on 35717

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #52 from Katrin Fischer  ---
OK, I am not sure I could write it either, but the first step is to make a
plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.druart+koha@gmail. |koha-b...@lists.koha-commun
   |com |ity.org

--- Comment #51 from Jonathan Druart  ---
I am not willing to write the DB rev to adjust the existing entries. I would
like help here please.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #50 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #49)
> (In reply to Katrin Fischer from comment #48)
> > Maybe we could extend the relationship later. At the moment we create an
> > order from a suggestion, so a 1:1 makes sense.
> > 
> > When I tested this my main concern was to ensure that the suggestions
> > existing previously to this fix would still work, patrons receiving emails
> > etc. Did you take a look at that aspect?
> 
> Yes, but didn't fix it. Seen comment 35?

Yes, but ... 

I think we need to fix this, but I also think we can't break existing
suggestions especially since it involves a service the library provides to
their patrons and they can't really fix it in the GUI either.

Too late today, but we should give this some more thought.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #49 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #48)
> Maybe we could extend the relationship later. At the moment we create an
> order from a suggestion, so a 1:1 makes sense.
> 
> When I tested this my main concern was to ensure that the suggestions
> existing previously to this fix would still work, patrons receiving emails
> etc. Did you take a look at that aspect?

Yes, but didn't fix it. Seen comment 35?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #48 from Katrin Fischer  ---
Maybe we could extend the relationship later. At the moment we create an order
from a suggestion, so a 1:1 makes sense.

When I tested this my main concern was to ensure that the suggestions existing
previously to this fix would still work, patrons receiving emails etc. Did you
take a look at that aspect?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #47 from Jonathan Druart  ---
I think I understand what you mean, Nick, but the UI is not allowing it for now
(to have several suggestions linked to an order).

Should we really add complexity (at least rewrite everything here) in case
maybe one day we will implement it?

It will still be possible later to move the data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion
 CC||barbara.johnson@bedfordtx.g
   ||ov,
   ||n...@bywatersolutions.com

--- Comment #46 from Nick Clemens  ---
Added a minor follow-up, otherwise it seemed to work as expected, QA tool does
note some untidiness

I think  the link here is wrong though. I believe the suggestions need to store
the ordernumber - this allows for multiple suggestions on a single order. The
current patches limit an order being tied to a single suggestion.

If a library has two patrons suggest the same title, they may only want to
order a single copy, or place a single order for multiple copies. Could it be
done with the order number stored in suggestions?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #45 from Nick Clemens  ---
Created attachment 159768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159768=edit
Bug 28844: (follow-up) Adjust suggestion id comparison

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #44 from Nick Clemens  ---
Created attachment 159767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159767=edit
Bug 28844: Adjust tests

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #43 from Nick Clemens  ---
Created attachment 159766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159766=edit
Bug 28844: Adjust other calls

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #42 from Nick Clemens  ---
Created attachment 159765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159765=edit
Bug 28844: Remove GetSuggestionFromBiblionumber

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #41 from Nick Clemens  ---
Created attachment 159764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159764=edit
Bug 28844: Replace GetSuggestionFromBiblionumber

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #40 from Nick Clemens  ---
Created attachment 159763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159763=edit
Bug 28844: Remove GetSuggestionInfoFromBiblionumber

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #39 from Nick Clemens  ---
Created attachment 159762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159762=edit
Bug 28844: Add link between suggestions and orders

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #38 from Nick Clemens  ---
Created attachment 159761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159761=edit
Bug 28844: DBIC specific

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #37 from Nick Clemens  ---
Created attachment 159760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159760=edit
Bug 28844: DBIC schema changes

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Nick Clemens  changed:

   What|Removed |Added

 Attachment #158982|0   |1
is obsolete||
 Attachment #158983|0   |1
is obsolete||
 Attachment #158984|0   |1
is obsolete||
 Attachment #158985|0   |1
is obsolete||
 Attachment #158986|0   |1
is obsolete||
 Attachment #158987|0   |1
is obsolete||
 Attachment #158988|0   |1
is obsolete||
 Attachment #158989|0   |1
is obsolete||
 Attachment #158990|0   |1
is obsolete||

--- Comment #36 from Nick Clemens  ---
Created attachment 159759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159759=edit
Bug 28844: DB changes

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #35 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #25)
> I'd really love to see this long standing issue fixed :)
> 
> 
> 1) Migration of data
> So it might not be correct, but I think it's what would be displayed on the
> order line now and where the email would be sent to, so that might be the
> best we can do?

It was left on purpose. I don't think we should copy an information if we are
not sure it is correct.
I am not confident in migrating something here.

> 2) ModSuggestion 
> 
> ModSuggestion is called to update the status of the suggestion and to send
> the email, but the calls haven't always been adjusted to look up the correct
> suggestion.

Correct, good catch. Should be fixed.

> And there are more calls I haven't checked that need to be verified.

Other calls look good.

I let you decide what the status is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #34 from Jonathan Druart  ---
Created attachment 158990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158990=edit
Bug 28844: Adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #33 from Jonathan Druart  ---
Created attachment 158989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158989=edit
Bug 28844: Adjust other calls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #32 from Jonathan Druart  ---
Created attachment 158988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158988=edit
Bug 28844: Remove GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #31 from Jonathan Druart  ---
Created attachment 158987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158987=edit
Bug 28844: Replace GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #30 from Jonathan Druart  ---
Created attachment 158986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158986=edit
Bug 28844: Remove GetSuggestionInfoFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #29 from Jonathan Druart  ---
Created attachment 158985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158985=edit
Bug 28844: Add link between suggestions and orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #28 from Jonathan Druart  ---
Created attachment 158984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158984=edit
Bug 28844: DBIC specific

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #27 from Jonathan Druart  ---
Created attachment 158983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158983=edit
Bug 28844: DBIC schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #153157|0   |1
is obsolete||
 Attachment #153158|0   |1
is obsolete||
 Attachment #153159|0   |1
is obsolete||
 Attachment #153160|0   |1
is obsolete||
 Attachment #153174|0   |1
is obsolete||
 Attachment #153175|0   |1
is obsolete||
 Attachment #153176|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  ---
Created attachment 158982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158982=edit
Bug 28844: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #25 from Katrin Fischer  ---
I'd really love to see this long standing issue fixed :)


1) Migration of data

At the moment this change would break processing the existing suggestions. As
the suggestion_id for the existing orders is empty, the information would not
show up on the orders in acq, and I am also not sure that the patrons would be
informed by email.

My suggestion: 

We only compare entries with the same biblionumber:

1 suggestion with status in (ORDERED, AVAILABLE) and 1 order => link them
1 suggestion with status (ORDERED) and 1 order with orderstatus in (ordered,
partial) => link them
1 suggestion with status (AVAILABLE) and 1 order with orderstatus (complete) =>
link them

For the rest:
Mimick what we have done until now, use the first match (LIMIT 1, ->single):

For every order line that has no suggestion_id yet
that has a matching biblionumber in suggestions
link to the suggestion_id with the lowest/smallest suggestion_id where status
in (ORDERED, AVAILABLE)

So it might not be correct, but I think it's what would be displayed on the
order line now and where the email would be sent to, so that might be the best
we can do?

2) ModSuggestion 

ModSuggestion is called to update the status of the suggestion and to send the
email, but the calls haven't always been adjusted to look up the correct
suggestion.

Orders.pm cancel()
my $suggestion = Koha::Suggestions->find({ biblionumber => $self->biblionumber,
status => "ORDERED" });
if ( $suggestion and $suggestion->id ) {

Wouldn't this fail if there is more than one suggestion for biblionumber with
status ORDERED?

addorder.pl = seems OK, because using the suggestion_id passed, but double
checking would be good

EDI.pm
my $s = $schema->resultset('Suggestion')->search(
{
biblionumber => $order->biblionumber->biblionumber,
}
)->single;
if ($s) {
ModSuggestion(
{
suggestionid => $s->suggestionid,
STATUS   => 'AVAILABLE',
}
);
}

And there are more calls I haven't checked that need to be verified.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #153163|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  ---
Created attachment 153176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153176=edit
Bug 28844: Remove GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #153162|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  ---
Created attachment 153175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153175=edit
Bug 28844: Replace GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #153161|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  ---
Created attachment 153174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153174=edit
Bug 28844: Remove GetSuggestionInfoFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #21 from Jonathan Druart  ---
Created attachment 153163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153163=edit
Bug 28844: Remove GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #20 from Jonathan Druart  ---
Created attachment 153162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153162=edit
Bug 28844: Replace GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #19 from Jonathan Druart  ---
Created attachment 153161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153161=edit
Bug 28844: Remove GetSuggestionInfoFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #18 from Jonathan Druart  ---
Created attachment 153160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153160=edit
Bug 28844: Add link between suggestions and orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #17 from Jonathan Druart  ---
Created attachment 153159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153159=edit
Bug 28844: DBIC specific

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #16 from Jonathan Druart  ---
Created attachment 153158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153158=edit
Bug 28844: DBIC schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #151001|0   |1
is obsolete||
 Attachment #151002|0   |1
is obsolete||
 Attachment #151003|0   |1
is obsolete||
 Attachment #151004|0   |1
is obsolete||
 Attachment #151005|0   |1
is obsolete||
 Attachment #151006|0   |1
is obsolete||
 Attachment #151007|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  ---
Created attachment 153157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153157=edit
Bug 28844: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #14 from Katrin Fischer  ---
Sorry, patch doesn't apply. Please reabase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Katrin Fischer  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

--- Comment #13 from Katrin Fischer  ---
*** Bug 17463 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #12 from Jonathan Druart  ---
Andrew, Katrin, can I get your opinion on these patches please? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #11 from Jonathan Druart  ---
Please do not backport this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #10 from Jonathan Druart  ---
Well, no test plan here. You need to test the whole suggestion/acquisition
workflow and search for bugs!
Link should be displayed correctly as before, and even better in cause of
multiple suggestions on the same record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #9 from Jonathan Druart  ---
Created attachment 151007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151007=edit
Bug 28844: Remove GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #8 from Jonathan Druart  ---
Created attachment 151006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151006=edit
Bug 28844: Replace GetSuggestionFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #7 from Jonathan Druart  ---
Created attachment 151005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151005=edit
Bug 28844: Remove GetSuggestionInfoFromBiblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #6 from Jonathan Druart  ---
Created attachment 151004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151004=edit
Bug 28844: Add link between suggestions and orders

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #5 from Jonathan Druart  ---
Created attachment 151003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151003=edit
Bug 28844: DBIC specific

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #4 from Jonathan Druart  ---
Created attachment 151002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151002=edit
Bug 28844: DBIC schema changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #3 from Jonathan Druart  ---
Created attachment 151001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151001=edit
Bug 28844: DB changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2022-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29311

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27595

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2021-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #2 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #1)
> Looks like we need an additional link between the 2 tables aqorders and
> suggestions to achieve that.
> 
> That would make sense, especially when looking at such code:
> 
>  SELECT suggestions.*,
> U1.surname  AS surnamesuggestedby,
> U1.firstnameAS firstnamesuggestedby,
> U1.borrowernumber   AS borrnumsuggestedby
> FROM suggestions
> LEFT JOIN borrowers AS U1 ON suggestedby=U1.borrowernumber
> WHERE biblionumber=?
> LIMIT 1
> 
> in GetSuggestionInfoFromBiblionumber. It is wrong if there are several
> suggestions on the same bib.
> 
> Hard to know it won't break existing workflows however.

I agree - we should have a real link and not be guessing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2021-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr,
   ||severine.que...@bulac.fr

--- Comment #1 from Jonathan Druart  ---
Looks like we need an additional link between the 2 tables aqorders and
suggestions to achieve that.

That would make sense, especially when looking at such code:

 SELECT suggestions.*,
U1.surname  AS surnamesuggestedby,
U1.firstnameAS firstnamesuggestedby,
U1.borrowernumber   AS borrnumsuggestedby
FROM suggestions
LEFT JOIN borrowers AS U1 ON suggestedby=U1.borrowernumber
WHERE biblionumber=?
LIMIT 1

in GetSuggestionInfoFromBiblionumber. It is wrong if there are several
suggestions on the same bib.

Hard to know it won't break existing workflows however.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2021-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28881
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/