https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Janusz Kaczmarek changed:
What|Removed |Added
Blocks||36834
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Phil Ringnalda changed:
What|Removed |Added
Blocks||24424
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Fridolin Somers changed:
What|Removed |Added
Blocks||35490
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Martin Renvoize changed:
What|Removed |Added
Blocks||34549
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Nick Clemens changed:
What|Removed |Added
Blocks||33270
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Nick Clemens changed:
What|Removed |Added
Blocks||34014
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Blocks||33069
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Aleisha Amohia changed:
What|Removed |Added
Blocks||33347
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Nick Clemens changed:
What|Removed |Added
Blocks||32798
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Status|Needs documenting |RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|Needs documenting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #138804|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #136 from Tomás Cohen Arazi ---
Created attachment 140008
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140008=edit
Bug 29697: (QA follow-up) Remove useless warning
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #135 from Tomás Cohen Arazi ---
Created attachment 140007
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140007=edit
Bug 29697: (QA follow-up) Make tests less fragile
This patch makes the tests less
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #134 from Tomás Cohen Arazi ---
Comment on attachment 138804
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138804
Bug 29697: WIP - fix t/db_dependent/Search.t
Review of attachment 138804:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Andrew Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Nick Clemens changed:
What|Removed |Added
Attachment #139127|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #132 from Nick Clemens ---
Created attachment 139127
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139127=edit
Bug 29697: (follow-up) Check against itemnumbers for visibility
No items are shoing on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #131 from Jonathan Druart ---
(those tests are a mess!)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #130 from Jonathan Druart ---
The following change should fix the second failure but it does not.
diff --git a/C4/Search.pm b/C4/Search.pm
index 75da21a4e6a..21b33d85fe9 100644
--- a/C4/Search.pm
+++ b/C4/Search.pm
@@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #128 from Jonathan Druart ---
Created attachment 138804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138804=edit
Bug 29697: WIP - fix t/db_dependent/Search.t
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #127 from Jonathan Druart ---
This broke t/db_dependent/Search.t for non-LIGHT_RUN (Koha_Master). The data
from koha-misc4dev are not inserted and there are no items in the DB. But those
tests expect items with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #126 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #125)
> Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!
I broke, I fix ;)
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #125 from Tomás Cohen Arazi ---
Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #124 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #123)
> Created attachment 138090 [details] [review]
> Bug 29697: Fix t/db_dependent/Search.t
>
> Signed-off-by: Tomas Cohen Arazi
I have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #138081|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #122 from Jonathan Druart ---
Created attachment 138089
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138089=edit
Bug 29697: tracklinks should not explode on invalid marc record
Caught by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #121 from Jonathan Druart ---
Created attachment 138081
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138081=edit
Bug 29697: Fix t/db_dependent/Search.t
FIXME This does not seem correct.
I bet it was
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #120 from Jonathan Druart ---
Created attachment 138080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138080=edit
Bug 29697: Fix t/Search.t
# Failed test 'No tests run for subtest "searchResults
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #119 from Jonathan Druart ---
Created attachment 138079
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138079=edit
Bug 29697: Reintroduce wrongly removed import
# Failed test 'No tests run for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #118 from Jonathan Druart ---
Created attachment 138078
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138078=edit
Bug 29697: Fix t/db_dependent/Exporter/Record.t
Not sure about the warn, we shouldn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #138076|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #116 from Jonathan Druart ---
Created attachment 138076
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138076=edit
Bug 29697: Replace some missing occurrences
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||23247
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #115 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||31224
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #114 from Tomás Cohen Arazi ---
Created attachment 138057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138057=edit
Bug 29697: (follow-up) Indexing a deleted record is not expected to crash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #113 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #103)
> Last patch would benefit from a QA review but I don't want to set the status
> back to NQA and lose it for weeks.
Looks good to me, handing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
Attachment #137924|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #111 from Jonathan Druart ---
Rebased against master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137894|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137840|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137839|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137838|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137837|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137836|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #137835|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #103 from Jonathan Druart ---
Last patch would benefit from a QA review but I don't want to set the status
back to NQA and lose it for weeks.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #102 from Jonathan Druart ---
Created attachment 137894
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137894=edit
Bug 29697: Don't crash ES reindex if a record is wrong
We don't want
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #101 from Tomás Cohen Arazi ---
(In reply to Joonas Kylmälä from comment #100)
> (In reply to Jonathan Druart from comment #99)
> > May need to be investigated before push.
>
> In comment 81 the cause was deemed to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #99 from Jonathan Druart ---
Looks like ktd is failing to setup if those patches are applied and
KOHA_ELASTICSEARCH is set to 1.
koha_1 | [942] Indexing biblios
koha_1 | Invalid data, cannot decode metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--- Comment #98
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #97 from Joonas Kylmälä ---
Created attachment 137840
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137840=edit
Bug 29697: Deal with the degraded view in detail.pl
In detail.pl we must provide a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #96 from Joonas Kylmälä ---
Created attachment 137839
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137839=edit
Bug 29697: Fix tests
Signed-off-by: Marcel de Rooy
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #95 from Joonas Kylmälä ---
Created attachment 137838
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137838=edit
Bug 29697: Use flag embed_items
Includes:
Bug 29697: (follow-up) Use flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #94 from Joonas Kylmälä ---
Created attachment 137837
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137837=edit
Bug 29697: Remove GetHiddenItemnumbers
Signed-off-by: Marcel de Rooy
JD amended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #93 from Joonas Kylmälä ---
Created attachment 137836
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137836=edit
Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
Attachment #135797|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #90
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #89 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #83)
> I missed the other comment anyway, so not ready for PQA.
Fixed.
Waiting for Joonas to approve comment 81.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #88 from Jonathan Druart ---
Created attachment 135982
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135982=edit
Bug 29697: Deal with the degraded view in detail.pl
In detail.pl we must provide a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #87 from Jonathan Druart ---
Created attachment 135981
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135981=edit
Bug 29697: Fix tests
Signed-off-by: Marcel de Rooy
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #86 from Jonathan Druart ---
Created attachment 135980
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135980=edit
Bug 29697: Use flag embed_items
Includes:
Bug 29697: (follow-up) Use flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #85 from Jonathan Druart ---
Created attachment 135979
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135979=edit
Bug 29697: Remove GetHiddenItemnumbers
Signed-off-by: Marcel de Rooy
JD amended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #135798|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #83 from Jonathan Druart ---
I missed the other comment anyway, so not ready for PQA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #82 from Jonathan Druart ---
Joonas, I let you switch the status back to PQA if you agree with the previous
comment.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #81 from Jonathan Druart ---
(In reply to Joonas Kylmälä from comment #80)
> I found another problem, after this patch the zebra rebuild doesn't work:
>
> root@kohadevbox:koha(master)$ koha-shell kohadev
> $ perl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #80 from Joonas Kylmälä ---
I found another problem, after this patch the zebra rebuild doesn't work:
root@kohadevbox:koha(master)$ koha-shell kohadev
$ perl misc/migration_tools/rebuild_zebra.pl -b
error retrieving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #79 from Katrin Fischer ---
Good catch, Joonas!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@iki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #77 from Jonathan Druart ---
Patches rebased against master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #76 from Jonathan Druart ---
Created attachment 135802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135802=edit
Bug 29697: Deal with the degraded view in detail.pl
In detail.pl we must provide a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #75 from Jonathan Druart ---
Created attachment 135801
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135801=edit
Bug 29697: Fix tests
Signed-off-by: Marcel de Rooy
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #74 from Jonathan Druart ---
Created attachment 135800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135800=edit
Bug 29697: Use flag embed_items
Includes:
Bug 29697: (follow-up) Use flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #73 from Jonathan Druart ---
Created attachment 135799
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135799=edit
Bug 29697: Remove GetHiddenItemnumbers
Signed-off-by: Marcel de Rooy
JD amended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #72 from Jonathan Druart ---
Created attachment 135798
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135798=edit
Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #135668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #70 from Nick Clemens ---
(In reply to Tomás Cohen Arazi from comment #69)
> (In reply to Marcel de Rooy from comment #44)
> > See also IRC
> >
> > -my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber =>
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #69 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #44)
> See also IRC
>
> -my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber =>
> $biblionumber });
> +my $biblio =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #68 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #67)
> (In reply to Marcel de Rooy from comment #60)
> > (In reply to Jonathan Druart from comment #59)
> > > (In reply to Marcel de Rooy from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #67 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #60)
> (In reply to Jonathan Druart from comment #59)
> > (In reply to Marcel de Rooy from comment #48)
> > > +my $invalid_marc_record = $@ ||
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #66 from Jonathan Druart ---
Created attachment 135673
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135673=edit
Bug 29697: Deal with the degraded view in detail.pl
In detail.pl we must provide a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #65 from Jonathan Druart ---
Created attachment 135672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135672=edit
Bug 29697: Fix tests
Signed-off-by: Marcel de Rooy
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #64 from Jonathan Druart ---
Created attachment 135671
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135671=edit
Bug 29697: Use flag embed_items
Includes:
Bug 29697: (follow-up) Use flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #63 from Jonathan Druart ---
Created attachment 135670
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135670=edit
Bug 29697: Remove GetHiddenItemnumbers
Signed-off-by: Marcel de Rooy
JD amended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #62 from Jonathan Druart ---
Created attachment 135669
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135669=edit
Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #135662|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #60 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #59)
> (In reply to Marcel de Rooy from comment #48)
> > +my $invalid_marc_record = $@ || !$marc_record;
> > +if ($invalid_marc_record) {
> > +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #135580|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #59 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #47)
> diff --git a/catalogue/detail.pl b/catalogue/detail.pl
> index 502963f8d6..120fc28a88 100755
> --- a/catalogue/detail.pl
> +++
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #58 from Marcel de Rooy ---
opac/opac-detail.pl:
if ( scalar @all_items >= 1 ) {
@items_to_show = Koha::Items->search( { itemnumbers => [ map {
$_->{itemnumber} } @all_items ] } )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #57 from Marcel de Rooy ---
Just a bit of post testing ;)
Crash on opening cart
Not a HASH reference at /usr/share/koha/opac/opac-basket.pl line 99
my @items= $biblio->items->filter_by_visible_in_opac({ patron
1 - 100 of 159 matches
Mail list logo