[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #24 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Pedro Amorim changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.03

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lisette Scheer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #21 from Emily Lamancusa --- (In reply to Katrin Fischer from comment #20) > I perltidied the unit test file a little to make the QA test tools green. > Emily: remember to run "qa" on your branch before submitting and

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #20 from Katrin Fischer --- I perltidied the unit test file a little to make the QA test tools green. Emily: remember to run "qa" on your branch before submitting and have a look at how to use the our new perltidy file

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katrin Fischer changed: What|Removed |Added Attachment #153992|0 |1 is obsolete|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katrin Fischer changed: What|Removed |Added Attachment #153991|0 |1 is obsolete|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Emily Lamancusa changed: What|Removed |Added Blocks||34435 Referenced Bugs:

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Emily Lamancusa changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #16 from Emily Lamancusa --- Created attachment 153992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153992=edit Bug 34117: Add unit tests To test: prove t/db_dependent/Koha/Patron/Categories.t --

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Attachment #153982|0 |1 is obsolete|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 ByWater Sandboxes changed: What|Removed |Added Attachment #153977|0 |1 is obsolete|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Emily Lamancusa changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #13 from Emily Lamancusa --- Created attachment 153977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153977=edit Bug 34117: Remove side effect from get_expiry_date If get_expiry_date is passed a

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Emily Lamancusa changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail.

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Attachment #152657|0 |1 is obsolete|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Assignee|lu...@bywatersolutions.com |jonathan.druart+koha@gmail.

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #12 from Jonathan Druart --- If the change fixes the problem originally describe here, we should make the change here, and obsolete the existing patch. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #11 from Emily Lamancusa --- Yes, that's the idea I was trying to get across :) That fix looks viable to me! Changing the behavior of a method seems like it would also come with a side effect risk, but that would be

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #10 from Jonathan Druart --- Ok so maybe I get it now. If that was the original problem then the correct fix is (in get_expiry_date): -$date = dt_from_string( $date ) unless ref $date; +$date = ref $date

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #9 from Jonathan Druart --- (In reply to Emily Lamancusa from comment #8) > (In reply to Jonathan Druart from comment #7) > > Sorry, I haven't seen Emily's comment! > > > > There is something weird here as well: > > 105

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #8 from Emily Lamancusa --- (In reply to Jonathan Druart from comment #7) > Sorry, I haven't seen Emily's comment! > > There is something weird here as well: > 105 sub get_expiry_date { > 109 $date =

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #7 from Jonathan Druart --- Sorry, I haven't seen Emily's comment! There is something weird here as well: 105 sub get_expiry_date { 109 $date = dt_from_string( $date ) unless ref $date; Which means

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Emily Lamancusa changed: What|Removed |Added CC|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Laura Escamilla changed: What|Removed |Added CC|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 ByWater Sandboxes changed: What|Removed |Added Attachment #152656|0 |1 is obsolete|

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #2 from Lucas Gass --- Created attachment 152656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152656=edit Bug 34117: Add ymd to date_from_string when duplicating patron To test: - have or make a

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #1 from Andrew Fuerste-Henry --- I noticed this first in a 22.11 system and confirmed it on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.