[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Kyle M Hall changed: What|Removed |Added Attachment #84851|0 |1 is obsolete|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #66 from Kyle M Hall --- Created attachment 84851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84851=edit Bug 3534: (QA Follow-up) Fix the return value for the new format, it should be a hashref, not

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Fridolin SOMERS changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | --

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Zeno Tajoli changed: What|Removed |Added Text to go in the||This patch

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Katrin Fischer changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Indranil Das Gupta changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nicole C. Engard changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #63 from Jonathan Druart --- I have squashed 2 patches for the readability. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #59 from Jonathan Druart --- Created attachment 53172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53172=edit Bug 3534 - QA Followup - use floating save I am

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #60 from Jonathan Druart --- Created attachment 53173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53173=edit Bug 3534 (QA Followup) Fix indentation, show

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #61 from Jonathan Druart --- Created attachment 53174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53174=edit Bug 3534 (QA Followup) Rebase and change

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #62 from Jonathan Druart --- Created attachment 53175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53175=edit Bug 3534: Force margin-left: 0 for second button

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Attachment #52934|0

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #57 from Nick Clemens --- (In reply to Jonathan Druart from comment #55) > I think you should trick the code to have only 1 toolbar for the 2 forms. > You will need to add a flag to check, to

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #53109|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #54 from Nick Clemens --- (In reply to Jonathan Druart from comment #52) > Why do you use another id for the toolbar? You won't need to add this > specific JS code if you just use "toolbar" as

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #53 from Nick Clemens --- Created attachment 53109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53109=edit Bug 3534 (QA Followup) Move QA save toolbar and use same class as

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #51 from Nick Clemens --- Created attachment 52937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52937=edit Bug 3534 (QA Followup) Rebase and change floating save --

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #52586|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #52585|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #52584|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #46 from Nick Clemens --- (In reply to Katrin Fischer from comment #42) > The mandatory fields show up nicely, but I have problems using the new > PatronQuickAddFields for adding additional

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #51961|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #52192|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #51960|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #41 from Nick Clemens --- Fixed indents, made guarantor form mandatory (and skip those fields if added) and made sure bad data isn't processed -- You are receiving this mail because: You are

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #40 from Nick Clemens --- Created attachment 52192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52192=edit Bug 3534 (QA Followup) Fix indentation, show guarantor form,

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #39 from Jonathan Druart --- QA comments: 1/ If you put a nonexisting field in the pref (test with surname|sex|xxx), you will see "Expiry date (leave blank for auto calc):". Any

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Attachment #51446|0 |1 is

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Attachment #51445|0 |1 is

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #36 from Nick Clemens --- (In reply to Marc Véron from comment #33) > I re-tested, it seems that the "Save" button in the quick add form no longer > works. Yeah, the quick add save 'clicks' the

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #51389|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #35 from Nick Clemens --- Created attachment 51446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51446=edit Bug 3534 - QA Followup - use floating save I am not sure if this

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #33 from Marc Véron --- I re-tested, it seems that the "Save" button in the quick add form no longer works. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #51382|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50665|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Owen Leonard changed: What|Removed |Added Status|Failed QA |Patch

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #29 from Owen Leonard --- Nick, something I noticed while re-working my patch: If you start an add using the quick add form but there is a problem (for instance, a duplicate card number) the form is

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #27 from Nick Clemens --- (In reply to Owen Leonard from comment #26) > Created attachment 50729 [details] [review] > Bug 3534 [Follow-up] Patron quick add form +[% IF quickadd && opadd %]

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #26 from Owen Leonard --- Created attachment 50729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50729=edit Bug 3534 [Follow-up] Patron quick add form This follow-up move the

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #25 from Nick Clemens --- (In reply to Jonathan Druart from comment #24) > (In reply to Jonathan Druart from comment #18) > > Maybe it would be better not to have it but always add the switch

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #24 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > Maybe it would be better not to have it but always add the switch button > ("Quick-add/Full form") on

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #23 from Nick Clemens --- Moved button and fixed case Restricted whitespace to affected lines (and set my git user.name and user.email) -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50414|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50413|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #20 from Owen Leonard --- I suggested on IRC the separate button menu for "Quick add" because the version of the patch I tested made the quick add action default if PatronQuickAddFields were defined.

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #19 from Jonathan Druart --- Also patch's author of the second patch is "Your Full Name " A lot of patches in the queue (FQA or NSO) are modifying this file, not sure the second

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #18 from Jonathan Druart --- I personally don't think that the new "Quick add New Patron" is well placed. Maybe it would be better not to have it but always add the switch button

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Attachment #50410|0 |1 is

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Attachment #50362|0 |1 is

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #13 from Nick Clemens --- Created attachment 50410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50410=edit Bug 3534 - Fix tabs to spaces -- You are receiving this mail

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #12 from Marc Véron --- Works great now, However QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt FAIL forbidden patterns forbidden pattern:

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Failed QA --

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #11 from Nick Clemens --- (In reply to Marc Véron from comment #9) > Great feature! > But I have a problem when toggling between Quick add and Full form: Fields should now populate when

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50093|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Failed QA --

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #9 from Marc Véron --- Great feature! But I have a problem when toggling between Quick add and Full form: To reproduce: Madatory fields: surname|firstname|cardnumber PatronQuickAdd: Use

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Owen Leonard changed: What|Removed |Added Assignee|jwea...@bywatersolutions.co

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50092|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50091|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50090|0 |1

[Koha-bugs] [Bug 3534] Patron quick add form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #5 from Nick Clemens --- Created attachment 50090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50090=edit Bug 3534 - Patron quick add form This patch adds two new system

[Koha-bugs] [Bug 3534] Patron quick add form

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jesse Weaver changed: What|Removed |Added Change sponsored?|---

[Koha-bugs] [Bug 3534] Patron quick add form

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 3534] Patron quick add form

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 jdem...@roseville.ca.us jdem...@roseville.ca.us changed: What|Removed |Added CC|

[Koha-bugs] [Bug 3534] Patron quick add form

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|