subject:"\[Koha\-bugs\] \[Bug 3820\] Members in Log Viewer Showing \?\? in UPDATE"

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #30 from Josef Moravec  ---
Created attachment 85258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85258=edit
Bug 3820: DB Update to make old cardnumber logs match the new format

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #29 from Josef Moravec  ---
Created attachment 85257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85257=edit
Bug 3820: (follow-up) Clean up warnings

Signed-off-by: Owen Leonard 
Signed-off-by: Charles Farmer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #32 from Josef Moravec  ---
Created attachment 85260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85260=edit
Bug 3820: (QA follow-up) Change REGEXP_REPLACE to REPLACE for wider
compatibility

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #31 from Josef Moravec  ---
Created attachment 85259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85259=edit
Bug 3820: Update tests to reflect the change of behaviour

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Josef Moravec  changed:

   What|Removed |Added

  Attachment #85243|0   |1
is obsolete||
  Attachment #85244|0   |1
is obsolete||
  Attachment #85245|0   |1
is obsolete||
  Attachment #85246|0   |1
is obsolete||

--- Comment #28 from Josef Moravec  ---
Created attachment 85256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85256=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

Signed-off-by: Owen Leonard 
Signed-off-by: Charles Farmer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #27 from Martin Renvoize  ---
Back to signed off now I've added the required update to the tests (and also
added a db update to make old cardnumber logs match the new format.. although
we can't retrospectively populate the logs for other actions the update should
make writing future reports backwards compatible without adding effort.

Let me know if you'd like any further additions to the tests or anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85196|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 85243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85243=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

Signed-off-by: Owen Leonard 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #26 from Martin Renvoize  ---
Created attachment 85246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85246=edit
Bug 3820: Update tests to reflect the change of behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #25 from Martin Renvoize  ---
Created attachment 85245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85245=edit
Bug 3820: DB Update to make old cardnumber logs match the new format

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85197|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 85244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85244=edit
Bug 3820: (follow-up) Clean up warnings

Signed-off-by: Owen Leonard 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Signed Off  |Failed QA
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

--- Comment #22 from Josef Moravec  ---
This is great addition and I like it, but as it changes the behaviour, the test
should be adjusted too:

t/db_dependent/Koha/Patrons.t .. 29/33 
#   Failed test 'Got correct new cardnumber'
#   at t/db_dependent/Koha/Patrons.t line 1414.
#  got: undef
# expected: 'TESTCARDNUMBER'

#   Failed test 'Got correct old cardnumber'
#   at t/db_dependent/Koha/Patrons.t line 1415.
#  got: undef
# expected: 'jY44Hy2e7OojC2Zx7vMo43gzub'

#   Failed test 'With BorrowerLogs, Change in cardnumber should be logged,
as well as general alert of patron mod.'
#   at t/db_dependent/Koha/Patrons.t line 1416.
#  got: '1'
# expected: '2'
# Looks like you failed 3 tests of 3.

#   Failed test 'Log cardnumber change'
#   at t/db_dependent/Koha/Patrons.t line 1417.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Charles Farmer  changed:

   What|Removed |Added

  Attachment #85161|0   |1
is obsolete||

--- Comment #20 from Charles Farmer  ---
Created attachment 85196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85196=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Charles Farmer  changed:

   What|Removed |Added

  Attachment #85162|0   |1
is obsolete||

--- Comment #21 from Charles Farmer  ---
Created attachment 85197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85197=edit
Bug 3820: (follow-up) Clean up warnings

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Owen Leonard  changed:

   What|Removed |Added

  Attachment #85103|0   |1
is obsolete||
  Attachment #85104|0   |1
is obsolete||

--- Comment #18 from Owen Leonard  ---
Created attachment 85161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85161=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #19 from Owen Leonard  ---
Created attachment 85162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85162=edit
Bug 3820: (follow-up) Clean up warnings

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Petr Havel  changed:

   What|Removed |Added

 CC||pe.ha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #17 from Joy Nelson  ---
*** Bug 15296 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

--- Comment #16 from Katrin Fischer  ---
Not against QA'ing this one, but someone might want to beat me to it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85102|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 85103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85103=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #15 from Martin Renvoize  ---
Created attachment 85104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85104=edit
Bug 3820: (follow-up) Clean up warnings

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Nick Clemens  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com
   ||,
   ||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #13 from Martin Renvoize  ---
Changed fields will be listed in canonical order now.

Any opinions on 'before/after' vs 'from/to'.. if we switch to 'from/to' we get
them in that order for free with the canonicalisation switch.. with
'before/after' we will get 'after' coming before 'before' in the output
wherever the raw json is shown as obviously 'a' comes before 'b' in the
alphabet ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85100|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 85102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85102=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2019-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #11 from Martin Renvoize  ---
Created attachment 85100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85100=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction

This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.

Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes.  Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:

  { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

--- Comment #10 from Fiona Borthwick  ---
There is still interest from our customer base on this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2018-06-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

BASE Library Consortium  changed:

   What|Removed |Added

 CC||baselibrary.consortium@nhs.
   ||net,
   ||emma.perks@heartofengland.n
   ||hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2016-06-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #9 from Katrin Fischer  ---
Still valid, see recent discussion on the mailinglist:
https://lists.katipo.co.nz/pipermail/koha/2016-June/045634.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2016-06-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=3469

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2016-06-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=3470

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2016-06-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #8 from Katrin Fischer  ---
*** Bug 8578 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2016-06-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Paul Poulain  changed:

   What|Removed |Added

   Assignee|paul.poul...@biblibre.com   |koha-b...@lists.koha-commun
   ||ity.org
 Status|REOPENED|NEW

--- Comment #7 from Paul Poulain  ---
issue still here in 16.05, updating assignee

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2011-08-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Paul Poulain paul.poul...@biblibre.com 2011-08-02 
14:21:58 UTC ---
The display is now :

UPDATE (executed w/ arg: 1)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2011-08-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-08-02 
14:36:36 UTC ---
I am not sure I understand what 'UPDATE (executed w/ arg: 1)' means.
Ideally the log would tell which fields were updated and the old and new
values. Or at least the new values, so you coudl check previous log entries for
the original values.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2011-08-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-08-02 
15:52:49 UTC ---
frankly katrin, I've hesitated to say this display was not that much useless.
The log let you know who did something and when, but don't say what.
That's another issue I think. Reopen the ticket. Nicole your opinion ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE

2011-08-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

--- Comment #5 from Nicole C. Engard neng...@gmail.com 2011-08-02 23:46:02 
UTC ---
I'm with Katrin on this one - many libraries want a record of who changed what
on a patron's record - and isn't that the point of a log?

Nicole

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

42 matches

Mail list logo