[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_16_candidate -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #25817|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26470 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26470action=edit Bug 4397: Scan index search results broken for non-latin characters The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we where using the wrong one. Using $scanset-display_term(...) instead of $scanset-term(...) fixes the problem. To test: - Do a index scan search (advanced search more options check 'index scan') - Notice non-latin characters are replaced by one or more '@' symbols. - Apply the patch - Re-do the search, everything shows as it should. - Try to follow any of the terms (clicking on them) and notice that it actually gives you relevant results (i.e. is not searching for @). - Sign off :-D Regards To+ [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3 [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term() Sponsored-by: Universidad Nacional de Cordoba Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com I reproduced the issue and I confirm this patch fixes it. I put Fuß in a title, reindex the record. Launch a search on Title checking the scan index checkbox. And the non-latin characters are well displayed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This patch doesn't break anything for me, but I have problems to replicate the original display problem on my installations now. Could someone else give this a try? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Right now, I have problems reproducing the initial issue. Arabic and ß display fine for me on master without the patch, umlauts are still losing their diacritic, ü showing as u. Could it be that this works only for some specific setting? Also if you pick Title from the scan search options, it explodes into a ZOOM error before and after applying the patch. Waiting for Feedback from Tomas. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I have problems applying this patch with git bz... $ git bz apply 4397 Traceback (most recent call last): File /usr/sbin/git-bz, line 2609, in module do_apply(*args) File /usr/sbin/git-bz, line 1688, in do_apply print Bug %d - %s % (bug.id, bug.short_desc) UnicodeEncodeError: 'ascii' codec can't encode character u'\xdf' in position 38: ordinal not in range(128) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- But works fine using wget and git am -iu3... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #4 from Marc Véron ve...@veron.ch --- Created attachment 25817 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25817action=edit [Signed-off] Bug 4397: Scan index search results broken for non-latin characters The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we where using the wrong one. Using $scanset-display_term(...) instead of $scanset-term(...) fixes the problem. To test: - Do a index scan search (advanced search more options check 'index scan') - Notice non-latin characters are replaced by one or more '@' symbols. - Apply the patch - Re-do the search, everything shows as it should. - Try to follow any of the terms (clicking on them) and notice that it actually gives you relevant results (i.e. is not searching for @). - Sign off :-D Regards To+ [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3 [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term() Sponsored-by: Universidad Nacional de Cordoba Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #25742|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||tomasco...@gmail.com Assignee|gmcha...@gmail.com |tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- I reproduced the problem and using yaz-client I noticed it was a Koha problem actually: Z open unix:/home/tomas/koha-dev/var/run/zebradb/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.002084 Z base biblios Z scan @attr 1=4 @attr 4=6 @attr 5=1 t query: @attr 1=4 @attr 4=6 @attr 5=1 t Received ScanResponse 20 entries, position=1 * t (60) tử (1) tạo (1) tập (3) ta (8) tablature (2) table (3) Tack (1) tacka (1) Tadeusz (2) Tage (2) Tagen (3) Taha (1) tài (2) taide (2) Tain (1) Tainted (1) taiteen (1) taiteokset (1) Takashi (18) Elapsed: 0.316274 Z while using Koha returned the @@@ instead, as Katrina explained in the bug description. So = ASSIGNED. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 25742 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25742action=edit Bug 4397: Scan index search results broken for non-latin characters The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we where using the wrong one. Using $scanset-display_term(...) instead of $scanset-term(...) fixes the problem. To test: - Do a index scan search (advanced search more options check 'index scan') - Notice non-latin characters are replaced by one or more '@' symbols. - Apply the patch - Re-do the search, everything shows as it should. - Try to follow any of the terms (clicking on them) and notice that it actually gives you relevant results (i.e. is not searching for @). - Sign off :-D Regards To+ [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3 [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term() Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4397] display problems (umlauts, ß) with scan index in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |In Discussion --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Scan shows Zebra internal datas. I think it is normal to see characters the way the are indexed, no the way they are in record. Transformations depends on word-phrase-utf.chr config file. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
