[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Tomás Cohen Arazi changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Liz Rea wizzy...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #110 from M. Tompsett mtomp...@hotmail.com --- (In reply to Tomás Cohen Arazi from comment #109) Patches pushed to master. Thanks Mark and everyone involved in QA, this one has been a big effort for everyone involved!

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||14111

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #106 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39359 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39359action=edit Bug 5010: Fix - replace tab with spaces Signed-off-by:

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #108 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Additionally: I git grepped on several case combinations of OPACBaseUrl and found this exception: t/db_dependent/Auth_with_cas.t contains OpacBaseURL (NOK)

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #107 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Great work, Mark. This took some time :) Code looks good to me. No complaints from qa tools. I understood that Martin tested the shibboleth case. I did not

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39086|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Component|Lists

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #104 from M. Tompsett mtomp...@hotmail.com --- (In reply to M. Tompsett from comment #103) I ended up making the same sorts of changes that are in bug 14111 in order for it to pass the t/Auth_with_shibboleth.t tests.

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||13774 --

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks|14111 |

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #101 from M. Tompsett mtomp...@hotmail.com --- (In reply to Bernardo Gonzalez Kriegel from comment #100) Tested what I can, not plack/shibboleth/cas For plack: https://github.com/digibib/kohadevbox (Because I don't

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #102 from M. Tompsett mtomp...@hotmail.com --- (In reply to M. Tompsett from comment #101) For shibboleth: I figure the tests are good enough, but you need Test::DBIx::Class (which I believe is in the kohadevbox :) )

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39008|0

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39009|0

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38834|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38833|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||14111 --

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38658|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38659|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||14120 --

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #93 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38659 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38659action=edit Bug 5010: Fix - replace tab with spaces Signed-off-by:

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38128|0

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #94 from Jonathan Druart jonathan.dru...@biblibre.com --- Signing off but it needs another one, I did not really follow the test plan. -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #37695|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #36177|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||10988 --

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35854|0

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #87 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patch fixed an easy conflict on updatedatabase.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35847|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35853|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35852|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35760|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35760|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35760|1 |0

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35833|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Patch complexity|Large patch |Medium

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #35662|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #33726|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31787|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #75 from Owen Leonard oleon...@myacpl.org --- (In reply to M. Tompsett from comment #74) The _get_uri function will need to be amended in bug 8446, if this passes first, or a patch added afterwards if passes later. So an

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #74 from M. Tompsett mtomp...@hotmail.com --- The _get_uri function will need to be amended in bug 8446, if this passes first, or a patch added afterwards if passes later. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Patch complexity|Small patch |Large patch

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31729|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27951|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31727|0 |1

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31728|0 |1